mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] drm: logicvc: switch to for_each_child_of_node_scoped()
Date: Fri, 11 Oct 2024 15:06:46 +0200	[thread overview]
Message-ID: <fbaefd5b-8677-4af1-8ace-206018bd9265@gmail.com> (raw)
In-Reply-To: <Zwkhuyq39LQSZCIN@louis-chauvet-laptop>

On 11/10/2024 15:01, Louis Chauvet wrote:
> Hi,
> 
> I think you can squash this commit with the prvious one, I don't think 
> this is needed to add of_node_put and remove it just after.
> 
> Thanks,
> Louis Chauvet
> 

Hi Louis,

Thanks for your review. I did not squash them because the first one
would apply to stable patches (note the Cc: tag) that are older than the
scoped macro, which was introduced this year.

Best regards,
Javier Carrasco


  parent reply	other threads:[~2024-10-11 13:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-10 23:11 [PATCH 0/3] drm: logicvc: add of_node_put() and switch to a more secure approach Javier Carrasco
2024-10-10 23:11 ` [PATCH 1/3] drm: logicvc: fix missing of_node_put() in for_each_child_of_node() Javier Carrasco
2024-10-11 13:06   ` Louis Chauvet
2024-10-10 23:11 ` [PATCH 2/3] drm: logicvc: switch to for_each_child_of_node_scoped() Javier Carrasco
2024-10-11 13:01   ` Louis Chauvet
2024-10-11 13:06     ` Louis Chauvet
2024-10-11 13:06     ` Javier Carrasco [this message]
2024-10-10 23:11 ` [PATCH 3/3] drm: logicvc: use automatic cleanup facility for layers_node Javier Carrasco
2024-10-11 13:01   ` Louis Chauvet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbaefd5b-8677-4af1-8ace-206018bd9265@gmail.com \
    --to=javier.carrasco.cruz@gmail.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®