From: Jon Hunter <jonathanh@nvidia.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Robert Lin <robelin@nvidia.com>
Cc: thierry.reding@gmail.com, tglx@linutronix.de, pohsuns@nvidia.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
sumitg@nvidia.com
Subject: Re: [PATCH v5 1/3] clocksource/drivers/timer-tegra186: add WDIOC_GETTIMELEFT support
Date: Tue, 29 Apr 2025 10:15:18 +0100 [thread overview]
Message-ID: <fbb3a1b3-3949-402a-b51c-f5446a392e83@nvidia.com> (raw)
In-Reply-To: <aBCU5vec0XMX5VRz@mai.linaro.org>
Hi Daniel,
On 29/04/2025 09:59, Daniel Lezcano wrote:
> On Mon, Apr 21, 2025 at 06:08:19PM +0800, Robert Lin wrote:
>> From: Pohsun Su <pohsuns@nvidia.com>
>>
>> This change adds support for WDIOC_GETTIMELEFT so userspace
>> programs can get the number of seconds before system reset by
>> the watchdog timer via ioctl.
>>
>> Signed-off-by: Pohsun Su <pohsuns@nvidia.com>
>> Signed-off-by: Robert Lin <robelin@nvidia.com>
>> ---
>
> Hi Robert,
>
> I realize that this driver should be split in two and the watchdog part go
> under drivers/watchdog.
Are there any other examples you know of where the timer is split in
this way? It is not clear to me how you propose we do this?
BTW, for this series, I just want to get these updates merged. Any other
re-factoring we can handle later.
Cheers!
Jon
--
nvpublic
next prev parent reply other threads:[~2025-04-29 9:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 10:08 [PATCH v5 0/3] clocksource: fix Tegra234 SoC Watchdog Timer Robert Lin
2025-04-21 10:08 ` [PATCH v5 1/3] clocksource/drivers/timer-tegra186: add WDIOC_GETTIMELEFT support Robert Lin
2025-04-28 14:03 ` Jon Hunter
2025-04-29 3:50 ` Robert Lin
2025-04-29 8:59 ` Daniel Lezcano
2025-04-29 9:15 ` Jon Hunter [this message]
2025-04-29 13:19 ` Daniel Lezcano
2025-04-29 14:23 ` Thierry Reding
2025-04-30 17:24 ` Daniel Lezcano
2025-04-21 10:08 ` [PATCH v5 2/3] clocksource/drivers/timer-tegra186: fix watchdog self-pinging Robert Lin
2025-04-21 10:08 ` [PATCH v5 3/3] clocksource/drivers/timer-tegra186: Remove unused bits Robert Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbb3a1b3-3949-402a-b51c-f5446a392e83@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pohsuns@nvidia.com \
--cc=robelin@nvidia.com \
--cc=sumitg@nvidia.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®