From: Mark Brown <broonie@kernel.org>
To: Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>
Cc: Frank Li <Frank.li@nxp.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Iuliana Prodan <iuliana.prodan@nxp.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
imx@lists.linux.dev
Subject: Re: [PATCH 1/9] ASoC: SOF: imx: introduce more common structures and functions
Date: Tue, 4 Feb 2025 17:15:38 +0000 [thread overview]
Message-ID: <fbb837ba-d4e4-4e34-8554-fbb878716289@sirena.org.uk> (raw)
In-Reply-To: <db81aa4e-dc1f-4c6d-b58f-82883622b0dc@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
On Tue, Feb 04, 2025 at 06:59:53PM +0200, Laurentiu Mihalcea wrote:
> On 2/3/2025 9:52 PM, Frank Li wrote:
> > On Mon, Feb 03, 2025 at 12:18:00PM -0500, Laurentiu Mihalcea wrote:
> >> +static void imx_handle_reply(struct imx_dsp_ipc *ipc)
> >> +{
> >> + unsigned long flags;
> >> + struct snd_sof_dev *sdev = imx_dsp_get_data(ipc);
> >> +
> >> + spin_lock_irqsave(&sdev->ipc_lock, flags);
> >> + snd_sof_ipc_process_reply(sdev, 0);
> >> + spin_unlock_irqrestore(&sdev->ipc_lock, flags);
> > Are you sure have to use spin_lock?
> not sure, this definition was taken from previous drivers. I'd say keep it for now
> as removing it would require some more testing which will take some time.
If it's just factoring out common code it does make sense to do the
factoring out then incrementally change the locking as a separate change.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-02-04 17:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 17:17 [PATCH 0/9] Refactor imx drivers and introduce support for imx95 Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 1/9] ASoC: SOF: imx: introduce more common structures and functions Laurentiu Mihalcea
2025-02-03 19:52 ` Frank Li
2025-02-04 16:59 ` Laurentiu Mihalcea
2025-02-04 17:15 ` Mark Brown [this message]
2025-02-05 16:10 ` Frank Li
2025-02-05 18:58 ` Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 2/9] ASoC: SOF: imx8: use common imx chip interface Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 3/9] ASoC: SOF: imx8: use IMX_SOF_* macros Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 4/9] ASoC: SOF: imx8: shuffle structure and function definitions Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 5/9] ASoC: SOF: imx8: drop unneeded/unused macros/header includes Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 6/9] ASoC: SOF: imx8: make imx8_ops_init() an util function Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 7/9] ASoC: SOF: imx: merge imx8 and imx8m drivers Laurentiu Mihalcea
2025-02-03 17:18 ` [PATCH 8/9] ASoC: SOF: imx: merge imx8 and imx8ulp drivers Laurentiu Mihalcea
2025-02-03 20:06 ` Frank Li
2025-02-04 16:46 ` Laurentiu Mihalcea
2025-02-05 16:12 ` Frank Li
2025-02-03 17:18 ` [PATCH 9/9] ASoC: SOF: imx: add driver for the imx95 chip Laurentiu Mihalcea
2025-02-10 16:29 ` [PATCH 0/9] Refactor imx drivers and introduce support for imx95 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbb837ba-d4e4-4e34-8554-fbb878716289@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Frank.li@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=imx@lists.linux.dev \
--cc=iuliana.prodan@nxp.com \
--cc=laurentiumihalcea111@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®