From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C72EC4321D for ; Tue, 21 Aug 2018 03:35:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96C472170E for ; Tue, 21 Aug 2018 03:35:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96C472170E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726560AbeHUGxw (ORCPT ); Tue, 21 Aug 2018 02:53:52 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:11178 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725734AbeHUGxw (ORCPT ); Tue, 21 Aug 2018 02:53:52 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id E92C27645C9AC; Tue, 21 Aug 2018 11:35:31 +0800 (CST) Received: from [127.0.0.1] (10.134.22.195) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.399.0; Tue, 21 Aug 2018 11:35:31 +0800 Subject: Re: [PATCH 1/2] f2fs: fix to avoid quota inode leak in ->put_super To: Jaegeuk Kim , Chao Yu CC: , References: <20180817091840.50792-1-yuchao0@huawei.com> <20180818151600.GA84798@jaegeuk-macbookpro.roam.corp.google.com> <20180821023840.GD20263@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: Date: Tue, 21 Aug 2018 11:35:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180821023840.GD20263@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/8/21 10:38, Jaegeuk Kim wrote: > On 08/20, Chao Yu wrote: >> On 2018/8/18 23:16, Jaegeuk Kim wrote: >>> On 08/17, Chao Yu wrote: >>>> generic/019 reports below error: >>>> >>>> __quota_error: 1160 callbacks suppressed >>>> Quota error (device zram1): write_blk: dquota write failed >>>> Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota >>>> Quota error (device zram1): write_blk: dquota write failed >>>> Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota >>>> Quota error (device zram1): write_blk: dquota write failed >>>> Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota >>>> Quota error (device zram1): write_blk: dquota write failed >>>> Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota >>>> Quota error (device zram1): write_blk: dquota write failed >>>> Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota >>>> VFS: Busy inodes after unmount of zram1. Self-destruct in 5 seconds. Have a nice day... >>>> >>>> If we failed in below path due to fail to write dquot block, we will miss >>>> to release quota inode, fix it. >>>> >>>> - f2fs_put_super >>>> - f2fs_quota_off_umount >>>> - f2fs_quota_off >>>> - f2fs_quota_sync <-- failed >>>> - dquot_quota_off <-- missed to call >>>> >>>> Signed-off-by: Chao Yu >>>> --- >>>> fs/f2fs/super.c | 6 ++++-- >>>> 1 file changed, 4 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >>>> index a5df9fbc6355..9647bbcdfd2b 100644 >>>> --- a/fs/f2fs/super.c >>>> +++ b/fs/f2fs/super.c >>>> @@ -1977,10 +1977,12 @@ void f2fs_quota_off_umount(struct super_block *sb) >>>> for (type = 0; type < MAXQUOTAS; type++) { >>>> err = f2fs_quota_off(sb, type); >>>> if (err) { >>>> + int ret = dquot_quota_off(sb, type); >>>> + >>> >>> Could you check the mainline version? >> >> I guess we missed to apply below patch? Could you check that? >> >> f2fs: report error if quota off error during umount > > I remember there was a bug in the patch. Yeah, I guess this patch can fix that one. So could you help trying to test again with the two patches if you have time. :) Thanks, > >> >> Thanks, >> >>> >>>> f2fs_msg(sb, KERN_ERR, >>>> "Fail to turn off disk quota " >>>> - "(type: %d, err: %d), Please " >>>> - "run fsck to fix it.", type, err); >>>> + "(type: %d, err: %d, ret:%d), Please " >>>> + "run fsck to fix it.", type, err, ret); >>>> set_sbi_flag(F2FS_SB(sb), SBI_NEED_FSCK); >>>> } >>>> } >>>> -- >>>> 2.18.0.rc1 > > . >