mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mahesh Rao <mahesh.rao@altera.com>
To: Greg KH <gregkh@linuxfoundation.org>, Dinh Nguyen <dinguyen@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Matthew Gerlach <matthew.gerlach@altera.com>
Subject: Re: [PATCH 2/5] firmware: stratix10-svc: Implement ID pool management for asynchronous operations
Date: Fri, 22 Aug 2025 15:18:02 +0530	[thread overview]
Message-ID: <fbbcb145-1212-4925-801a-064fbd72e67a@altera.com> (raw)
In-Reply-To: <2025081926-choosy-femur-9765@gregkh>

Hi Greg,
	sure I will make the change in the next version.
	

On 19-08-2025 04:37 pm, Greg KH wrote:
> On Tue, Jul 22, 2025 at 11:30:42AM -0500, Dinh Nguyen wrote:
>> From: Mahesh Rao <mahesh.rao@altera.com>
>>
>> Implement ID pool management API's which will be
>> used for Stratix10 Asynchronous communication with
>> Secure Device Manager. These API's will be used
>> in subsequent patches for ID management in
>> asynchronous operations.
> 
> Please don't "roll your own" id management.  Use the idr data structure
> instead.  It's simple, it works, and we don't have to review your
> hand-made version :)
> 
> thanks,
> 
> greg k-h

Thanks
Mahesh Rao

  reply	other threads:[~2025-08-22  9:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22 16:30 [PATCH 1/5] firmware: stratix10-svc: Add mutex lock and unlock in stratix10 memory allocation/free Dinh Nguyen
2025-07-22 16:30 ` [PATCH 2/5] firmware: stratix10-svc: Implement ID pool management for asynchronous operations Dinh Nguyen
2025-08-19 11:07   ` Greg KH
2025-08-22  9:48     ` Mahesh Rao [this message]
2025-07-22 16:30 ` [PATCH 3/5] firmware: stratix10-svc: Add initial support for asynchronous communication with Stratix10 service channel Dinh Nguyen
2025-08-19 11:08   ` Greg KH
2025-08-22  9:48     ` Mahesh Rao
2025-07-22 16:30 ` [PATCH 4/5] firmware: stratix10-svc: Add support for RSU commands in asynchronous framework Dinh Nguyen
2025-07-22 16:30 ` [PATCH 5/5] firmware: stratix10-rsu: Migrate RSU driver to use stratix10 " Dinh Nguyen
2025-08-19 11:06 ` [PATCH 1/5] firmware: stratix10-svc: Add mutex lock and unlock in stratix10 memory allocation/free Greg KH
2025-08-22  9:47   ` Mahesh Rao
2025-08-22 11:49     ` Greg KH
2025-08-26  3:49       ` Mahesh Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbbcb145-1212-4925-801a-064fbd72e67a@altera.com \
    --to=mahesh.rao@altera.com \
    --cc=dinguyen@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.gerlach@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®