From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 818E8C433E0 for ; Fri, 22 Jan 2021 08:17:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C52A23381 for ; Fri, 22 Jan 2021 08:17:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726694AbhAVIRZ (ORCPT ); Fri, 22 Jan 2021 03:17:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:50256 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727024AbhAVIP3 (ORCPT ); Fri, 22 Jan 2021 03:15:29 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B21B8AB9F; Fri, 22 Jan 2021 08:14:47 +0000 (UTC) Subject: Re: [PATCH v3 3/4] drm/qxl: release shadow on shutdown To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie References: <20210120111240.2509679-1-kraxel@redhat.com> <20210120111240.2509679-4-kraxel@redhat.com> From: Thomas Zimmermann Message-ID: Date: Fri, 22 Jan 2021 09:14:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210120111240.2509679-4-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BHM8OTILCRQMltYlRHrPRsJeGbbtEpZjb" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BHM8OTILCRQMltYlRHrPRsJeGbbtEpZjb Content-Type: multipart/mixed; boundary="cLBy6hjRREc7smgQM8lhwvfJEt4CYYBBI"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie Message-ID: Subject: Re: [PATCH v3 3/4] drm/qxl: release shadow on shutdown References: <20210120111240.2509679-1-kraxel@redhat.com> <20210120111240.2509679-4-kraxel@redhat.com> In-Reply-To: <20210120111240.2509679-4-kraxel@redhat.com> --cLBy6hjRREc7smgQM8lhwvfJEt4CYYBBI Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 20.01.21 um 12:12 schrieb Gerd Hoffmann: > In case we have a shadow surface on shutdown release > it so it doesn't leak. >=20 > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/qxl/qxl_display.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qx= l_display.c > index 38d6b596094d..60331e31861a 100644 > --- a/drivers/gpu/drm/qxl/qxl_display.c > +++ b/drivers/gpu/drm/qxl/qxl_display.c > @@ -1229,5 +1229,9 @@ int qxl_modeset_init(struct qxl_device *qdev) > =20 > void qxl_modeset_fini(struct qxl_device *qdev) > { > + if (qdev->dumb_shadow_bo) { Wrt to my comment on patch 2, this might be the place to unpin the BO. > + drm_gem_object_put(&qdev->dumb_shadow_bo->tbo.base); > + qdev->dumb_shadow_bo =3D NULL; > + } > qxl_destroy_monitors_object(qdev); > } >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --cLBy6hjRREc7smgQM8lhwvfJEt4CYYBBI-- --BHM8OTILCRQMltYlRHrPRsJeGbbtEpZjb Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmAKiXYFAwAAAAAACgkQlh/E3EQov+CQ cw//Z/zn8O5Z7aQqXJbqzjKl8N0/MhAdsp+Tws2mP16RQSTAKFaoGsLEghTXg2H5+9ZiQRxFnvmZ XvvfDkvLkg49VZp6kH5C48xd7OqkFSq7wfE32NrGjsG2DtkCT6rbsD8nqmsOqegCEHdjgXW08ln4 ucmbdn6RBK5N/Qlq8+OojoFGg+J+e/CrbfDG3bOSHtdW1uwXc237oMWaMIEfPKRvOKS84acBw8Mq 1aAvkIMddAnjw4Dw8b114Uj8USxa2xv69V3gU5bss3IhQAcF6jsRDunZKuSlzPlPmNRSe+IJar7F LwR8i+UCT5/XoNvla0pSh8F0nb6sgA2yesGiktmsYC0AgoOiqAF/0JT9b3OWWoL5nxqh83+ez9Z/ vXHtjizay4whuS5AYp+ULuOmQNzNCMoGNamwt/yDrqhpIpVVnkKTDMiwba7CZUzDgzuJRPstyBIm Z7Q+JC06qTduWae6yHNxhodQburqLaxKKKTevXom/F2rbhr4uNZF32cpAFsYX70Fn6EVGL3TOAUq vJNlmMw/Yka019C/mNQvtGakfSbWKKMLs9ssMFzVGvLSQsYCDGup4DM7P7paJrAUaAZAd8SOQpO5 T/oylBM8qFj8u6aDoTWr9deOaHm40Ai2gygwWLA4SbrNlMA6Xk64gTL0JjdB286xnjnIkyY328N1 o1w= =Nuo2 -----END PGP SIGNATURE----- --BHM8OTILCRQMltYlRHrPRsJeGbbtEpZjb--