From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83827C28B2B for ; Fri, 19 Aug 2022 17:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350840AbiHSRNZ (ORCPT ); Fri, 19 Aug 2022 13:13:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350833AbiHSRM7 (ORCPT ); Fri, 19 Aug 2022 13:12:59 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B9711435A9 for ; Fri, 19 Aug 2022 09:33:00 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oP4vV-0007Ko-EU; Fri, 19 Aug 2022 18:32:53 +0200 Message-ID: Subject: Re: [PATCH] drm/etnaviv: Remove duplicate call to drm_gem_free_mmap_offset From: Lucas Stach To: "T.J. Mercier" , Russell King , Christian Gmeiner , David Airlie , Daniel Vetter Cc: etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Fri, 19 Aug 2022 18:32:51 +0200 In-Reply-To: <20220706182924.2563058-1-tjmercier@google.com> References: <20220706182924.2563058-1-tjmercier@google.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, dem 06.07.2022 um 18:29 +0000 schrieb T.J. Mercier: > The docs explicitly say the drm_gem_object_release function already calls this, > and this does not appear to be a prerequisite for the call to > etnaviv_gem_ops.release. > This looks correct to me. Patch applied to etnaviv/next. Regards, Lucas > Signed-off-by: T.J. Mercier > --- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > index cc386f8a7116..ecb828e4e156 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > @@ -504,7 +504,6 @@ void etnaviv_gem_free_object(struct drm_gem_object *obj) > kfree(mapping); > } > > - drm_gem_free_mmap_offset(obj); > etnaviv_obj->ops->release(etnaviv_obj); > drm_gem_object_release(obj); >