From: Fernando Fernandez Mancera <fmancera@suse.de>
To: Hangbin Liu <liuhangbin@gmail.com>,
Jay Vosburgh <jv@jvosburgh.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Toppins <jon.toppins+linux@gmail.com>
Cc: Jay Vosburgh <jay.vosburgh@canonical.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Hangbin Liu <liuhangbin@kylinos.cn>
Subject: Re: [PATCH net] bonding: fix wrong extack attribute in ARP validate netlink error path
Date: Thu, 6 Aug 2026 13:23:38 +0200 [thread overview]
Message-ID: <fbc724d3-6f78-4ad8-a3a0-005b055cf225@suse.de> (raw)
In-Reply-To: <20260806-bond_arp_validate-v1-1-3ae005657ef9@kylinos.cn>
On 8/6/26 5:29 AM, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
>
> The attribute of netlink error message should be IFLA_BOND_ARP_VALIDATE
> when ARP validation setting fails.
>
> Fixes: 2bff369b2354 ("bonding: netlink error message support for options")
> Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
> ---
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
Thanks!
> drivers/net/bonding/bond_netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
> index 4a11572f663d..7dc31b2551c4 100644
> --- a/drivers/net/bonding/bond_netlink.c
> +++ b/drivers/net/bonding/bond_netlink.c
> @@ -372,7 +372,7 @@ static int bond_changelink(struct net_device *bond_dev, struct nlattr *tb[],
> int arp_validate = nla_get_u32(data[IFLA_BOND_ARP_VALIDATE]);
>
> if (arp_validate && miimon) {
> - NL_SET_ERR_MSG_ATTR(extack, data[IFLA_BOND_ARP_INTERVAL],
> + NL_SET_ERR_MSG_ATTR(extack, data[IFLA_BOND_ARP_VALIDATE],
> "ARP validating cannot be used with MII monitoring");
> return -EINVAL;
> }
>
> ---
> base-commit: 2a33516f9ef59ad11844d4fc152f889449b5daf3
> change-id: 20260806-bond_arp_validate-359289656609
>
> Best regards,
next prev parent reply other threads:[~2026-08-06 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 3:29 Hangbin Liu
2026-08-06 11:23 ` Fernando Fernandez Mancera [this message]
2026-08-10 23:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbc724d3-6f78-4ad8-a3a0-005b055cf225@suse.de \
--to=fmancera@suse.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jay.vosburgh@canonical.com \
--cc=jon.toppins+linux@gmail.com \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=liuhangbin@kylinos.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®