From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-serial@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
<devicetree@vger.kernel.org>, <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v2 7/7] ARM: zynq: DT: Migrate UART to Cadence binding
Date: Tue, 11 Mar 2014 08:48:47 -0700 [thread overview]
Message-ID: <fbca0284-8a38-4767-bd17-8e5f52b21ef7@CH1EHSMHS005.ehs.local> (raw)
In-Reply-To: <62cd32ad-8743-4d49-a1b6-c178054a9756@CO9EHSMHS011.ehs.local>
On Tue, 2014-03-11 at 09:52AM +0100, Michal Simek wrote:
> On 03/10/2014 10:40 PM, Soren Brinkmann wrote:
> > The Zynq UART is Cadence IP and the driver has been renamed accordingly.
> > Migrate the DT to use the new binding for the UART driver.
> >
> > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> > Acked-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> > This change depends on 'tty: xuartps: Rebrand driver as Cadence UART',
> > which introduces the new clock-names.
> > ---
> > arch/arm/boot/dts/zynq-7000.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> > index 8b67b19392ec..0ed0d4b0579a 100644
> > --- a/arch/arm/boot/dts/zynq-7000.dtsi
> > +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> > @@ -67,19 +67,19 @@
> > };
> >
> > uart0: uart@e0000000 {
> > - compatible = "xlnx,xuartps";
> > + compatible = "xlnx,xuartps", "cdns,uart-r1p8";
> > status = "disabled";
> > clocks = <&clkc 23>, <&clkc 40>;
> > - clock-names = "ref_clk", "aper_clk";
> > + clock-names = "uart_clk", "pclk";
> > reg = <0xE0000000 0x1000>;
> > interrupts = <0 27 4>;
> > };
> >
> > uart1: uart@e0001000 {
> > - compatible = "xlnx,xuartps";
> > + compatible = "xlnx,xuartps", "cdns,uart-r1p8";
> > status = "disabled";
> > clocks = <&clkc 24>, <&clkc 41>;
> > - clock-names = "ref_clk", "aper_clk";
> > + clock-names = "uart_clk", "pclk";
> > reg = <0xE0001000 0x1000>;
> > interrupts = <0 50 4>;
> > };
>
> This should be at least the part of 5/7 because between 5/7 and 7/7
> driver will fail to probe.
The driver should never fail to probe. The old bindings will continue to
work. So, only dependency for this is, the new clock names must be
merged in. So, it has to be rather late in the series.
Sören
next prev parent reply other threads:[~2014-03-11 15:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 21:40 [PATCH v2 0/7] tty: xuartps: Rebranding + DT documentation Soren Brinkmann
2014-03-10 21:40 ` [PATCH v2 1/7] tty: xuartps: Clean up Soren Brinkmann
2014-03-10 21:40 ` [PATCH v2 2/7] tty: xuartps: Print warning in clock notifier Soren Brinkmann
2014-03-10 21:40 ` [PATCH v2 3/7] tty: xuartps: Refactor read-modify-writes Soren Brinkmann
2014-03-10 21:40 ` [PATCH v2 4/7] tty: xuartps: Don't write IRQ disable register to enable interrupts Soren Brinkmann
2014-03-10 21:40 ` [PATCH v2 5/7] tty: xuartps: Rebrand driver as Cadence UART Soren Brinkmann
2014-03-11 8:50 ` Michal Simek
2014-03-11 15:47 ` Sören Brinkmann
2014-03-10 21:40 ` [PATCH v2 6/7] tty: cadence: Document DT binding Soren Brinkmann
2014-03-10 21:40 ` [PATCH v2 7/7] ARM: zynq: DT: Migrate UART to Cadence binding Soren Brinkmann
2014-03-11 8:52 ` Michal Simek
2014-03-11 15:48 ` Sören Brinkmann [this message]
[not found] ` <20140311154847.GI13293@xsjandreislx>
2014-03-12 6:01 ` Michal Simek
2014-03-11 10:46 ` [PATCH v2 0/7] tty: xuartps: Rebranding + DT documentation Michal Simek
2014-03-11 18:29 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbca0284-8a38-4767-bd17-8e5f52b21ef7@CH1EHSMHS005.ehs.local \
--to=soren.brinkmann@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=pawel.moll@arm.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®