From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: <linux-kernel@vger.kernel.org>, Michal Simek <monstr@monstr.eu>,
Pallav Joshi <pallav.joshi@xilinx.com>, <git-dev@xilinx.com>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
<linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH 1/3] video: xilinxfb: Fix OF probing on little-endian systems
Date: Wed, 29 May 2013 09:18:39 -0700 [thread overview]
Message-ID: <fbca0735-c7df-4d44-a429-a2042ed6324a@CO9EHSMHS021.ehs.local> (raw)
In-Reply-To: <502367ddf6d79b7b343b3165ad54cb9e2d4713db.1369843969.git.michal.simek@xilinx.com>
On Wed, May 29, 2013 at 06:12:56PM +0200, Michal Simek wrote:
> From: Michal Simek <monstr@monstr.eu>
>
> DTB is always big-endian that's why is necessary
> to convert it.
>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> drivers/video/xilinxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
> index af0b4fd..5af341e 100644
> --- a/drivers/video/xilinxfb.c
> +++ b/drivers/video/xilinxfb.c
> @@ -428,7 +428,7 @@ static int xilinxfb_of_probe(struct platform_device *op)
> * interface and initialize the tft_access accordingly.
> */
> p = (u32 *)of_get_property(op->dev.of_node, "xlnx,dcr-splb-slave-if", NULL);
You should consider using 'of_property_read_u32() (or one of its other
variants for arrays, strings, etc). That already implicitly does the
endian conversion.
Sören
prev parent reply other threads:[~2013-05-29 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 16:12 Michal Simek
2013-05-29 16:12 ` [PATCH 2/3] video: xilinxfb: Do not use out_be32 IO function Michal Simek
2013-05-29 16:12 ` [PATCH 3/3] video: xilinxfb: Use driver for Xilinx ARM Zynq Michal Simek
2013-05-29 16:18 ` Sören Brinkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbca0735-c7df-4d44-a429-a2042ed6324a@CO9EHSMHS021.ehs.local \
--to=soren.brinkmann@xilinx.com \
--cc=FlorianSchandinat@gmx.de \
--cc=git-dev@xilinx.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=pallav.joshi@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®