From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754879AbcFQMuS (ORCPT ); Fri, 17 Jun 2016 08:50:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:34313 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751757AbcFQMuR (ORCPT ); Fri, 17 Jun 2016 08:50:17 -0400 Subject: Re: [PATCH] mm/compaction: remove local variable is_lru To: Michal Hocko , Ganesh Mahendran References: <1466155971-6280-1-git-send-email-opensource.ganesh@gmail.com> <20160617095030.GB21670@dhcp22.suse.cz> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, hillf.zj@alibaba-inc.com, minchan@kernel.org From: Vlastimil Babka Message-ID: Date: Fri, 17 Jun 2016 14:50:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160617095030.GB21670@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2016 11:50 AM, Michal Hocko wrote: > On Fri 17-06-16 17:32:51, Ganesh Mahendran wrote: >> local varialbe is_lru was used for tracking non-lru pages(such as >> balloon pages). >> >> But commit >> 112ea7b668d3 ("mm: migrate: support non-lru movable page migration") > > this commit sha is not stable because it is from the linux-next tree. > >> introduced a common framework for non-lru page migration and moved >> the compound pages check before non-lru movable pages check. >> >> So there is no need to use local variable is_lru. >> >> Signed-off-by: Ganesh Mahendran > > Other than that the patch looks ok and maybe it would be worth folding > into the mm-migrate-support-non-lru-movable-page-migration.patch Agreed.