From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 295863644C4 for ; Wed, 21 Jan 2026 11:23:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768994596; cv=fail; b=YwjgSnr1CreW9uVgsiVB1SFUvzOUvgLd9hA/GrO7I1dDM5VCq3MkFkhiTRLDrNN8XLPMyb8fN28g2JxLiUSqh7M1TbZfdKJjRPZSuBQcNQlSJTnBnIYnWw9s0xrVpi+WKb57jH/Jz8msqqXBXHjwsG9gNk7Zx3vr4CHbE62les8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768994596; c=relaxed/simple; bh=Xxbd7U9ahY+aGtFKLEbnWZwWiujT2fRmtI8A3WrzRk0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aSsGk/dhB8krM98Ir8OsCxTyCLpdCzdDyewnQeqMvLQWLgFZ51BSpXNfStPNRt/OrL/YRJeLkv2Q32tkjzoDTlHFOMPmK+RKcwrXaiCboMtr+0fZd4+LGm2k998GKdAKk8ZO3I6zeQNN5CcJmzwKriEl1xP+lL3JIZ0xgZ/F5MI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=XlZgreJY; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=x6UENg8H; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="XlZgreJY"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="x6UENg8H" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60L3px0T2708810; Wed, 21 Jan 2026 05:22:40 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=tkvJlJ0mXUgBTvDgY/3neKU4fd3c3n7TwI0iS0d1NJ8=; b= XlZgreJY5CKYuWBrBG0kSWAVTJRK0yKJoJzaoQ3WVhiObgGN4ubbPjDp7i6/yzAt TcGIA1aHs4YY3GIRJAo7IEtFtBOxQBFLKgmrjiEFk0G6jE3Z/O7Ad13W6J2MaFG5 3595PS7iGh7lhCttXCFU4V5DBruTpFj2v68L9stDhjqcKhJAbfKmta+4enzyGTQl LadLPuOUIu0O/dYOKsh5zz7cZscim3VyQB+XuPuyGr5rwnf0fo7vpItiIYV0U7R0 LyZ2qyowQyZx2WpyVW3MFLHiWKkbH810mk0p29pplqmqb1K2LYc6ZTU7viBxRTN+ mOz1oXrljPh2dFxaVR/vXg== Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11022138.outbound.protection.outlook.com [52.101.48.138]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4br8q1vj7m-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 21 Jan 2026 05:22:40 -0600 (CST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UIm2F9B3Qxs1IPO0RdBXIiA+UoaRFn+OcBJijLcczmf7VqiPfrrC9R3xF5xDlhUwip3KM+xjJZIak91BNa07+rLy+M0m18w0a90EY25d16kw73bKDPmJQRFLu3FNH/qgOrhkNSyWDH0mLenWaMwXgsJg13x8+v2wvhR7TyKX0ClBiBRuU//73kaxaeLNO1c1ektStyUTgWqxnhG5wSp9b9i2eMDcEQL4R+D6oXId15LE1lUl9v/L1A5u5oz7y139Nzk77IREv53WJr6zMweXe9wmyQo7UrnK6TMuproKpdaH20dWGkQ5GFeLWUwDT7fLeqyVJqQ4JPK6c/C4TQTRZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tkvJlJ0mXUgBTvDgY/3neKU4fd3c3n7TwI0iS0d1NJ8=; b=oErwdL2CkEWjz/A5m7r+lSw9CdyyGf+hcUDk7potehX+w55zJzs83xfGmVkWlmEBqj6s1k5e5Ev5HCt7Agez8iAOfYRsMf3IhgXQODFycfO5IRrW0aGPF2nGRXCg51rHDGIzdJZaN9WVHjf5nCSH1XcHD5evUWaKl5J9mjM3Az/VI8BNfT4ruDP1QH3IWN1U4q+yMWkDoh4ZKszpGgv/Wc1Kv5MpJaWiFBoXzvm4ILRJNM21GfpTTI1rnErXQ+DkMFhy1CHvAZwbh1gQPLM5Rz2ZtV2ooxhWk94E1XXk1KsXiMIgieR2was8Fz6IfmyaI+EfTo8J+r0aayC50jkHgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tkvJlJ0mXUgBTvDgY/3neKU4fd3c3n7TwI0iS0d1NJ8=; b=x6UENg8HA2lyjFaksihOLaSTLnWdeNg79d+uXkSw5Guxl/22KzxBLfLOq9TlWm8a202RzXHox2rROig5bvtfge1rNdwJc7nAl8wMBbi+VqGPPOn8f2INDnSNXDLPf7VUAZOGb9zHSARxwpCvDxDMgVQ1tuf+Iizr5Sv+dj2Fqso= Received: from CH2PR16CA0026.namprd16.prod.outlook.com (2603:10b6:610:50::36) by SN7PR19MB6853.namprd19.prod.outlook.com (2603:10b6:806:26f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.5; Wed, 21 Jan 2026 11:22:35 +0000 Received: from CH1PEPF0000AD7A.namprd04.prod.outlook.com (2603:10b6:610:50:cafe::25) by CH2PR16CA0026.outlook.office365.com (2603:10b6:610:50::36) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9542.9 via Frontend Transport; Wed, 21 Jan 2026 11:22:35 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CH1PEPF0000AD7A.mail.protection.outlook.com (10.167.244.59) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9542.4 via Frontend Transport; Wed, 21 Jan 2026 11:22:34 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id E1E7E406540; Wed, 21 Jan 2026 11:22:32 +0000 (UTC) Received: from [198.90.208.24] (ediswws06.ad.cirrus.com [198.90.208.24]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id C8A78820249; Wed, 21 Jan 2026 11:22:32 +0000 (UTC) Message-ID: Date: Wed, 21 Jan 2026 11:22:32 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: request_irq() usage in wm8350_register_irq(). To: Sebastian Andrzej Siewior , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org Cc: Lee Jones , Andy Shevchenko References: <20260121111617.quQxFcZK@linutronix.de> Content-Language: en-GB From: Richard Fitzgerald In-Reply-To: <20260121111617.quQxFcZK@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD7A:EE_|SN7PR19MB6853:EE_ X-MS-Office365-Filtering-Correlation-Id: 06744d71-3457-444c-ec41-08de58df5fe9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|61400799027|36860700013|54012099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UXZDRytlVytiNFRTUWxMcVFKSXBNeUNNZndLMER0OEQvWERHMnlUb1hZTGFq?= =?utf-8?B?bEt2d0drNmRJc3RGM1hzblR4SkpBN1lJdkN1dzZBWGhHb1d4THJZdG9Ld1gw?= =?utf-8?B?bzRzVG9lWStBM01QaG4yRkFBK3JyRW9pZ3l2YW5XQkh4QTMvTzIyK0xuVHBZ?= =?utf-8?B?Mzl1dkFMSXhFMmFJekZWWGxGbmd3QS9KVytZRzJCaVZVS0ZabGFkL0VJMTN6?= =?utf-8?B?bWZkNUlZV0ZjMnBTV2dkc0QzRTljcC84clZiS3E3bmw0aW9NVlk2U1FRbitr?= =?utf-8?B?OUI4MjBmSmxqMkZLWkNRQXRiM1FpdXJnSk95VXVadVpCaU1GN1Exek9WY1dw?= =?utf-8?B?Q2tKUXVNVnB4MmFHVitXdmsvN0JySnlacUVxLzk2emVuT3pENkRsckgyZXZ4?= =?utf-8?B?ZllLeXFJYlFKZm94VkRJamkyWWI1N1FRalg2a0ZrVko5aXhYV2Joa2FHK2Zr?= =?utf-8?B?UUhHNC9IWWd6b2VoQTJSU09nWStBR1J5ZHdUdFJpam5pYzZzNHpJMXBsQnlm?= =?utf-8?B?MHBTRDRMb0o5bFgvM0s2S3hpS3BDZHJFaVZaOXgxaEhKSGVLNmFZUlZPU29w?= =?utf-8?B?azdtditUMk5TbFR2TDNObGp6ZzVYRFVSOEFteXR3SEhxY3hrWTY1YTFoaHR1?= =?utf-8?B?dlpsRTlmSUpXdmprR1ZSVDdKRjNjTlFESzQrWHEvdmZRWFRVcTZpZENTT3hP?= =?utf-8?B?bW13dFBUTXMrbDlFWEFHMzgxRUhOYnRaOXRLanl3QjNPQnVTNEJSY3VyNlUv?= =?utf-8?B?Njl1QUppeFdONGVtOHpMbGwxWURxQ2lzRHVOUER6OXZ4YVNEQnZCWmJlSERj?= =?utf-8?B?Ry8yUjhNY2FycmNwZmhQbW5KVlRjQ3F1Vld5Nkcyb0lsVjBDQ201ZG9FQkFP?= =?utf-8?B?eUF6K3RaU09rN2UvU2tUS0hMNTRwMHFYSXltZnh5cWErQmtVVDRxbmFHZ0tM?= =?utf-8?B?M2VrM1VVSklqWFNmcUxrZVYrak9OQ05ESERud1RFQzlWcjJlQm9nYTZzSjRu?= =?utf-8?B?ZmJUSkFzTERBQXNRbVRxdks4cXk2MmtuRjE5MlkrUDZyVGx6K2hyYWtHc1Y1?= =?utf-8?B?VlQ3dFZFcmxsYVFPNUUyTmMvaXMzLzdpVEFhcDRSL3grdzE4NmRjcHFsdmoy?= =?utf-8?B?L09wVWljbE9MV2RNdVhxbU9hOGkreVRWdXNNY2lOaU9FVHBGSllyQXY4UHR5?= =?utf-8?B?ZkpudmlFU1MrUXlkczRDcDhJZnZaQ1c0TnBEYWxLTWRWMWVTNVBpYWt2cDND?= =?utf-8?B?K0pwWUhJS1dQaHd4YkdwQmU2a3hva2o1NGRGTGx0NE1BeTBhc0dnbHQrcFBS?= =?utf-8?B?cFdUMmU2citOUlRaTVhwU1p0VU1IeXFaZzJEdUk5dDdObGErUkhQSDVTbWlQ?= =?utf-8?B?dS9ZM1h1eXpzM0xPNlZGOHZCdDBxZkRNcnhhNGdvNnhDWXltNUFYK2NtSndt?= =?utf-8?B?bkVUQXdVM1NRbk1CSnM1Q1JxY1lFR1BSV2UwSS9hUVczMWY4WVhvMEJRVG5Z?= =?utf-8?B?bkZIcm1rUnR4STZYbGtHUURQdFlwQlNHR3pmdUREb21YL2FtYm1jRThxZnFL?= =?utf-8?B?eW0xWmJwSVEzcngvZ2dJcCtNNitLRThrNUNrV3pRdXpoaDRSdHJ3TTVjaU5j?= =?utf-8?B?dk9abUZQcm5XY01CTlNqTWJ2YlpyNG1odDlybDhteVZCaXU5VVNrMFVnQkNI?= =?utf-8?B?U2JtZFRUOW9OTnlZZ1EzQnU4c0IxZ00waE9udmhlazVKbTBMNDd4Skc0RGc2?= =?utf-8?B?b3J3ZW9HdHI1cFlCUmVUYVNhTUxuR0ljWWg5clV4MTN4bGxpbklIZjQ1MW5P?= =?utf-8?B?Mk9iSmFpaGErbnJiNlAvbXp2cjMrRDMvWEhBOHA2czRjSEhPS1IzNFh5UTdD?= =?utf-8?B?V0JlOE85V1F0SDIzRFUzNjBQMytIRDZMRm0vZ0Vqa0xSVmZ1V1BHb0RoemFB?= =?utf-8?B?M2hpdWgrdGxkWXhCUlQwck84cTV4eHZCRzlVdVZWbUVXRm8wSHk3S0Iyc0Vv?= =?utf-8?B?bzVCaHRUclJ3RFg3azh5R2Z3SVJ5SnFvalJHVFdSZWFTRFFCT3l6RXl2YnN0?= =?utf-8?B?b084Q1Y4VUxHTXhuZDBXYUpCNEhQRExwM1VjOHZHQnV1YWVDRERXRWx3eUJk?= =?utf-8?B?Y1VLb3drai9yeW5SR2dYaHFSL051cUZ3NDJJMTFtMDBpbXEzaHZmU3RCTFkw?= =?utf-8?B?azVlOFJ3bzNTS3NsVWp3bFBpUnpuaUJ1SmNmZFpwd3hUNGk5SjlOdS90WXNk?= =?utf-8?B?ZElTM1hXRmxYbEFwWXRBZnVJakpBPT0=?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(61400799027)(36860700013)(54012099003);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2026 11:22:34.0955 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06744d71-3457-444c-ec41-08de58df5fe9 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CH1PEPF0000AD7A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR19MB6853 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIxMDA5NSBTYWx0ZWRfX0HK5Y9zSni99 kUncs3iRGk8V1uufcbgi5rFc41CPIJyKDtInfqTYi/Sg5wzuiCmieRVpCIdrO7nlNjjgNMibC3t ubkZyrQQ03zY97jbquAZm8hmRuux7ERJYmZssKkLYEnBwZ5VrCFTn/XZ7raB7DyfTz9lLnwMREv eq6eBJR+gtsFjVkrxqwIosBunpf1shhRn3LfGLDxQc5hFKlKxaYmLSvV1BX4i7NTly1oMB/CmmR fS+lxN57VUcTXthmStYYgTU/LT5dTuOT80PIrVn5c13c4yDcNQk2+cU7dHcl75S/YrzbFO/Z0c7 bFdhgYPiZ6fIBaY4+Wa2Dn/AeN62CsNebghClfdEnB+enx07wyPJUtXJqlyK7mNgIVagPOliduZ Msio6NXgOVC1jjnUhFbFAAqN4E0VFONoBhBhMAZEBZBKVJ63JnjU6m0mCxoycKHuEk9F9pP3TqC XYrZ8CnnTQ01q06L2Qw== X-Proofpoint-GUID: IDxyFYn9V3nQ5gHCfECngAn3NBdE6fUL X-Proofpoint-ORIG-GUID: IDxyFYn9V3nQ5gHCfECngAn3NBdE6fUL X-Authority-Analysis: v=2.4 cv=JbmxbEKV c=1 sm=1 tr=0 ts=6970b700 cx=c_pps a=9zj7lKEKmmm8jlyvJfKehg==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Wtwa4ePxMUz3iJ46148A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Reason: safe On 21/01/2026 11:16 am, Sebastian Andrzej Siewior wrote: > Hi, > > I've been staring wm8350_register_irq(). It does > > | request_threaded_irq(irq + wm8350->irq_base, NULL, > | handler, flags, name, data); > > and every single user passes 0 as flags. This means it asks for a > threaded IRQ and does not pass IRQF_ONESHOT. > > So either this is not working because it triggers the warnings > Threaded irq requested with handler=NULL and !ONESHOT > > followed by -EINVAL _or_ every single user of this driver sits in > system where the irqchip is IRQCHIP_ONESHOT_SAFE marked. > Which is it? > > Sebastian Or because request_threaded_irq() supplies a default handler, so handler!=NULL when it calls __setup_irq(). int request_threaded_irq(unsigned int irq, irq_handler_t handler, irq_handler_t thread_fn, unsigned long irqflags, const char *devname, void *dev_id) { ... if (!handler) { if (!thread_fn) return -EINVAL; handler = irq_default_primary_handler; } ... retval = __setup_irq(irq, desc, action); ... }