From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77A8CCCA479 for ; Wed, 13 Jul 2022 08:20:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235497AbiGMIUi (ORCPT ); Wed, 13 Jul 2022 04:20:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235379AbiGMIUR (ORCPT ); Wed, 13 Jul 2022 04:20:17 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3201ED160 for ; Wed, 13 Jul 2022 01:16:20 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 109F06601A33; Wed, 13 Jul 2022 09:15:58 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657700159; bh=7M53S5bGqltVg134JPN859srEpQycq+FAWS7IeNPoXY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=T9hMNh8kpXhhbUp3rLUW4Iu54RZG5/uf2pf0R5b7+QhGGtswSG9Mdrl3FBjGfrXOl yGVr+ZrkZ/rlbPAwI31Uwi3FwudjKSsyfp5hl+XbOnY1SUcZE/rl8fXywDo/TSxXVo /OOWCHZbs1v+XOKWZdna81RRVPNjZHl9olNYfYGqxAXJuetZC4XNasE2nd3jLCMpa2 wxzBgrh1BdE6rHIn7uXWHI/U3Xom7Ce/+F3ZNPGsHK3Uc2YUT+TEvl7f/zhhDi9nef L7YpRUJZBcefUY5PsssOyRn3098dPR2J1AvmLxig9iPFAeCPkzX+PoHfCy84CB/Jh4 ZvtZvc8Ww2zcA== Message-ID: Date: Wed, 13 Jul 2022 10:15:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] iommu/mediatek: Log with dev_err_probe when failing to parse dts Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Joerg Roedel Cc: kernel@collabora.com, Matthias Brugger , Will Deacon , Yong Wu , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20220712214427.544860-1-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220712214427.544860-1-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 12/07/22 23:44, NĂ­colas F. R. A. Prado ha scritto: > mtk_iommu_mm_dts_parse() can fail with EPROBE_DEFER if not all larbs > have probed yet, so use dev_err_probe() to avoid logging as an error in > that case. Also drop the return value from the message since it's > already printed by dev_err_probe(), and add the missing newline at the > end. > > Signed-off-by: NĂ­colas F. R. A. Prado > Reviewed-by: AngeloGioacchino Del Regno