From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752890AbdLKNot (ORCPT ); Mon, 11 Dec 2017 08:44:49 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34931 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752439AbdLKNoq (ORCPT ); Mon, 11 Dec 2017 08:44:46 -0500 X-Google-Smtp-Source: ACJfBosuD+of4Puh8w6mA1HgmW1pL6BuPX40cJUvaUoEgN7fw/McHPBcGNio82c+WpCHSmWDpRu9BA== Subject: Re: [PATCH v1 1/2] usb: phy: tegra: Cleanup error messages To: Thierry Reding Cc: Felipe Balbi , Alan Stern , Greg Kroah-Hartman , Jonathan Hunter , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171211093744.GB10671@ulmo> From: Dmitry Osipenko Message-ID: Date: Mon, 11 Dec 2017 16:44:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171211093744.GB10671@ulmo> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.12.2017 12:37, Thierry Reding wrote: > On Mon, Dec 11, 2017 at 02:07:37AM +0300, Dmitry Osipenko wrote: >> Tegra's PHY driver has a mix of pr_err() and dev_err(), let's switch to >> dev_err() and use common errors message formatting across the driver for >> consistency. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/usb/phy/phy-tegra-usb.c | 72 +++++++++++++++++++++++++---------------- >> 1 file changed, 44 insertions(+), 28 deletions(-) > > Can we also get rid of all the function names in error messages? I see > that for some error messages you've removed them, but then for others > you added them, so you remove inconsistencies on one hand and add other > inconsistencies at the same time. =) I've removed function names where they aren't useful and added where they are. Of course we can change the error message instead of using function name to give a clue from where in the code error is originated. I'll remove function names in v2. > Other than that, I like this. Thanks ;)