From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 546F2C4332F for ; Tue, 29 Nov 2022 08:39:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229748AbiK2Ijj (ORCPT ); Tue, 29 Nov 2022 03:39:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230354AbiK2IjH (ORCPT ); Tue, 29 Nov 2022 03:39:07 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 579766441 for ; Tue, 29 Nov 2022 00:38:42 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id o30so10299417wms.2 for ; Tue, 29 Nov 2022 00:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=XgU2Me36pWpv5WapeJ4LPJ3zFhHMt8NlKreZ17SiFYI=; b=eSdL13nPAAE9KfbRzj2fCIepGM6/yyMJRSpSbtV+qTcW929EIa4OABn8vS5yE4KwVN dhRF4IKu30cR5LMLlmnwFaoBLqN6SL02TGXbzQ2W5eSrWzlbUg6YlFcsxI9lNfHS/059 DZ0ZaUVAH7k73aSGu7vA0WjbHCO04rV1d4G6qVx6TAu1tcGB1lDkzpb8Ie3s2i5OUilh H+NL5OQ7fZAfnVi55MvfEYE8R+DjKIxT//YNB2CU6jdZ8SAnvQ2mY4+OlXalRpVC3gKm xyOx2am5t9bgULDwET1sl91wGzsVBZ4U2AUWsm8RyNtTa+xfK1h0uQa6JROUKj9i6fjJ jhdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XgU2Me36pWpv5WapeJ4LPJ3zFhHMt8NlKreZ17SiFYI=; b=KjxIExd5yuUz7k0NJF09JqhzyZd+hqociE9YhfoT8PUcSEDSnZKFPwKi6qEGaEdwS6 lPI8JIuyvtRctyhiEkfBMOWBiRqcQ2mbwTNv0FchNmTZ4B9yT5ezVd6gTuq9LxrnZt+v m4hw9wZPS0FkSVGHLb0vHjVmIJnC1GRY1PMjzzeBxETQzXst1pWkpGWxFDLI1ciOipov A4ZbP9hgvPKiHz9lGMR4NqjnJ869HAUeI2GlVoL9h7EVCkDjPN5glU+OzTxf8c+jzQow J6VQVVbb1dGQXc9nI/UjPyfOmpqJ3DJ3AD8DQZS36TU5nI7ErDtLnXQOfFataLYzY+ZC qjhg== X-Gm-Message-State: ANoB5pk/SF2bPbCVipr1IsRRQSWX2e0+0ihFYwICv9QGfTPnXcdh3Ajy p4WH8Sg+3PvmqOSgKBDmXDg7/w== X-Google-Smtp-Source: AA0mqf6OAhXAHg9j5+BXVKjL+Xc8gtMngAEKoiv4eF9a4BzThu69gyqxyX8YzEQPD1iPsmDy+DbTAg== X-Received: by 2002:a7b:c00a:0:b0:3cf:e8f0:ad11 with SMTP id c10-20020a7bc00a000000b003cfe8f0ad11mr44668145wmb.65.1669711120927; Tue, 29 Nov 2022 00:38:40 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:2f85:a28c:5df7:9cd2? ([2a01:e0a:982:cbb0:2f85:a28c:5df7:9cd2]) by smtp.gmail.com with ESMTPSA id p7-20020a5d4587000000b0022ae0965a8asm12835842wrq.24.2022.11.29.00.38.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 00:38:40 -0800 (PST) Message-ID: Date: Tue, 29 Nov 2022 09:38:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 1/2] drm/tiny: rpi-lcd-35: Enable driver module autoloading Content-Language: en-US To: Carlo Caione , Mark Brown , Daniel Vetter , David Airlie , Martin Blumenstingl , Kevin Hilman , Kamlesh Gurudasani , Jerome Brunet Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221116-s905x_spi_ili9486-v2-0-084c6e3cd930@baylibre.com> <20221116-s905x_spi_ili9486-v2-1-084c6e3cd930@baylibre.com> Organization: Linaro Developer Services In-Reply-To: <20221116-s905x_spi_ili9486-v2-1-084c6e3cd930@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/11/2022 10:42, Carlo Caione wrote: > SPI devices use the spi_device_id for module autoloading even on > systems using device tree. > > Add the spi_device_id entry to enable autoloading for the 3.5inch RPi > Display (rpi-lcd-35). > > Signed-off-by: Carlo Caione > --- > drivers/gpu/drm/tiny/ili9486.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c > index 1bb847466b10..bd37dfe8dd05 100644 > --- a/drivers/gpu/drm/tiny/ili9486.c > +++ b/drivers/gpu/drm/tiny/ili9486.c > @@ -183,6 +183,7 @@ MODULE_DEVICE_TABLE(of, ili9486_of_match); > > static const struct spi_device_id ili9486_id[] = { > { "ili9486", 0 }, > + { "rpi-lcd-35", 0 }, It should also contain "piscreen" then. Anyway: Reviewed-by: Neil Armstrong > { } > }; > MODULE_DEVICE_TABLE(spi, ili9486_id); >