From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5232344D92 for ; Tue, 7 Jul 2026 08:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783414449; cv=none; b=F5LosRcKeVvWdFLWV22wRN++FJr3YU33E+5VHBW2ADDxK7ZWnkNfL1Nx9NlBGl+zLuSTaJQUepVO9+8UiqPf8d9HCSRr5b3t7LzFz3HhIb5og4BCAJ6vomGYUWMFZRZkF5jz38F5Im0dSMF5YcWV4z2nz5PQDYLa0KbA+OLYY5E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783414449; c=relaxed/simple; bh=H+1xQdIuoHy+Nk2vlq10nHbMJcUSSEPlCSoflmw4yr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jcdMYVOXlnw1uCF8LMylbmkZVuxBLoC8dEN849C/wwHlVoLN4KwaU+OZTT1PnbeKLaRUusMMxC8LSo10pSGPHPcvcLVCN0SMfBBgNKbQbgd7cOCXCQh+XVWONjoPQyeh0IpHceefKf8PHS8+zYpCmek6AfGl6D8JpWnzOB/iD9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=G2JApmaw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HDItK/kS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="G2JApmaw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HDItK/kS" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6678DnF73076952 for ; Tue, 7 Jul 2026 08:54:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= U2n1C9hOFlYsRmTm9Nk1r1gsSE3jJPg/8JSVraPix7s=; b=G2JApmawdiqJgeng aj/GqZciBvsdO78F6chdium2PmjaE3aKnRbSyUByGQH845VNNEA+nk6g+EB3f+Re IYgO5nLxldGTZb1QyM4MIKTf2StoF24DOU9FwiL3XVTRmg/l2O8lZEvOnMXnspcl AikyGa6lvWnIBXhy8U7hKZW8a8avxS9Wvn5wSPy90VwZQ1QVdysUFh73NQ7aiNtA bqEiQaABs9KC7LOC8xYiHLRxS4heUlU4Z446hgwCTeY0UrY8GNg8w9lOUyGvG8WI JmbvoXtIjvL2xYQrU3aOJCZopIRUuMEL3ZVbYlDe+XStDZWyn4Q3TrihztjcXLaN cm5jWQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8vun0d2j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 08:54:07 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c9fe4c5eb39so2530141a12.1 for ; Tue, 07 Jul 2026 01:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783414446; x=1784019246; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U2n1C9hOFlYsRmTm9Nk1r1gsSE3jJPg/8JSVraPix7s=; b=HDItK/kSNujE0dUNvbgdNLTIHOAEIMaEJ6trCNdyHXFn2yeNytNLdL9yDi5l16WWZL 90VHduboccqhPoud+yeLAWL5X7LyN80gTzpLRRpE7HLhDrup3dH7JBRSY0cpfagrZR3Y OZKyh8YDQQyozvY/AWnbSaaG3AK5a7rQzCKaymcIUy1UgsEW2zxqFxMCalGOZnKvdeBl JJe8WOg72w9MBBPj52UT6SkZmQhWmxuXwug8In2gZnJwEutsqYwtyto0z6nMj5nSZlNR joD/vtkMivbYKUjBahuzgVzW0OhqtfqX9gisunbSeKq2ezSEm67qdvbpYFTowH4BVA+C rd/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783414446; x=1784019246; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U2n1C9hOFlYsRmTm9Nk1r1gsSE3jJPg/8JSVraPix7s=; b=PDdITqvIhPF9ioYRcsZUUjEREdnrpqppMC/CsNFP0wSufc+wU1Y5+nmGBCN6bneAh5 n5xMGUyWrV1/q7vujfsfb8wkSzjmur7Tuss8WOXUmaaT+9mHSh9aWTl7JR9RdcQehHku IF0ZiK2yYK0qESjRW2nByjowinHVmKzyhySjRGesfy/suYE2DTGwRXcDekjt2RS/VdPY m5ktkMrmn3QLTV3so8vsTTKq4powAXmP5wNtToK9xYr6wludBqdImGY4xVlOTOE6I1F2 5y+WaJssjyolzxKfDvNMNhYD33G/fALGC3jJz+DCOstLSgZfPYgAUdocAoZgzcMAizgc 9p4g== X-Forwarded-Encrypted: i=1; AHgh+RqHUToQd/5bC3nHh6TYeLSwxnGb5SwJ5b9QCHpFzlIJ5zKP8rSor/d4UlweDp/32hemRF/Sed/fzCfKhrU=@vger.kernel.org X-Gm-Message-State: AOJu0YyWq3PV4Li5g212QAyO4UF+e06DdTIk2rILOkaYoRMzEiyPCbjU g2rVRzhqKn7Ex1/jQkSKIKExgCwq9iskEdhiJHR+YQaxTpBY7NAzcWcNgFXx2Fxqbvy1ATyOLrC //zvPmPoGud2mFJtVl3bFSg+ws0tZo1iAzKHy5d9L1+AF0b8iHugDH7G9ntauMh1KEHM= X-Gm-Gg: AfdE7cmNoLQV83pPu5c/n3lTMUWpCmyBC96hWEJ6A5OX20x1I+5tIzTZOGw7YJMrRjI yfOFFX9nFcMDRqFvgJV1oHjGfJpaK1HOnAK55giuGE1usfQ9ljhf/f2GCWjL8giO26q1lURS/9Q dX0j3tbWOEcoehUPD4m622dpP+NjN4Fw7AmuFWAAP97Vffjylt1huieTYKk2kLk7oeEX6E2kPA/ ZAN/ZgvU/0baxVwYQCTGU2YCidjXgcRPf94NZbEK880RuB8yNpQ4PadsWHpxkagbhxyKBlicq+M 9B4f0rffgkyVIuKTLJ05NpkoccsKvKroykMuEjghENquRe443eoZsBg+S9738a3SaE5XxaUzUNZ D92/BZJuXvWjQHzCqENsRzOAjMGwnCdgdOJEa2W73fiOw X-Received: by 2002:a05:6a21:50f:b0:3bf:b68f:4682 with SMTP id adf61e73a8af0-3c08ec8d9f5mr5523189637.7.1783414446277; Tue, 07 Jul 2026 01:54:06 -0700 (PDT) X-Received: by 2002:a05:6a21:50f:b0:3bf:b68f:4682 with SMTP id adf61e73a8af0-3c08ec8d9f5mr5523149637.7.1783414445809; Tue, 07 Jul 2026 01:54:05 -0700 (PDT) Received: from [10.204.101.214] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659c865asm6275219c88.11.2026.07.07.01.54.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 01:54:05 -0700 (PDT) Message-ID: Date: Tue, 7 Jul 2026 14:23:59 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] media: iris: avoid bit depth validation for capture formats To: Vishnu Reddy , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Dmitry Baryshkov , Neil Armstrong Cc: Bryan O'Donoghue , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260707-qc10c_fix_and_disable_time_delta_based_rc-v1-0-33fa130bc535@oss.qualcomm.com> <20260707-qc10c_fix_and_disable_time_delta_based_rc-v1-1-33fa130bc535@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260707-qc10c_fix_and_disable_time_delta_based_rc-v1-1-33fa130bc535@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDA4NSBTYWx0ZWRfX1r0qiBSdT0ZM 4DXPqjgS2Zd6p6OxUwuiKzel0iCrB+L5g0EPjRP7cugn7R3Tz5DuBFiF5ReKbIIM1QrL/qkIryv yI4ATKHxDpq6UwWnBrokE7SJWhoyCN4= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDA4NSBTYWx0ZWRfX0/zqpqX15Rhd 5EEZEU9qvn+U1Ztbb05j+MUnjicETj4G+hRPhROBvzDJG43RzXGfUoURpW8xUBKqsMv3D6Rr8uj RCVjYJ8XgIDFqVB3gOCrxBnUZA6LuT+OXr27c7CfOZlg7FTlFWzZL0tr+fuHvWG9AuP8PS/j+LG HZzxYQPvAr+4gfX9WCfBqYAod0cqYF73ieWnYWUArehVVJkhqzFuPV5NcfsLbc7i6BiBPvC8O6n sVZR7M3ekHjI0tBQNr7Zc5ltlysKYlNWX31g7gX1C4LTJjrmoOqxvROx/58/4PGEhrSyA8K+qKu ThYXl7JG5Dny/aj9TZsPjDIszwO551PCnRSrCwA2ZU1EQGxtr4eizdQ88sg46kVOS+B5hgrOlHX KSvj5rrGbPeCju4JM7uE+mTu2IAvaaKzMm/tFJ7RR5jvyTj+ESaXZ10LT4uON4pcdXlHtKIHQ2o ZnooW+U5UJEqAcsqDNw== X-Proofpoint-GUID: Ar798RmfNzPsX9bXLjbPiM4Z9KQSTme4 X-Authority-Analysis: v=2.4 cv=N+IZ0W9B c=1 sm=1 tr=0 ts=6a4cbeaf cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=0mt3kmHqsDAWChUqZT8A:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-ORIG-GUID: Ar798RmfNzPsX9bXLjbPiM4Z9KQSTme4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_02,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015 adultscore=0 bulkscore=0 suspectscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070085 On 7/7/2026 12:05 PM, Vishnu Reddy wrote: > When validating a capture format, check_format() compares the requested > pixel format against inst->fw_caps[BIT_DEPTH]. However, the bit depth > capability is not available at this stage and it contains the default > value of BIT_DEPTH_8. The actual bit depth is updated later after the > firmware reports stream capabilities through read_input_subcr_params(). > Because of this, a valid QC10C format request is rejected during the client request > initial format negotiation. The driver then falls back to the default > capture format (NV12) and stores it as capture format. > No new line > Later, when the firmware reports that the stream is 10-bit, the driver > sees NV12 as the selected capture format and switches to the default > 10-bit format (P010). As a result, the original QC10C format requested > by userspace is lost and QC10C decoding cannot work correctly. > No new line. > The bit depth information is not reliable during the initial format > setup, so it should not be used to validate capture formats. Remove > the bit-depth checks from check_format() and only verify that the > requested pixel format is supported. This allows the format requested > by userspace is handled correctly. > > Fixes: 20c3ef4c7cae ("media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats") > Cc: stable@vger.kernel.org > Signed-off-by: Vishnu Reddy > --- > drivers/media/platform/qcom/iris/iris_vdec.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c > index 9e228b70420e..7f89e745a4b1 100644 > --- a/drivers/media/platform/qcom/iris/iris_vdec.c > +++ b/drivers/media/platform/qcom/iris/iris_vdec.c > @@ -95,16 +95,6 @@ static bool check_format(struct iris_inst *inst, u32 pixfmt, u32 type) > if (i == size) > return false; > > - if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) { > - if (iris_fmt_is_8bit(pixfmt) && > - inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10) > - return false; > - > - if (iris_fmt_is_10bit(pixfmt) && > - inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10) > - return false; > - } > - > return true; > } > >