From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8C57271457 for ; Fri, 30 Jan 2026 06:56:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769756203; cv=none; b=QiOuNzOojBvw0GRiIzJ86RglnWfUI+RpW+pgFEOaae3rVEGUXN+35JGsvPCEswttiIgWw7OTeXRAE9UCbX9VnNh2tN2PN6vHNtSqlq8RrddBopnHnhpNlMUWkbgsC51xYEhm0/TvVS2ll8GjmmVQ7jX5obf7U+dJg5zpaolQJBU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769756203; c=relaxed/simple; bh=ydnADrdt3dF9S+IKVMg4evGTJf8HU8DfhtFjABtZExA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F6V3P8KQbO8OSXmtrAwy6RgvwBXWVZZ6vEqbSstiFkWtVNd3J1A9x2rP29TormIueg8+AjFjAiUU20rErozf4f3TVHCgNmf25OuJrVtzYPDK3ruILJAiST93ZpSI1HE8aI1yfs5OpvVR9qhvyTW3REDVkV/IomQICFfOLT2whSE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=D5lNNrEY; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="D5lNNrEY" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-47fedb7c68dso18126795e9.2 for ; Thu, 29 Jan 2026 22:56:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1769756200; x=1770361000; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HUIw0RJaE1aXOBsFkdxWp8jD82cs6plN0HTFY2F6+4M=; b=D5lNNrEY5ZU/y2YQXeGgnxKamQ907Ec9Dg8JqH+YCNX+r4FZqQHpZ80ZOLfHKlPvb/ l3e+d2X8QeF/cjaboI5hsqgaGS4pUOt76nQ8q+zv08w5w5nXAjK79ca3/7syMw6OTy3L 4uvhhUKRTH4n5QqOZqNC2zjJAZUBEj0+jMAscfRaShUyWWuBKyjSk447UxbSfp2bhjT3 DSlOVqN4EPIjsYDaKUuQ4r3fklWpW5WyFGuKfBBxjrghUmiVaxJ+OXwU1d0fOVmffQYY qnpaymL/OcMRid7UtfIKvVZcJ9SQEH8XUHoRnyEKbMvyJu53vxeXOv7jdPVcz0TJ7Nza h/kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769756200; x=1770361000; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HUIw0RJaE1aXOBsFkdxWp8jD82cs6plN0HTFY2F6+4M=; b=MM22jc69yptQffBV+kacsXuR+1Mf5uO37H6pb2NBArHzDBHnpBnSBn16Z308zFFd7p iyUAWysJ0aMjfDG+zragNwWYjYqfVdmTavGf3BW3k2+k9ZPSgw7+lXhZC97cN8mGbRIV oDVeoHl0ysIBZiLSUAC6Wb8jtbZHDIeo3xUXPIlGPs7FJiCR6VDTRE7Dg3g+733w78m9 FsuX7hd7fJuv4g4FrE2zaw0kTpI6KwBsU9eERvVSsm+a4UhDVn2dkvauyyT38JPwXG+g kY9v0Ha49bTjDVbizmQ5KLgOBw4bhE8qZAmU3kzwobJsx4qS/uygfTOaDhTHpO9uEuWQ macg== X-Forwarded-Encrypted: i=1; AJvYcCVxolm8rEF/m9LCyx27rUbL37lERRtrgRu8HrdWQBK+VpF1EOvelCI9kTTIP99DVIVFuD+JWObgTh312sA=@vger.kernel.org X-Gm-Message-State: AOJu0YyrumB4ZNZty0TqaaieWOyAkdNo9cJUHIApy5SGcmQRJOreR/Vc pj+HckOO1QOkKJk3brlu/teg+OPRoNHmtFNYGyZYUsmVIpELqNtNBU2m8K5ZOE3lPv4= X-Gm-Gg: AZuq6aIn5xl55z00MVxHXYeqkvAjfkJ1QptIGl/+sN6+B0h6s7updARiaJuR2ghT6Z7 sSXgAUwTt1pvLGm1vFQzNGTaCfxdQKwMmIPzsF7EoL8bj+S6rAwDX6vODFutui9/m6dgn9O1HPx PPEtPXsju3fMW/C7dhpAFQn6K5qu11z6U/4DJ2f7Uz3cf34FeqHilDrk5i8Yf0pUnIFHYOqeRX7 2BS1bNzk2oriAKXQ69ka1+VeUjvRLVBOBrxQn8WF31If4evuJt4n6pyCpaQHHr8yFaQ+8leCtoK TxQVAIe0Vwvd7r/VeBiQgB0nlvS3eBJ8A+8nkw8IPhucI2iMQDHiSKaRQhigT6JE2TpEPyrKhHc Mdxy+gkD2RDMR18gRrhxFIFxeHTtiULy98cEzCWRHDfr0UspaPUOIPRkM6FhiMkM9cvUvodjp8q H2j9bvJU+K+/TIxK4J5A== X-Received: by 2002:a05:600c:4ecd:b0:480:3230:6c89 with SMTP id 5b1f17b1804b1-482db4616damr16802455e9.12.1769756199522; Thu, 29 Jan 2026 22:56:39 -0800 (PST) Received: from [10.31.13.216] ([82.77.28.160]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482dffd47c2sm7593775e9.0.2026.01.29.22.56.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 22:56:38 -0800 (PST) Message-ID: Date: Fri, 30 Jan 2026 08:56:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 10/31] clk: at91: clk-generated: use clk_parent_data To: ryan.wanner@microchip.com, mturquette@baylibre.com, sboyd@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, bmasney@redhat.com, alexander.sverdlin@gmail.com, varshini.rajendran@microchip.com Cc: cristian.birsan@microchip.com, balamanikandan.gunasundar@microchip.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <564e91919099ad05f11d22ff20a6dc674f1d0ba4.1768512290.git.ryan.wanner@microchip.com> Content-Language: en-US From: claudiu beznea In-Reply-To: <564e91919099ad05f11d22ff20a6dc674f1d0ba4.1768512290.git.ryan.wanner@microchip.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Ryan, On 1/16/26 22:07, ryan.wanner@microchip.com wrote: > From: Claudiu Beznea > > Use struct clk_parent_data instead of struct parent_hw as this leads > to less usage of __clk_get_hw() in SoC specific clock drivers and simpler > conversion of existing SoC specific clock drivers from parent_names to > modern clk_parent_data structures. > > Remove the last of the usage of __clk_get_hw(). > > Signed-off-by: Claudiu Beznea > [ryan.wanner@microchip.com: Added SAMA7D65 and SAM9X75 SoCs to the > clk-generated changes. Adjust clk name variable order.] > Signed-off-by: Ryan Wanner > --- > drivers/clk/at91/clk-generated.c | 8 +++---- > drivers/clk/at91/pmc.h | 2 +- > drivers/clk/at91/sam9x7.c | 37 ++++++++++++++++---------------- > drivers/clk/at91/sama7d65.c | 37 ++++++++++++++++---------------- > drivers/clk/at91/sama7g5.c | 35 +++++++++++++++--------------- > 5 files changed, 58 insertions(+), 61 deletions(-) > > diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c > index 4b4edeecc889..d9e00167dbc8 100644 > --- a/drivers/clk/at91/clk-generated.c > +++ b/drivers/clk/at91/clk-generated.c > @@ -319,7 +319,7 @@ struct clk_hw * __init > at91_clk_register_generated(struct regmap *regmap, spinlock_t *lock, > const struct clk_pcr_layout *layout, > const char *name, const char **parent_names, > - struct clk_hw **parent_hws, > + struct clk_parent_data *parent_data, > u32 *mux_table, u8 num_parents, u8 id, > const struct clk_range *range, > int chg_pid) > @@ -329,7 +329,7 @@ at91_clk_register_generated(struct regmap *regmap, spinlock_t *lock, > struct clk_hw *hw; > int ret; > > - if (!(parent_names || parent_hws)) > + if (!(parent_names || parent_data)) > return ERR_PTR(-ENOMEM); > > gck = kzalloc(sizeof(*gck), GFP_KERNEL); > @@ -338,8 +338,8 @@ at91_clk_register_generated(struct regmap *regmap, spinlock_t *lock, > > init.name = name; > init.ops = &generated_ops; > - if (parent_hws) > - init.parent_hws = (const struct clk_hw **)parent_hws; > + if (parent_data) > + init.parent_data = (const struct clk_parent_data *)parent_data; > else > init.parent_names = parent_names; > init.num_parents = num_parents; > diff --git a/drivers/clk/at91/pmc.h b/drivers/clk/at91/pmc.h > index 3d06b1c41f13..d8d491096c0d 100644 > --- a/drivers/clk/at91/pmc.h > +++ b/drivers/clk/at91/pmc.h > @@ -174,7 +174,7 @@ struct clk_hw * __init > at91_clk_register_generated(struct regmap *regmap, spinlock_t *lock, > const struct clk_pcr_layout *layout, > const char *name, const char **parent_names, > - struct clk_hw **parent_hws, u32 *mux_table, > + struct clk_parent_data *parent_data, u32 *mux_table, > u8 num_parents, u8 id, > const struct clk_range *range, int chg_pid); > > diff --git a/drivers/clk/at91/sam9x7.c b/drivers/clk/at91/sam9x7.c > index f98aecdd6f88..d549bdd988e8 100644 > --- a/drivers/clk/at91/sam9x7.c > +++ b/drivers/clk/at91/sam9x7.c > @@ -744,16 +744,15 @@ static const struct { > static void __init sam9x7_pmc_setup(struct device_node *np) > { > struct clk_range range = CLK_RANGE(0, 0); > - const char *main_xtal_name; > + const char *main_xtal_name, *td_slck_name, *md_slck_name; > struct pmc_data *sam9x7_pmc; > const char *parent_names[9]; > void **clk_mux_buffer = NULL; > int clk_mux_buffer_size = 0; > struct regmap *regmap; > struct clk_hw *hw, *main_rc_hw, *main_osc_hw, *main_xtal_hw; > - struct clk_hw *td_slck_hw, *md_slck_hw, *usbck_hw; > + struct clk_hw *usbck_hw; > struct clk_parent_data parent_data[9]; > - struct clk_hw *parent_hws[9]; > int i, j; > > i = of_property_match_string(np, "clock-names", "main_xtal"); > @@ -762,11 +761,15 @@ static void __init sam9x7_pmc_setup(struct device_node *np) > return; > main_xtal_name = of_clk_get_parent_name(np, i); > > - td_slck_hw = __clk_get_hw(of_clk_get_by_name(np, "td_slck")); > - md_slck_hw = __clk_get_hw(of_clk_get_by_name(np, "md_slck")); > + i = of_property_match_string(np, "clock-names", "td_slck"); > + if (i < 0) > + return; > + td_slck_name = of_clk_get_parent_name(np, i); > > - if (!td_slck_hw || !md_slck_hw) > + i = of_property_match_string(np, "clock-names", "md_slck"); > + if (i < 0) > return; > + md_slck_name = of_clk_get_parent_name(np, i); > > regmap = device_node_to_regmap(np); > if (IS_ERR(regmap)) > @@ -862,7 +865,7 @@ static void __init sam9x7_pmc_setup(struct device_node *np) > } > } > > - parent_data[0] = AT91_CLK_PD_NAME("md_slck"); > + parent_data[0] = AT91_CLK_PD_NAME(md_slck_name); > parent_data[1] = AT91_CLK_PD_HW(sam9x7_pmc->chws[PMC_MAIN]); > parent_data[2] = AT91_CLK_PD_HW(sam9x7_plls[PLL_ID_PLLA][PLL_COMPID_DIV0].hw); > parent_data[3] = AT91_CLK_PD_HW(sam9x7_plls[PLL_ID_UPLL][PLL_COMPID_DIV0].hw); > @@ -888,8 +891,8 @@ static void __init sam9x7_pmc_setup(struct device_node *np) > if (IS_ERR(usbck_hw)) > goto err_free; > > - parent_data[0] = AT91_CLK_PD_NAME("md_slck"); > - parent_data[1] = AT91_CLK_PD_NAME("td_slck"); > + parent_data[0] = AT91_CLK_PD_NAME(md_slck_name); > + parent_data[1] = AT91_CLK_PD_NAME(td_slck_name); > parent_data[2] = AT91_CLK_PD_HW(sam9x7_pmc->chws[PMC_MAIN]); > parent_data[3] = AT91_CLK_PD_HW(sam9x7_pmc->chws[PMC_MCK]); > parent_data[4] = AT91_CLK_PD_HW(sam9x7_plls[PLL_ID_PLLA][PLL_COMPID_DIV0].hw); > @@ -940,13 +943,12 @@ static void __init sam9x7_pmc_setup(struct device_node *np) > sam9x7_pmc->phws[sam9x7_periphck[i].id] = hw; > } > > - parent_hws[0] = md_slck_hw; > - parent_hws[1] = td_slck_hw; > - parent_hws[2] = sam9x7_pmc->chws[PMC_MAIN]; > - parent_hws[3] = sam9x7_pmc->chws[PMC_MCK]; > + parent_data[0] = AT91_CLK_PD_NAME(md_slck_name); > + parent_data[1] = AT91_CLK_PD_NAME(td_slck_name); > + parent_data[2] = AT91_CLK_PD_HW(sam9x7_pmc->chws[PMC_MAIN]); > + parent_data[3] = AT91_CLK_PD_HW(sam9x7_pmc->chws[PMC_MCK]); > for (i = 0; i < ARRAY_SIZE(sam9x7_gck); i++) { > u8 num_parents = 4 + sam9x7_gck[i].pp_count; > - struct clk_hw *tmp_parent_hws[6]; > u32 *mux_table; > > mux_table = kmalloc_array(num_parents, sizeof(*mux_table), > @@ -962,16 +964,13 @@ static void __init sam9x7_pmc_setup(struct device_node *np) > u8 pll_id = sam9x7_gck[i].pp[j].pll_id; > u8 pll_compid = sam9x7_gck[i].pp[j].pll_compid; > > - tmp_parent_hws[j] = sam9x7_plls[pll_id][pll_compid].hw; > + parent_data[4 + j] = AT91_CLK_PD_HW(sam9x7_plls[pll_id][pll_compid].hw); > } > > - PMC_FILL_TABLE(&parent_hws[4], tmp_parent_hws, > - sam9x7_gck[i].pp_count); > - Ideally, these kind of changes should have been done through a different patch. Could you please create a different patch for all changes like in this series? With that addressed: Reviewed-by: Claudiu Beznea