From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Rob Herring <robh@kernel.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Clark <robdclark@gmail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding document
Date: Wed, 24 Aug 2016 18:36:35 +0300 [thread overview]
Message-ID: <fbf25a9e-348b-9047-37ef-1b96808dea31@mm-sol.com> (raw)
In-Reply-To: <20160823173259.GA13327@rob-hp-laptop>
Hi Rob,
On 08/23/2016 08:32 PM, Rob Herring wrote:
> On Fri, Aug 19, 2016 at 06:53:19PM +0300, Stanimir Varbanov wrote:
>> Add devicetree binding document for Venus remote processor.
>>
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>> ---
>> .../devicetree/bindings/remoteproc/qcom,venus.txt | 33 ++++++++++++++++++++++
>> 1 file changed, 33 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,venus.txt
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt b/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt
>> new file mode 100644
>> index 000000000000..06a2db60fa38
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt
>> @@ -0,0 +1,33 @@
>> +Qualcomm Venus Peripheral Image Loader
>> +
>> +This document defines the binding for a component that loads and boots firmware
>> +on the Qualcomm Venus remote processor core.
>
> This does not make sense to me. Venus is the video encoder/decoder h/w,
> right? Why is the firmware loader separate from the codec block? Why
> rproc is used? Are there multiple clients? Naming it rproc_venus implies
> there aren't. And why does the firmware loading need 8MB of memory at a
> fixed address?
>
The firmware for Venus case is 5MB. And here is 8MB because of
dma_alloc_from_coherent size restriction.
The address is not really fixed, cause the firmware could support
relocation. In this example I just picked up the next free memory region
in memory-reserved from msm8916.dtsi.
regards,
Stan
next prev parent reply other threads:[~2016-08-24 15:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 15:53 [PATCH 0/4] Venus remoteproc driver Stanimir Varbanov
2016-08-19 15:53 ` [PATCH 1/4] firmware: qcom: scm: add a video command for state setting Stanimir Varbanov
2016-08-19 15:53 ` [PATCH 2/4] firmware: qcom: scm: add iommu scm calls for pg table Stanimir Varbanov
2016-08-22 16:29 ` kbuild test robot
2016-08-24 18:35 ` Gupta, Puja
2016-08-25 9:08 ` Stanimir Varbanov
2016-08-30 21:15 ` Andy Gross
2016-08-19 15:53 ` [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding document Stanimir Varbanov
2016-08-23 17:32 ` Rob Herring
2016-08-23 18:21 ` Bjorn Andersson
2016-08-24 15:36 ` Stanimir Varbanov [this message]
2016-08-25 0:05 ` Bjorn Andersson
2016-08-25 11:10 ` Stanimir Varbanov
2016-08-26 22:23 ` Bjorn Andersson
2016-08-29 11:48 ` Stanimir Varbanov
2016-08-30 17:17 ` Bjorn Andersson
2016-09-01 14:58 ` Stanimir Varbanov
2016-09-01 20:46 ` Andy Gross
2016-09-02 11:52 ` Marek Szyprowski
2016-09-02 20:12 ` Bjorn Andersson
2016-09-07 11:52 ` Stanimir Varbanov
[not found] ` <CGME20160915084644eucas1p1bd3f2078d4e1cb3acfa0ea87557bff4f@eucas1p1.samsung.com>
2016-09-15 8:46 ` Marek Szyprowski
2016-08-19 15:53 ` [PATCH 4/4] remoteproc: qcom: add Venus video core firmware loader driver Stanimir Varbanov
2016-10-18 16:23 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbf25a9e-348b-9047-37ef-1b96808dea31@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®