From: Jacob Keller <jacob.e.keller@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Sean Christopherson <sean.j.christopherson@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH] x86/pkeys: Manually set X86_FEATURE_OSPKE to preserve existing changes
Date: Thu, 27 Feb 2020 10:20:36 -0800 [thread overview]
Message-ID: <fbf2b74e-bc37-985a-11f0-03e5ae5e390c@intel.com> (raw)
In-Reply-To: <20200227180100.GB18629@zn.tnic>
On 2/27/2020 10:01 AM, Borislav Petkov wrote:
> On Wed, Feb 26, 2020 at 04:16:13PM -0800, Jacob Keller wrote:
>> I tested this and it resolves my report! Thanks for a timely fix.
>
> Adding your Tested-by.
>
Yep, thanks.
>> I agree with the analysis. Perhaps it would make sense in the long term
>> to find a solution where get_cpu_cap can remember what was cleared for
>> each CPU and restore those? It already does this using the global
>> variables...
>
> get_cpu_cap() remembers if you use setup_force_cpu_cap() but I agree
> that that whole feature bit handling is a bit, hm, "strange". It had its
> raisins.
Right. Nothing quite equivalent to that for per-CPU changes though.
>
> FWIW, we had started cleaning those up but then the security nightmares
> happened so on the backburner it went...
>
> Thx.
>
Completely understandable. Especially since changes here are tricky to
get right, this being a case in point.
Thanks,
Jake
next prev parent reply other threads:[~2020-02-27 18:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 23:16 Sean Christopherson
2020-02-26 23:32 ` Dave Hansen
2020-02-26 23:40 ` Jacob Keller
2020-02-27 0:16 ` Jacob Keller
2020-02-27 18:01 ` Borislav Petkov
2020-02-27 18:20 ` Jacob Keller [this message]
2020-02-27 18:07 ` [tip: x86/urgent] " tip-bot2 for Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbf2b74e-bc37-985a-11f0-03e5ae5e390c@intel.com \
--to=jacob.e.keller@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®