From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751145AbdAMRZL (ORCPT ); Fri, 13 Jan 2017 12:25:11 -0500 Received: from smtprelay4.synopsys.com ([198.182.47.9]:50947 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750818AbdAMRZG (ORCPT ); Fri, 13 Jan 2017 12:25:06 -0500 Subject: Re: [PATCH 07/37] PCI: dwc: designware: Get device pointer at the start of dw_pcie_host_init To: Kishon Vijay Abraham I , Bjorn Helgaas , Jingoo Han , Joao Pinto , Arnd Bergmann References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-8-git-send-email-kishon@ti.com> CC: , , , , , , , , , , From: Joao Pinto Message-ID: Date: Fri, 13 Jan 2017 17:22:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484216786-17292-8-git-send-email-kishon@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.107.19.116] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! Ās 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: > No functional change. Get device pointer at the beginning of > dw_pcie_host_init instead of getting it all over dw_pcie_host_init. > This is in preparation for splitting struct pcie_port into host and > core structures (Once split pcie_port will not have device pointer). > I think change should be condense with another patch to reduce the patch-set number and to give it real meaning. I understand why you are breaking so much the patch, it is has a lot of changes, but in my opinion is too much fragmented. Thanks Joao