From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B961C433B4 for ; Thu, 15 Apr 2021 13:37:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EE5C61249 for ; Thu, 15 Apr 2021 13:37:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233210AbhDONh0 (ORCPT ); Thu, 15 Apr 2021 09:37:26 -0400 Received: from lb3-smtp-cloud8.xs4all.net ([194.109.24.29]:36177 "EHLO lb3-smtp-cloud8.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232642AbhDONhX (ORCPT ); Thu, 15 Apr 2021 09:37:23 -0400 Received: from [192.168.2.10] ([84.202.3.209]) by smtp.xs4all.nl with ESMTPA id X2Axl3eNOsMyaX2B0lULVP; Thu, 15 Apr 2021 15:36:59 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1618493819; bh=gZoHwNCMoKyEmoDVfhautmQ8Mg0LQtbn5JZYlZAijxU=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=mIjvdkYkWYVJLty5slqCe1PoUZ3rpdG6GeSyU0GnbmHbnCQEm/o5iAW0zWQs03AoK 8K9QvGZsHtG5piJgaxS29cPMeN9Mm55nfkuSzfukSrYG7xl0XYbsCSaLxLuD7FNSJ5 HZYo8KxK2wECqbY5mZVOkYEw50zd8816q1kldYhqeTPfWLSkbMxGUFG82wo3o86G6O PoADtAC3it5W30FRCRTeAIIusNB9YfjV2qT2GnOQALmCfOWCZUEU8GKHogvt+yB/4c sJFODgYIJOS749H8t4YXxfRoq8I7rgvCnBtINWRc6CoypbysJYUmV+/PDF8/EFnjy9 D2MrV/XIV3KRQ== Subject: Re: [PATCH v3] staging: media: zoran: reduce length of a line To: Mitali Borkar , clabbe@baylibre.com, mchehab@kernel.org, gregkh@linuxfoundation.org Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in References: From: Hans Verkuil Message-ID: Date: Thu, 15 Apr 2021 15:36:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfF3kyduNUb4qus6KIfTU6+sc7BExhW7ghIVg9vBpD1Uf5EddXtrtZprcgXSCOUf4dC2fXnlx98lOQPg35NxGvOd2kl4jcpnRs+chJj5aAYsInSVqmKYb fJeFHmbjtyxshFYEYouyY3n38ywXrlZ+6BEOdZm78kDALClha5nFFYknUjHZroVEvI1+WovF5VkKsAf5WLmmZWT67vruVRjr1qey8/cHQG0mHqUa5aW3FWrV d1o5XX8NyOCA+sP7waguefMZd7sNDoOExhaf7bFC8h4F88sFaLoFlwfL00WRSGM0rkhbPwyHaDkV+acscIw+PgQ80qu1YMvvwMr1W3NBcvuEsVKWHBmtToWg kn5apcFH6cV7kb1/KYqZguNBLqLcf8QvydO7IEJzJoiLIjMC+B9M5DStPF1TQjthb7Aoa4ePPk6bKLXw15zUI0UEYj9HRlZpU66MIKkHnhYzscAXeaC2ZjS/ tYNiGCrirBaBeItjov2es+okdiaOvmPJw7ZW8g== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/04/2021 18:35, Mitali Borkar wrote: > Reduced length of a line which exceed the 100 columns limit by splitting > the line into two statements and commenting it with '*' to meet linux > kernel coding style for long(multi-line) comments. > Reported by checkpatch. > > Signed-off-by: Mitali Borkar > --- > > Changes from v2:- Rebased this patch and made changes against mainline > code. > Changes from v1:- Made style changes according to linux kernel coding style > for long comments. > > drivers/staging/media/zoran/zr36060.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/zoran/zr36060.c b/drivers/staging/media/zoran/zr36060.c > index 4f9eb9ff2c42..27eec3446592 100644 > --- a/drivers/staging/media/zoran/zr36060.c > +++ b/drivers/staging/media/zoran/zr36060.c > @@ -249,7 +249,11 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC > static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 }; > static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 }; > > -/* SOF (start of frame) segment depends on width, height and sampling ratio of each color component */ > +/* > + * SOF (start of frame) segment depends on width, > + * height and sampling ratio of each color component > + */ > + No need for this extra newline. The comment block describes the function, so the function should directly follow that comment. Regards, Hans > static int zr36060_set_sof(struct zr36060 *ptr) > { > char sof_data[34]; // max. size of register set >