From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970179AbdIZTKU (ORCPT ); Tue, 26 Sep 2017 15:10:20 -0400 Received: from mail-co1nam03on0080.outbound.protection.outlook.com ([104.47.40.80]:16682 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S968181AbdIZTKR (ORCPT ); Tue, 26 Sep 2017 15:10:17 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Andy Lutomirski , Tom Lendacky , Konrad Rzeszutek Wilk , "Kirill A. Shutemov" , Laura Abbott , Kees Cook , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Subject: Re: [Part1 PATCH v4 12/17] x86/boot: Add early boot support when running with SEV active To: Borislav Petkov References: <20170916123418.37807-1-brijesh.singh@amd.com> <20170916123418.37807-13-brijesh.singh@amd.com> <20170917144147.GJ4733@nazgul.tnic> From: Brijesh Singh Message-ID: Date: Tue, 26 Sep 2017 14:10:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170917144147.GJ4733@nazgul.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR2201CA0023.namprd22.prod.outlook.com (2603:10b6:910:5f::33) To DM2PR12MB0156.namprd12.prod.outlook.com (2a01:111:e400:50ce::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2dc32988-96ce-4227-37e8-08d505123842 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DM2PR12MB0156; X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;3:vlt29wQs7H+I4WwBCNqb580bhZKD5a0Eba0Rdsm8wUnuqZJtFYGLQYKbsfqJsOvW3K/lgNCTRAo7KUww8yyyYzADR8LT1hEQWi4ag9zk3pEvvHEK+d+0s/bhirRtBbYZba7jylbFxru4NxCzSpwzLaivrIBsOHZCd1OiSxtAdOfmmYaRogD8+gqOUGa4BXWkPBf0chXBTaywoRN6zfEv/kZsCHb/1N67aS5r3NiMtcVS1OdKVs5iWB1ZTSGUpXLZ;25:3Y7BoZxNGNwoTFd8LYAWSoDrKqOj1ssyaO0bJcbqfVxtipsZIGxnvteEkTSCVYgzrI4pE2SmRxov+TDFO4syONlJKsQ43XeLFfVnxPBHb3sSGI8H25NIGqs8kQrUnUbYIDnOAY9tgSpQnaHw82pgnRv7L0uMSWHLTzcIuHe+kEkIyWVofy+PLBt1hQT1PNpXXiWDGmetNgwJlRMcnfGZ0ILCkDUrxDL9VgOZyTbTfqMCZKb0IuESwsDjCierKTbkPhsH40Yk39dPNi7BlTJJI/b4gr4MVS6dfMLcYZMpugI9GEnEd14NqrJ9sl1fiqS4KyUe6Lzodr85pJMicEpq8A==;31:dqK+40N2WFrum+lF4lf/EGR9Ky01apXqN8MCyGwEWRMnE906+uPF2VUjQtvVwdQqfyba6i4h9VTtTmZEbPzMFn05uVcBsgpf+sk7O84+oUibnQR6AFD+ITrdVjp5BTeZ7FjhNupDsni/0eFr+gsAdWfQ8tD0VX6YAjNRI8wP272uSiykLpMjrxRiQo2+muXckqj3wyMcVpqTjaevsxHJarK7cxH9zbOAtsbubQZpAR8= X-MS-TrafficTypeDiagnostic: DM2PR12MB0156: X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;20:7m11Ila3gWmyuYODTIQeI4UuTW//E/Ebh/En7GtVwlgzIitSmO37ZKwv1U5VHXnNLR++2J90nElEURosQ8ov/I+30JRWcgWHfBgIcCiKu0jVJc0y92rHaxIx8S3INHxHiFY0sQrfQ67YrzEQDhkpfWEyX5ZeLeR5vq82hmMgw5Z2Ue1GhuIIcL7csm0vCFcD7ggkHvddJvRDdlr/W+ulSVZYYSm0OcmTXXJe+iysKxFNlU09OTcHJhIsCEQPsyw90/oRpC+ndr2Vay7bU3sefpeKKv+GAtsu+ibFPxeT8f8W2d2U6ST31O7NE6GHS9sU6w62dnJ8pj4J9Rwev5n/bR4/YVwhOLpdH/oz8x3rfu6ToS57kxWZI3Swz0li7spKJcF2MYYK0yYZ8uRGNxic73zB+V7QqWqZ7hsDslR1llPIQr7IB/GTe/3Q6MOkjbavIEWf7OUFBzvD0bBWU8qn0k/RGfcaNF1GDldAEWHqwChMW1/Itl5s9qgqEFdcD5Me;4:Fq7YunedY8YOwykVpJLjeIQ5inZTSIIcyRV1JqBc3/s0HcfPrHSdDPx/8LYGKsDHkNhHpIwuxD+yGPZVm4L0fsosBQKsXL9eGcoBDvmsevzbcibQjHq0ocpsrvI7i0P6Nscz/65dhhRUP3fhXeRKHfM+YzHj22Eg3he7PiSBN7NrpI6CktkLy6XiMwUaAVvrktW27kPVYOYDDjvtG2G0wwMr+PBknpix9He6Cw/O/AqyAxK94at3efCQ5EliFiPc X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM2PR12MB0156;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM2PR12MB0156; X-Forefront-PRVS: 0442E569BC X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(39860400002)(346002)(377454003)(199003)(189002)(24454002)(23676002)(53936002)(83506001)(53546010)(189998001)(81156014)(33646002)(6916009)(81166006)(66066001)(7416002)(2950100002)(47776003)(65806001)(8676002)(106356001)(65956001)(6486002)(50466002)(77096006)(65826007)(64126003)(2906002)(6246003)(86362001)(6116002)(101416001)(31696002)(8936002)(478600001)(7736002)(305945005)(68736007)(50986999)(16576012)(54356999)(316002)(76176999)(5660300001)(16526017)(229853002)(3846002)(31686004)(105586002)(4326008)(97736004)(230700001)(58126008)(36756003)(25786009)(54906003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR12MB0156;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjEyTUIwMTU2OzIzOnFobmZJdER5ekVlZmpiNWZkbkQ0T1lNMFhV?= =?utf-8?B?UXRrT042aXNxVE0yN2ZNY01vdmFEMWtIVWVPT01CaTZHMEtzV1RXUC9WSUhF?= =?utf-8?B?a0VVZXVIUkNQS05vblZDajd1alBYMkJNM0NTNFFOQm4vWlBwam8rVU1FNWo5?= =?utf-8?B?RTlRQmwwUnBCZU8wU2tFaXB2UEFvbjh5Q1BHUFVRMzZwZlo3YmpJa3RDQ0pU?= =?utf-8?B?SmYwZTlkT2hmRG02NUU5Z1EvaGpWa3lLT1FwQTVEazB3aUNCcjZ1QUUxUHNj?= =?utf-8?B?T0lCa0YvQWJxVDREWDUwbEhLeDV0bVQrYTY0Q2tpR0FUdVdPcU51d0lUNG04?= =?utf-8?B?ZWt4K0p1MlpLVTdxcXU4REVVZ1h2cm1tNldoZ2haa2lZWTBmb2JpMUtYV3VX?= =?utf-8?B?anpwWWU4UE5CcFNNS2swOFZLWXFWU0hIaVFyMWd6TUJPRXlhdTh2djNDUkhL?= =?utf-8?B?Mkp2RldWS0gwVnhTYlkzVElwOXNQVWFnb0tXUklKM2UzaEVxRHVPYnRBYXR3?= =?utf-8?B?UmRpaGVzQkFEemhES2FIMHNoMFF6TXNWelpTQnY4Q2l3L3R2VGdlbVYvYWg0?= =?utf-8?B?cURTSTliaDJrbHhKUGlxUExVdytKRTdvU3RVWHlOT0xhUUV6SUNRSCtKcUtp?= =?utf-8?B?Smd3WEwrZjByY1VCeG5sV2tiN1hvdHdKc2FUQitzMlE3Wmp6Y2s5VzFzVlZ1?= =?utf-8?B?c0cxV1ZMMmFidUdiTk1aVE5VaUVJdVV3VFVyRUFGWTRIT1NOMVNIbG5Lc0ds?= =?utf-8?B?RjVjbUpWOStZVktCZk9tQVhHWVZ0dWFMUmRsenpaOHdubENXbGFZbzFOQ1V1?= =?utf-8?B?c3ZncTg1ekFORmdoblJPRE85N2JJRVA0bHFKZzV6YlVwdlMzOEpkdTJ6L3Vt?= =?utf-8?B?b01lL2QzR2RtNklhaytjWnU0ZFhZcWx0Um9yQXhmcG90Qkh5RWVUeURsUDlh?= =?utf-8?B?QlFLVWFLaVNHZUtaaUR1UXZ0K2hZL3NRaUdtYU1XRkVsOHN5MXVEKzhXcTVi?= =?utf-8?B?MmhVaTZxTnRKVU51V2xiNHJBb3dQb2lHdDZqRFQ4dmd1ZTVhSWU1QzNQTFlv?= =?utf-8?B?dzdNMXdtL01WcDgwU1lkRmlaK0JyY3djaWlweDdMZHd2bzNhZmZ6QjkxdjZj?= =?utf-8?B?YlNuTndaTUNrOVdLdU8ySHpCei9ZNkdVQ1pLSGlYWmwxSXVsem9QVkIveHFQ?= =?utf-8?B?VDRyUUd3dDVKbHZJSVpkcHRKSVVDSG5mbjV1NCtCZUpIamllaEEyUEc2MDhn?= =?utf-8?B?Z1dta2p1WkZ0bmlkYmNpa0tKYVhabUhOc3d2SHJib0kzMnVFUm5pSVdPQUtm?= =?utf-8?B?SUE0dnhVZ0E0enBvcmh0NGlPMmlDWUhUQWZFSjlYTVhTcnlkdTVqT1hDbFhy?= =?utf-8?B?cjdBckFOcnhKWDFkcSt4L3JsNlNKV0ZFZkFPazB1cEM3czJNUWR1bjh3ZG1B?= =?utf-8?B?N1I0eDgyUmxYeDBENWlxaU4wa01Ka2hSVjYxQXAzY21PVVJWNnd2NXJFekt2?= =?utf-8?B?L2xONW1UZEVHUTR4SFdrdnRFbCtLN09YTWUrQzdLbStlb0hZU3AwU3dyV2th?= =?utf-8?B?OTNUdmVwZklCYkJQN1piUHZVWFBVa3NVR3pZcnIvVjVJNThhNUdMZk9xcGxv?= =?utf-8?B?NmpwdUtLVUxlWDAxd2xuK1dxMFFZZUJKc216dWdJa0FXUFdnSUthS1RacGFy?= =?utf-8?B?emtlM3NJOHptZFJKNzBTTXZvQTNQQ0MzUS9UN2ZReUtDVDZiQmdHN20rVmYx?= =?utf-8?B?TkhPdXBLckYxbWRRWU1CTEt3a2svWU1jT3Z0cVFzYmVLOWtnbGpSRkpqYnhX?= =?utf-8?B?d3pBWEFyVXdMQXQ4bDRWYXJpZHV2M2RBalU0YzQ3K0V2TEtVdzdoRGwycUVX?= =?utf-8?Q?E/0LQarzik8=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;6:OCiL4t1Hi6Hmunm9k1IWxscMblHgpnCdwDqhfnSGQJ4oFGQNrVwq0mt65saxcs0gY1LmdOoM23yeVsqeZGJRkQAuYZkJYlDg8Bre817IrQlQSOnrIRUqvlIyNot9bux2QOT+NCmhv2Aj8SMRCBv9s2aodORywg+xFitLzuzsDwYERUouqsc/2twadHyFHC94JVOAFOpGjO1yNXM4pJkGUpvY3TkzEv20SJQ1NRKClgOdhXwxofadcB/jDVLCPncETM7Db6pl74Ir9Ir6ATwiWlQKI30NR1v7cO6VUPUm2KvwR6vHGpeaC8iy/MSnelOjNppsdFVCQIGgIV+ILwO1GA==;5:18BNfsq/FdbxCTDK/XXnOs0p6IfesuknflnhrT7stzjvyTLz6OgrYbOGBJAs1oZSd0wtOcA8stc6ZRsVzKPFqWrW/9HTl0zZlWYIm1ARHR6c/kZdivUCven5+UEN0Sbpbv2NgsBV9T9zWjE1HRZAaQ==;24:t/6VN9wZlzXst8CwS/V5GqHb+JaYpXzA6opkwv8CMsyojuMwQyQ1OSEGG7ZHLMlaSrAboU5btNyk3MOr579HOGbeIDLRzoAlw7wBCBRacAA=;7:z6zeCzlNOrlT6R1xCuO1guTooVw1tN6H3012HRrG9XfNvOaMRiK/Gf7AbPYh2xknah/PyfACURurYvOf49HP3T46ZohVr7P57DMN8G0t0NVnyRCtmSL40TgyNVpk4b+5ikXRXDqFdix8m8MLrlxAMwwO7Hno7KJom8tl+kmVH9CPyx882IteCaBm5YYVfC9lTqYGylIpkulV00a1HbkAAF8T1gurUcCYiIxFUTGtfyw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;20:Ns72TGugQwiAWh8vUpk5IMddPdSjs9H34K914SJWBtP7fcjLPZumujziUl7pLGC8tP5Qb9yvwtzgGr5bcPlZrapOJBYtdLthqBspGyFes88fyrvanLFu1RZds9P7PEFnswgYYzFwlH7BoCyZpDMYmQd0LQprOhMibEw4KMAiMjqXrdpKSNIIq+60Z3+Ko0x9v/sgpum+xbYh+ypID85XHaVuL86kN2dXBdtLPK4WFIC0uyHd5vvNMMVXReE4y3sV X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2017 19:10:14.5144 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/17/2017 09:41 AM, Borislav Petkov wrote: ... >> +#ifdef CONFIG_AMD_MEM_ENCRYPT >> + push %ebx >> + push %ecx >> + push %edx >> + push %edi >> + >> + call 1f >> +1: popl %edi >> + subl $1b, %edi > > 32-bit RIP-relative addressing huh? :) > > It definitely deserves a comment. > Will add comment in next rev. thanks -Brijesh