From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90EA169DE8 for ; Fri, 1 Mar 2024 08:44:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709282683; cv=none; b=u3xxfiNFdtqMz5PpB0gIePBCkMtBEK1k4aBPlDz+M4bh+BnmlifC4EbKsD8pgxXcnOpHm89c1vNYNFDBhQgR5VuUJZhbbE9L0LI8ikxHF+hTEQK2UeV8bsM6ktLMWqjrJEJxi+IaF72TrYW+sYLPaOKH/I9jnV0eWzhuY/AWD/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709282683; c=relaxed/simple; bh=XLaLLONd4SE+7aUeLHwG5Hrbe4M4/9UkvPrdtUnAvG4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aEDjAz843HWznFbpX2ljADFkq7PZQroTKFELhEckoRnebaRyS50BAz7EzLxqWc1BZGoZ9oVju0e1DzL0zfNH6S79VY7rx/z3IAS0F8+7c5bJ8EzkqDs88lS4ugnNoF/1YHk7QFj+DfWLqem2FnCvYvn68ECRLkvDuCdLOR36Pog= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Bpj8jGdS; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Bpj8jGdS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709282679; bh=XLaLLONd4SE+7aUeLHwG5Hrbe4M4/9UkvPrdtUnAvG4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Bpj8jGdSvexBD3DYnIrk34Uj8pozfpzurdNH7SiTFN5+2gT2uPzciPIOWewktNSik D5FFGsQgofou9YcjIGM4D1d6z3HzerFDXUwyosTBm/Q1SMfRxqaxdnxvv+tubDzrG/ QlZYKm1OKYo+jac0r+u+fOTodMzdMR8lfnF2ScLK3U5ttKAQmwqXRwsw8ORnh6V1bx MNWfTNIDp2iEmsDtqk7vT3y+TS68tSyZxfM4KnXu2by0+NB0Qn/jsJoocHS3crj53K E2W9nEJBlZ7RuwVy1meiMcPazsp3gU5+qvb36hYGl8D4vOKpwqGQPoqO+hD/jn9B9s cuD38kfQa74Pg== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 9C0CB37814A4; Fri, 1 Mar 2024 08:44:37 +0000 (UTC) Message-ID: Date: Fri, 1 Mar 2024 09:44:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 9/9] drm/panel: truly-nt35597: Don't log an error when DSI host can't be found Content-Language: en-US To: Laurent Pinchart , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> <20240229-anx7625-defer-log-no-dsi-host-v2-9-00506941049a@collabora.com> <20240301063020.GL30889@pendragon.ideasonboard.com> From: AngeloGioacchino Del Regno In-Reply-To: <20240301063020.GL30889@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 01/03/24 07:30, Laurent Pinchart ha scritto: > Hi Nícolas, > > Thank you for the patch. > > On Thu, Feb 29, 2024 at 07:12:15PM -0500, Nícolas F. R. A. Prado wrote: >> Given that failing to find a DSI host causes the driver to defer probe, >> make use of dev_err_probe() to log the reason. This makes the defer >> probe reason available and avoids alerting userspace about something >> that is not necessarily an error. >> >> Suggested-by: AngeloGioacchino Del Regno >> Signed-off-by: Nícolas F. R. A. Prado >> --- >> drivers/gpu/drm/panel/panel-truly-nt35597.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c >> index b73448cf349d..d447db912a61 100644 >> --- a/drivers/gpu/drm/panel/panel-truly-nt35597.c >> +++ b/drivers/gpu/drm/panel/panel-truly-nt35597.c >> @@ -550,10 +550,8 @@ static int truly_nt35597_probe(struct mipi_dsi_device *dsi) >> >> dsi1_host = of_find_mipi_dsi_host_by_node(dsi1); >> of_node_put(dsi1); >> - if (!dsi1_host) { >> - dev_err(dev, "failed to find dsi host\n"); >> - return -EPROBE_DEFER; >> - } >> + if (!dsi1_host) >> + return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); > > return dev_err_probe(dev, -EPROBE_DEFER, > "failed to find dsi host\n"); > > With this addressed, I disagree. That's 87 columns, and the 80-col rule is long gone. Reviewed-by: AngeloGioacchino Del Regno > > Reviewed-by: Laurent Pinchart > >> >> /* register the second DSI device */ >> dsi1_device = mipi_dsi_device_register_full(dsi1_host, &info); >> >