From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BBEEC54EE9 for ; Mon, 19 Sep 2022 08:19:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229888AbiISITQ (ORCPT ); Mon, 19 Sep 2022 04:19:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229935AbiISITM (ORCPT ); Mon, 19 Sep 2022 04:19:12 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EC1C20BD9 for ; Mon, 19 Sep 2022 01:19:10 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id c7so21566057ljm.12 for ; Mon, 19 Sep 2022 01:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=UkEI6Wgy4k9VtOrM7WdWbzd7EfHqK85lNcyzLrqA37o=; b=FPsoXJw7FBanwzpf+Nt7c7P93iaUzEZIt6GHy7fz2C1Fazs7THwMWRaJjX5mpYhb1L g3UbE358gq6RnaK0F2yPwBYQdL2c7nVl8VXHLcryRfPH2X/tfXuFHVbNgdAG6Xez22XJ /qwi8/MvK1NyPpLsde0KNGTN5knosmuGMNwWKHZkHZ1nRIGwC6jKH56oB4mOjjRkfI8b /ngy5aoUzI1QAvKY3nGcFLopU2NIzEsv+qzHYKGUi0q6ZMv1eIYaFyscFQqSgZQSEcEe HB+kvg7BN4KOcJjGMfZ9odA5DHHq7EasSPqq4wpubPedsejps/9oPiliGsMGrowb6t7y swIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=UkEI6Wgy4k9VtOrM7WdWbzd7EfHqK85lNcyzLrqA37o=; b=SeEv7xwla7CIUETFl8e/48Bgdeccrx3adF6AUMoZ1fE2Im5GFtv3cJLDaCPzAI8q7U p40+r2uhOirYaSVuRHXC/Z+btjGRKvo/rv7v6r7q9aM8tnslicI5yQF23/BLDz7LuUFJ rc9ya5BhJcxnaxf6NmjRDVDzlhfNOhN0gVSvSjyHot/fV7zmwj2bIZphyfyQKOYfD0Z8 rULPqCsVrA5Juox5i++2VH5g9nMRjoRcVG0Ne62jFv6JjRIU3K/yzJDf4/SFseaE2OX4 Te/bi53H7Jw9r08qjiG7KaFct+XqZTECW7Gb617z9RHRGeSv84xN6Whwa4qer8isRnJg dVdw== X-Gm-Message-State: ACrzQf0cpae6p6qyF2qTQAeH8ad7OBa2FzSaQ0gKhWXKme9NH20KWAh7 RhAyCcZjbzwziXd9KKSIDY2Paw== X-Google-Smtp-Source: AMsMyM46UQAXva4/n5G0JyybDDnqLzhtGsEjIMky24uSv0afcZHXph6nsCJwHu42ZILKQdrrpHprRg== X-Received: by 2002:a2e:9d88:0:b0:26a:95c1:218f with SMTP id c8-20020a2e9d88000000b0026a95c1218fmr4824159ljj.223.1663575548744; Mon, 19 Sep 2022 01:19:08 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id c37-20020a05651223a500b0048b3926351bsm5079034lfv.56.2022.09.19.01.19.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 01:19:08 -0700 (PDT) Message-ID: Date: Mon, 19 Sep 2022 10:19:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] media: dt-bindings: i2c: ovti,ov5640: Drop ref to video-interface-devices.yaml Content-Language: en-US To: "Lad, Prabhakar" , Laurent Pinchart Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Maxime Ripard , Steve Longerbeam , Sakari Ailus , Hans Verkuil , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lad Prabhakar References: <20220916133521.73183-1-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/09/2022 10:08, Lad, Prabhakar wrote: > Hi Laurent, > > Thank you for the review. > > On Sun, Sep 18, 2022 at 12:06 AM Laurent Pinchart > wrote: >> >> Hi Prabhakar, >> >> Thank you for the patch. >> >> On Fri, Sep 16, 2022 at 02:35:21PM +0100, Prabhakar wrote: >>> From: Lad Prabhakar >>> >>> video-interface-devices.yaml isn't used so just drop it from the >>> DT binding doc. >>> >>> Signed-off-by: Lad Prabhakar >>> --- >>> Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml | 3 --- >>> 1 file changed, 3 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml >>> index 540fd69ac39f..ce99aada75ad 100644 >>> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml >>> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml >>> @@ -9,9 +9,6 @@ title: OmniVision OV5640 Image Sensor Device Tree Bindings >>> maintainers: >>> - Steve Longerbeam >>> >>> -allOf: >>> - - $ref: /schemas/media/video-interface-devices.yaml# >>> - >> >> The rotation property listed in this binding uses the definition from >> video-interface-devices.yaml. I don't think just dropping this is the >> right solution. Changing additionaProperties to unevaluatedProperties >> seems a better option. >> > Agreed, I missed rotation was used from video-interface-devices.yaml. > Agreed the changing additionaProperties to unevaluatedProperties seems > a better option. The meaning of unevaluatedProperties:false would be here - accept other properties (not mentioned here explicitly) from referenced schema. If this is your actual intention for this binding, it makes sense. But if the intention in this binding was to disallow these other properties, then it would be wrong to change to unevaluatedProperties. Therefore before sending patches and calling something better or not, please instead focus on that aspect of referenced schema. Best regards, Krzysztof