From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60AB9C5ACC4 for ; Wed, 19 Feb 2020 22:41:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3772E20656 for ; Wed, 19 Feb 2020 22:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582152102; bh=0rG2RXX8ea/4Q5kB7gw8TH6gb4P54HAvmGH4xTZEbJ8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=yO2xrlSXqRoFD3rMUP4bwfV8U6s/VQilbtHQsn+w/kbcfW651FQ2qg++fdO6YyIqs LAc47FMbCj9mH1LRLsh8jK2xqbbuk5akEZRmju4sVSciLHpCQn9ywmPXiHGNr7rviB lcHCyFrn/f99vnGQ8prlcLW0v+85Q1X+2gZY46pU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727868AbgBSWlh (ORCPT ); Wed, 19 Feb 2020 17:41:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:59756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727232AbgBSWlh (ORCPT ); Wed, 19 Feb 2020 17:41:37 -0500 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6949220656; Wed, 19 Feb 2020 22:41:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582152096; bh=0rG2RXX8ea/4Q5kB7gw8TH6gb4P54HAvmGH4xTZEbJ8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=fMFgVvJZeIe0eHLSnI3i+lsObyVlYFwk/nTi6SirOo6IMZqNl4wRXOLs50ItUB+8G NlOTOzBiJ9Y2DlWx7IeZi8dqWlNEXTDGwOuk3tKDPlgOHBux5vr+M7j+f4mhEVYTdP A/iU7cJTgWbA0rPJJEDezpzndRqCC2vMLkfkvf3k= Subject: Re: [PATCH v2] kunit: run kunit_tool from any directory To: Heidi Fahim Cc: Brendan Higgins , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, frowand.list@gmail.com, shuah References: <20200218221916.239951-1-heidifahim@google.com> From: shuah Message-ID: Date: Wed, 19 Feb 2020 15:41:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/19/20 3:38 PM, Heidi Fahim wrote: > On Wed, Feb 19, 2020 at 2:18 PM shuah > wrote: > > Hi Heidi, > > On 2/18/20 3:19 PM, Heidi Fahim wrote: > > Implemented small fix so that the script changes work directories > to the > > root of the linux kernel source tree from which kunit.py is run. This > > enables the user to run kunit from any working directory. Originally > > considered using os.path.join but this is more error prone as we > would > > have to find all file path usages and modify them accordingly. Using > > os.chdir ensures that the entire script is run within /linux. > > > > Signed-off-by: Heidi Fahim > > > Reviewed-by: Brendan Higgins > > > Thanks for  the patch. In the future please include changes from v1 > to v2. > > I am assuming this v2 addresses Frank's comments. > > > Sorry about that! Yes the only change here was in the commit message > addressing Frank's comment. > Great. I will pull this in for 5.6-rc4. thanks, -- Shuah