From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1051678F2E for ; Tue, 2 Jun 2026 12:34:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780403697; cv=none; b=p/rEu5uZVvj/beIMp1X4BQkVNn5zbYDjZuW+DOKiF+853dKPKkXr2SVhyGKRkdztgJXd33XMmYUfwu0JwfkeD0HjUxkX3Nmj3QLaJf4xZXXnlFxn2kBzprVH9R3l03mDCbAjhaOZtKY2izJr4x1KofKuNIAFDRSKmJWRwEv0co4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780403697; c=relaxed/simple; bh=A9ytQBDZ0jBjEJZ4WuHizZfXMvpyh9Y01dEtgv7qEPo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GZmvrNXbflW1ZDj1hGznsllnjxrc+tHUTN8saG9HikJXyCoDTSY22WJWvri20cztT2TF2BZSsWLo2QjC9464c4KL7LlBXIcqCMX/xoYqz3fJl6hzULrle+w2o07lRxwMc4q1FdYfFglwZLSyzYb5X+9v5qRSN3xQUgS8T9usz8w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=KiB+8Gzc; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="KiB+8Gzc" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 9DA221A37CF; Tue, 2 Jun 2026 12:34:53 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 69147603BC; Tue, 2 Jun 2026 12:34:53 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E53FA1088838A; Tue, 2 Jun 2026 14:34:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1780403692; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=zFVWU+aDsuv90mtYSp/sliGlcrwj1MbrwkExwX4mBKk=; b=KiB+8GzcyAXxIs155T8gOxdRZd0/De30sH/M1rFpPeVOpwzL6AmtXNzN8qS+JhO698Sq+C kAu3VIoJGuxncX2WbbreffRpkWD078LHkzJ9BQO/1Zw1vnttmkPZQlGaC79gjxOhBFm7uj Wg2AeZ3xqr/H0HZmo6mKaHC+ZwuHkC5ZJGhr0D+ybyA6yCp1n6l83Ky6lfDdJBMN2zifGm +4zP6wxL8wEkDpd/On+YARX1/3WkIBe6QsXfeVwkOAi17vFWgGARmG+FvrxzcYMvmdnzGF 3dzRNn/XWadw+ZXZHIQNupYvX9PqQ44yGMWmiLUoGQz2GHM5fOtvAKV+H63KnQ== Message-ID: Date: Tue, 2 Jun 2026 14:34:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 6/9] net: dsa: microchip: implement .{get/set}_wol only if needed To: Paolo Abeni , Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Russell King Cc: Pascal Eberhard , =?UTF-8?Q?Miqu=C3=A8l_Raynal?= , Thomas Petazzoni , Tristram Ha , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260526-clean-ksz-3rd-v1-0-5b63e732149a@bootlin.com> <20260526-clean-ksz-3rd-v1-6-5b63e732149a@bootlin.com> Content-Language: en-US From: Bastien Curutchet In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Paolo, On 6/1/26 10:59 AM, Paolo Abeni wrote: > On 5/26/26 11:47 AM, Bastien Curutchet (Schneider Electric) wrote: >> @@ -3798,9 +3795,6 @@ int ksz_set_wol(struct dsa_switch *ds, int port, >> if (wol->wolopts & ~(WAKE_PHY | WAKE_MAGIC)) >> return -EINVAL; >> >> - if (!is_ksz9477(dev) && !ksz_is_ksz87xx(dev)) >> - return -EOPNOTSUPP; > > Sashiko noted there is still a ksz_is_ksz87xx(dev) check in > ksz_wol_pre_shutdown() which would probably keep WoL broken for the > newly enabled switches. > Good catch from Sashiko here. I'm going to replace the is_ksz() checks in ksz_wol_pre_shutdown() with a if (ds->ops->get_wol && ds->ops->set_wol) (as done here in ksz_port_set_mac_address()) to ensure consistency in the WoL handling. Best regards, Bastien