From: "Jürgen Groß" <jgross@suse.com>
To: Penny Zheng <Penny.Zheng@amd.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Cc: "Ray Huang" <Ray.Huang@amd.com>,
"Xenia Ragiadakou" <Xenia.Ragiadakou@amd.com>,
"Jason Andryuk" <jason.andryuk@amd.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v1 1/4] xen/acpi: upload power and performance related data from a PVH dom0
Date: Wed, 4 Dec 2024 09:29:58 +0100 [thread overview]
Message-ID: <fc2ef8da-62e8-431a-8a1b-508b3f9d5ef4@suse.com> (raw)
In-Reply-To: <20241204082430.469092-2-Penny.Zheng@amd.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1835 bytes --]
On 04.12.24 09:24, Penny Zheng wrote:
> From: Roger Pau Monné <roger.pau@citrix.com>
>
> When running as a PVH dom0 the ACPI MADT is crafted by Xen in order to
> report the correct numbers of vCPUs that dom0 has, so the host MADT is
> not provided to dom0. This creates issues when parsing the power and
> performance related data from ACPI dynamic tables, as the ACPI
> Processor UIDs found on the dynamic code are likely to not match the
> ones crafted by Xen in the dom0 MADT.
>
> Xen would rely on Linux having filled at least the power and
> performance related data of the vCPUs on the system, and would clone
> that information in order to setup the remaining pCPUs on the system
> if dom0 vCPUs < pCPUs. However when running as PVH dom0 it's likely
> that none of dom0 CPUs will have the power and performance data
> filled, and hence the Xen ACPI Processor driver needs to fetch that
> information by itself.
>
> In order to do so correctly, introduce a new helper to fetch the _CST
> data without taking into account the system capabilities from the
> CPUID output, as the capabilities reported to dom0 in CPUID might be
> different from the ones on the host.
>
> Note that the newly introduced code will only fetch the _CST, _PSS,
> _PPC and _PCT from a single CPU, and clone that information for all the
> other Processors. This won't work on an heterogeneous system with
> Processors having different power and performance related data between
> them.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
I think this is the V2 version of Jason's patch, of which he sent V3 just
yesterday?
Please sync with him how to proceed: is his patch meant to be a prerequisite
for your series or a part of it?
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2024-12-04 8:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 8:24 [PATCH v1 0/4] xen/acpi: introduce cppc performance hypercall Penny Zheng
2024-12-04 8:24 ` [PATCH v1 1/4] xen/acpi: upload power and performance related data from a PVH dom0 Penny Zheng
2024-12-04 8:29 ` Jürgen Groß [this message]
2024-12-04 19:11 ` Jason Andryuk
2024-12-05 5:24 ` Penny, Zheng
2024-12-04 8:24 ` [PATCH v1 2/4] acpi/cppc: extract _cpc entry parsing logic Penny Zheng
2024-12-04 8:24 ` [PATCH v1 3/4] xen/cppc: get xen-required cppc perf caps data Penny Zheng
2024-12-04 8:24 ` [PATCH v1 4/4] xen/cppc: introduce cppc data upload sub-hypercall Penny Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc2ef8da-62e8-431a-8a1b-508b3f9d5ef4@suse.com \
--to=jgross@suse.com \
--cc=Penny.Zheng@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Xenia.Ragiadakou@amd.com \
--cc=jason.andryuk@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®