From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C481C1975A for ; Wed, 25 Mar 2020 17:11:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D33920772 for ; Wed, 25 Mar 2020 17:11:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727780AbgCYRL3 (ORCPT ); Wed, 25 Mar 2020 13:11:29 -0400 Received: from mga18.intel.com ([134.134.136.126]:18529 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727236AbgCYRL3 (ORCPT ); Wed, 25 Mar 2020 13:11:29 -0400 IronPort-SDR: 8bnQmxiLvNKkXOGvXSBIGR8SKO9XsY937nqDTPKsSwe6uRrBZNWZlO3u83Sh82F7lA4KTnt8Eu l+E1yLvgKs+w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2020 10:11:28 -0700 IronPort-SDR: Hgk5JsRye62SfxXWbRs7QcZEYKfPtXiRGFHqkAp3QoFWBNsnRwGSJ2deMLcU1HSu1VN9Ekp38k OO8jmTFth/SA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,304,1580803200"; d="scan'208";a="270872870" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.87]) ([10.237.72.87]) by fmsmga004.fm.intel.com with ESMTP; 25 Mar 2020 10:11:26 -0700 Subject: Re: [PATCH] perf tools: Add missing Intel CPU events to parser To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org References: <20200324150443.28832-1-adrian.hunter@intel.com> <20200325103345.GA1856035@krava> <20200325131549.GB14102@kernel.org> <20200325135350.GA1888042@krava> <20200325142214.GD14102@kernel.org> <20200325152211.GA1908530@krava> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Wed, 25 Mar 2020 19:10:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200325152211.GA1908530@krava> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/03/20 5:22 pm, Jiri Olsa wrote: > On Wed, Mar 25, 2020 at 04:24:58PM +0200, Adrian Hunter wrote: >> On 25/03/20 4:22 pm, Arnaldo Carvalho de Melo wrote: >>> Em Wed, Mar 25, 2020 at 02:53:50PM +0100, Jiri Olsa escreveu: >>>> On Wed, Mar 25, 2020 at 10:15:49AM -0300, Arnaldo Carvalho de Melo wrote: >>>>> Em Wed, Mar 25, 2020 at 11:33:45AM +0100, Jiri Olsa escreveu: >>>>>> On Tue, Mar 24, 2020 at 05:04:43PM +0200, Adrian Hunter wrote: >>>>>>> perf list expects CPU events to be parseable by name, e.g. >>>>> >>>>>>> # perf list | grep el-capacity-read >>>>>>> el-capacity-read OR cpu/el-capacity-read/ [Kernel PMU event] >>>>> >>>>>>> But the event parser does not recognize them that way, e.g. >>>>> >>>>>>> # perf test -v "Parse event" >>>>>>> >>>>>>> running test 54 'cycles//u' >>>>>>> running test 55 'cycles:k' >>>>>>> running test 0 'cpu/config=10,config1,config2=3,period=1000/u' >>>>>>> running test 1 'cpu/config=1,name=krava/u,cpu/config=2/u' >>>>>>> running test 2 'cpu/config=1,call-graph=fp,time,period=100000/,cpu/config=2,call-graph=no,time=0,period=2000/' >>>>>>> running test 3 'cpu/name='COMPLEX_CYCLES_NAME:orig=cycles,desc=chip-clock-ticks',period=0x1,event=0x2/ukp' >>>>>>> -> cpu/event=0,umask=0x11/ >>>>>>> -> cpu/event=0,umask=0x13/ >>>>>>> -> cpu/event=0x54,umask=0x1/ >>>>>>> failed to parse event 'el-capacity-read:u,cpu/event=el-capacity-read/u', err 1, str 'parser error' >>>>>>> event syntax error: 'el-capacity-read:u,cpu/event=el-capacity-read/u' >>>>>>> \___ parser error test child finished with 1 >>>>>>> ---- end ---- >>>>>>> Parse event definition strings: FAILED! >>>>> >>>>>>> Fix by adding missing Intel CPU events to the event parser. >>>>>>> Missing events were found by using: >>>>> >>>>>>> grep -r EVENT_ATTR_STR arch/x86/events/intel/core.c >>>>>>> >>>>>>> Signed-off-by: Adrian Hunter >>>>>> >>>>>> Acked-by: Jiri Olsa >>>>> >>>>> So, I'm not being able to reproduce this, what an I missing? >>>> >>>> I think you need to be on some really recent intel >>>> which defines events which we did not covered yet >>>> like el-capacity-write in icelake >>> >>> That is why I tried with el-capacity, which is moved to the parser as >>> well, I've replaced el-capacity-read, which I don't have in this Kaby >>> Lake machine, with el-capacity, that is present: >>> >>> [root@seventh ~]# perf list | grep el-capacity >>> el-capacity OR cpu/el-capacity/ [Kernel PMU event] >>> [root@seventh ~]# >> >> I just checked that and it seems to be a "feature" of the parser that it >> gets confused between el-capacity and el-capacity-read. >> >> Making them explicit in parse-events.l makes the problem go away, but I >> wonder now if the parser could be better in this regard. > > so we have that PRE/SUFFIX logic that allows us > to specify any sysfs event term as standalone event > > the lexer in this case below was used to handle special cases.. > and IIUC think having more than one '-' is one of them > > could you check if the patch below will fix that for you? > > jirka > > > --- > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > index 7b1c8ee537cf..347eb3e6794a 100644 > --- a/tools/perf/util/parse-events.l > +++ b/tools/perf/util/parse-events.l > @@ -342,11 +342,15 @@ bpf-output { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_BPF_OUT > * Because the prefix cycles is mixed up with cpu-cycles. > * loads and stores are mixed up with cache event > */ > -cycles-ct { return str(yyscanner, PE_KERNEL_PMU_EVENT); } > -cycles-t { return str(yyscanner, PE_KERNEL_PMU_EVENT); } > -mem-loads { return str(yyscanner, PE_KERNEL_PMU_EVENT); } > -mem-stores { return str(yyscanner, PE_KERNEL_PMU_EVENT); } > -topdown-[a-z-]+ { return str(yyscanner, PE_KERNEL_PMU_EVENT); } > +cycles-ct | > +cycles-t | > +mem-loads | > +mem-stores | > +topdown-[a-z-]+ | > +tx-capacity-read | > +tx-capacity-write | > +el-capacity-read | > +el-capacity-write { return str(yyscanner, PE_KERNEL_PMU_EVENT); } Yes that works, as does tx-capacity-[a-z-]+ el-capacity-[a-z-]+ Do we have an explanation for why we cannot make it accept 3-part names without handling them as special cases? I just tried but it didn't work.