From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B915626F288 for ; Fri, 13 Mar 2026 11:46:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773402369; cv=none; b=R7KwCWz4yS/fRJsVJ+sFZk+/MXrQnn30oAdvTJ/g4GdyIy0b14uFub1SzaAtHc44OCsUyhs9a3z6kzSjoscK2x3Ukkmk3fQtpXWfJ2wfmP+7Eej0rTs+VZUO0f0RGK6KS+HY/PrE6l4U5n1fiwNG06C7u3xhirzVBCZhMychqws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773402369; c=relaxed/simple; bh=p9gRUw/1sa+IWFsrR/fQYGevFbp+SQEbBTw0TZ645PA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GuREkhTC6gYmqky26rbFUs4S64Wvb5JTJAq1vBK6MPMwp6PKnNXRrmc7DdUGur39wkBnBAbYUPtis5dP6eaur9X5az03zs6gCmJwHxV25vmZxlDEOfYGDcPSkaZffe4lYew3tsM3rjcdl5wmA993x1GqDvGEN/eRGK94FXv/Vxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ottyQ+4t; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ORC3YwAP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ottyQ+4t"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ORC3YwAP" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62DAseHu530519 for ; Fri, 13 Mar 2026 11:46:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EQ6rmuUSOwm1bx/rwcwQuU4u+z1BgbLoQv3BSEX4INM=; b=ottyQ+4tYu5wB680 A79unT/3TpojUdSQQx0TmsybiGOQF0u+hXII1YgqqR4W4gYA648qRsjgK8QTbyAD YWi4UgXmcwudls01G7GZ1Gk3yvI6SPd21vOF+obIfujNXK4AfpXug8M98uDzS75T AgNfdRCnDrTRCVu2nGj1y5UL+ZDIwc7ipsAMLucDnHgLE4IqZEX1RAxmfUBRYeq3 aFmHT8G7T48s102xoNZn6QAkGwjysnky1PannEqIuDYBuxswdXhLzb6PNP9iSu8C bjABis1E1XA6xqIlfFPH2d9cZMtGo7TBVgQ8GsTVxpMO3D0KPyYytSwB+zXQoqed xNepFQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvh84r4ar-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 11:46:06 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2aecaae9506so10851825ad.1 for ; Fri, 13 Mar 2026 04:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773402366; x=1774007166; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EQ6rmuUSOwm1bx/rwcwQuU4u+z1BgbLoQv3BSEX4INM=; b=ORC3YwAPGkmUp3oAt8KixazmJqFOEmCmPgkafFdRCNeONChCq/UQoafYZEhJ8lp4uR a49/hjeBW0weThTL898IunPKmXw/X5GVnuy/ABmhj4E9bEnErfTIQuOVHdxZzXMADtzq DOnPINhFqLugBdmD/kvQUnfShp13qLgmc8QqnDVIJUxUobWGzkqwURjWS0oTibVN1MLR 8y7VjTyv3qAEdV5pGU9/0AcFM3DyXIfnTjp0Ymvb0dp2aElD+KlUb1TuW4GJpc3g50i+ snlLIZmADIW9CCDAcn7jOmOnjRc0OHqC6j5ripaDtA79H+pEoL24ox7B9MexYroGUVQa 09yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773402366; x=1774007166; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EQ6rmuUSOwm1bx/rwcwQuU4u+z1BgbLoQv3BSEX4INM=; b=Tnkq0Q+JzirMQQJ+/fdllQLSPUz6h0XBfkzbcrE2sjjZoe5jvQo+V57zQWKucMzVn1 hOljxsLHs3gf1k4ew0XEa5D09P9F6pd5sSpF9kAUKvYaTPEhP0VtNsZY4s+hjdXWzL+d fWlBxe+bU6IEOb8oqcpbroAP5hENBIYKBqsCE+V3BR/H7tkodexztLkmmQ5bO2mmdN6S +uYFbBDIsMzwJPeODrHXm09SK5FwdAJJIyVQvGhDZa5d6Wl1iwdzSmZ7XP6CynbMqT/h lW9abfS6yDAnrTeT1yCr6Hhrz9krK/NWLuWH6L2Mumew3edhMYm8m7UitNl4UYYbHrWy ly3Q== X-Forwarded-Encrypted: i=1; AJvYcCX84GTG8rbV5qQc7D+tsOjKgE/S0a1pJAzf5uHpzeH6f6SoWaJXmGiVZ3k56GQcMnFEOREoRR4zf0eO1E4=@vger.kernel.org X-Gm-Message-State: AOJu0YwWf32VKNcIZpgE4dz1kTDM41XwMX/k6+ulQ/kCWscCk2/M5Xd8 LRjvMQoRwXCi8udwzFaZvDXFrpUxZbW1ebKJ0tYS51pT/lUmkoAhs4qMe0TfVBxgEFktXVi5DF6 LREp9nm4Syrnlf/ntv64Oi1yXVujrRibE6iW7iH/KqMcb2MGOE2mBwReczZ+gJVd+3rY= X-Gm-Gg: ATEYQzwh5J3UlY6U2lG8Gl2Sy8N9bH/fE5SoFmdCN409vk6ehAYqM0kb1vn+eRFvyrp +2Yz0yQsVgA7MDuetB5ffmQ+hwZOqRoUsLEsP5rrPmad++bG7mpbuwOvND39A8YexDMEVkgku/7 i5H1ri4PcWGnjWwDPGxlIItkyb5OXQICHFAf0cu1WeIwEy+1KVmvQFPxP/+Fvq17h0uODYSSuSa 9FI2IoyudI/9V6ilKX8BTfAbZhZqUERsQntEJuqw3Z2YqY+9o3d31joChvyhVBlEI7ds9iUZ8V+ QjdoecLlEpPJIyOpgC0YcuB+/wLEIlpI1pYIMqRulmRdrZfxIFUqKRdvjBfNfeuG+oDW4f2oA2C PBQ8jDp8/ZGB6QSQH2p1c7Lj7XrE5nLqbt48RmpIpWqNlUY2WhSc= X-Received: by 2002:a17:902:f552:b0:2ae:54e3:9299 with SMTP id d9443c01a7336-2aeba51229cmr56438865ad.21.1773402365552; Fri, 13 Mar 2026 04:46:05 -0700 (PDT) X-Received: by 2002:a17:902:f552:b0:2ae:54e3:9299 with SMTP id d9443c01a7336-2aeba51229cmr56438565ad.21.1773402364893; Fri, 13 Mar 2026 04:46:04 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece83b35fsm23082215ad.80.2026.03.13.04.45.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 04:46:04 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 17:15:55 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/11] dt-bindings: crypto: qcom,ice: Allow power-domain and iface clk To: Krzysztof Kozlowski , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> <20260310-qcom_ice_power_and_clk_vote-v2-1-b9c2a5471d9e@oss.qualcomm.com> <2ac2efad-3533-490e-bb42-f21c4e950277@kernel.org> <972bd9c8-4671-4151-a3a9-d7eccdf83913@kernel.org> Content-Language: en-US From: Harshal Dev In-Reply-To: <972bd9c8-4671-4151-a3a9-d7eccdf83913@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=OMoqHCaB c=1 sm=1 tr=0 ts=69b3f8fe cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=dbIX2S3wHq3ruR6a9lMA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA5MCBTYWx0ZWRfXwl+r/GkXLiZ7 xrjsrbafP14DJsSvOpPCiMiDWCF8RZGYTMev5egTLulsp2p6LwUTaYcAH+46zqKPUb0B1B98/tr IwCC4mnmaj5dybrPapxFR+MKIc95+qQtcxRSzWKnr+bFK54+lpxnB5M++Dp43nbqaRqwKnZzG0/ KwYf53cO7dlJzObXCEI1wAeQ/NVyx/kwJ4S2/D+OqNuJ5pC4JfJEN8cNkObIqBklOSmajkgHIRp BcGZ7nr2c6irdt/Wqp3mz3zgStftZ6qJP8TGnea6IDhFdOnDMP+zFtku35F9+BV4mZEapQph8MG 3w0Nu1ZtWE2eYL/mSycm6hkmrAPWNXja7OClvr8SPz+IGKhjxLIlcxR1KgoMxmB9jCKk9JXj9oJ 1j3VsJ5OXWUdLk7X4gf7+WkQHUhte/0ZxgTi5N3dIeuq+AaTYdyjLgCH16baA9rPbBEYw9myi7e P9kfOLGeBA3AzZEadbA== X-Proofpoint-ORIG-GUID: Cm082Ju-1Eusjy1LZvd7WKo5wZGDtScC X-Proofpoint-GUID: Cm082Ju-1Eusjy1LZvd7WKo5wZGDtScC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130090 Hi Krzysztof, On 3/11/2026 11:58 PM, Krzysztof Kozlowski wrote: > On 11/03/2026 19:25, Krzysztof Kozlowski wrote: >> On 11/03/2026 10:37, Harshal Dev wrote: >>> >>> >>> On 3/11/2026 1:55 AM, Krzysztof Kozlowski wrote: >>>> On 10/03/2026 09:06, Harshal Dev wrote: >>>>> Update the inline-crypto engine DT binding to allow specifying up to two >>>>> clocks along with their names and associated power-domain. When the >>>>> 'clk_ignore_unused' flag is not passed on the kernel command line >>>>> occasional unclocked ICE hardware register access are observed during ICE >>>>> driver probe based on the relative timing between the probe and the kernel >>>>> disabling the unused clocks. On the other hand, when the 'pd_ignore_unused' >>>>> flag is not passed on the command line, clock 'stuck' issues are >>>>> observed if the power-domain required by ICE hardware is unused and thus >>>>> disabled before ICE probe. To avoid these scenarios, the 'iface' clock and >>>>> the associated power-domain should be specified in the ICE device tree node >>>>> and the 'iface' clock should be voted on by the ICE driver during probe. >>>>> >>>>> Fixes: f6ff91a47ac57 ("dt-bindings: crypto: Add Qualcomm Inline Crypto Engine") >>>>> Signed-off-by: Harshal Dev >>>>> --- >>>>> .../bindings/crypto/qcom,inline-crypto-engine.yaml | 16 +++++++++++++++- >>>>> 1 file changed, 15 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >>>>> index c3408dcf5d20..d9a0a8adf645 100644 >>>>> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >>>>> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >>>>> @@ -28,6 +28,16 @@ properties: >>>>> maxItems: 1 >>>>> >>>>> clocks: >>>>> + minItems: 1 >>>>> + maxItems: 2 >>>>> + >>>>> + clock-names: >>>>> + minItems: 1 >>>>> + items: >>>>> + - const: ice_core_clk >>>> >>>> core >>> >>> Ack. I'll introduce a check for this specific name here as well: >>> https://elixir.bootlin.com/linux/v7.0-rc3/source/drivers/soc/qcom/ice.c#L582 >>> >>>> >>>>> + - const: iface_clk >>>> >>>> iface or bus >>> >>> Ack, will call it 'iface'. >>> >>>> >>>> I don't understand why this is flexible and commit msg does not explain >>>> that. Devices do not have one and two clocks at the same time. You miss >>>> proper constraints. >>>> >>> >>> I agree, it might confuse someone reading the commit message the first time. >>> I'll re-write the commit message to make it explicit that even though these >>> two properties are 'required', for the time being we are introducing 'iface' >>> clk and 'power-domain' as an optional property to maintain bisectability, >>> and that the properties would be made 'required' in a subsequent commit once >>> the DTS changes which are part of this patch series have reached the top tree. >>> >>> Let me know if any concerns with this kind of commit message. >> >> So you are adding it for backwards compatibility? It's fine then, >> although I had impression you are fixing something which is not working >> correctly. New devices will need to constrain this. > Yes, this is for backward compatibility. > Except new devices, like Eliza and Milos. And then this should go to > current fixes. I'm not sure if I understand correctly, do you mean to say that except for Eliza and Milos, new devices need to change their DT binding to 'required' with corresponding DTS changes. And then, the patch updating the DT binding also needs to be back-ported? I'm assuming you're leaving out Eliza and Milos because they aren't supported on the stable branches yet? Apologies in advance if you meant something else and I have completely misunderstood your comment. Regards, Harshal > > Best regards, > Krzysztof