From: Markus Elfring <Markus.Elfring@web.de>
To: "Hao Ge" <gehao@kylinos.cn>,
linux-integrity@vger.kernel.org,
"Jarkko Sakkinen" <jarkko@kernel.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Peter Hüwe" <peterhuewe@gmx.de>
Cc: Hao Ge <hao.ge@linux.dev>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: Move dereference after NULL check in tpm_buf_check_hmac_response
Date: Tue, 9 Jul 2024 08:04:26 +0200 [thread overview]
Message-ID: <fc4323b7-c7f9-47c5-a7eb-4034d2e18bcf@web.de> (raw)
In-Reply-To: <20240709023337.102509-1-hao.ge@linux.dev>
> We shouldn't dereference "auth" until after we have checked that it is
> non-NULL.
How do you think about to improve such a change description with imperative wordings?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc7#n94
> Fixes: 7ca110f2679b ("tpm: Address !chip->auth in tpm_buf_append_hmac_session*()")
1. Would the commit 1085b8276bb4239daa7008f0dcd5c973e4bd690f ("tpm:
Add the rest of the session HMAC API") be more appropriate as a reference?
2. Would you like to add a “stable tag” accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.10-rc7#n34
3. How do you think about to append parentheses to a function name
in the summary phrase?
Regards,
Markus
next prev parent reply other threads:[~2024-07-09 6:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 2:33 Hao Ge
2024-07-09 6:04 ` Markus Elfring [this message]
2024-07-14 15:43 ` Jarkko Sakkinen
2024-07-15 7:24 ` [PATCH v2] " Hao Ge
2024-07-15 8:29 ` [PATCH] " Hao Ge
2024-07-15 11:25 ` Jarkko Sakkinen
2024-07-15 11:52 ` James Bottomley
2024-07-16 10:06 ` Jarkko Sakkinen
2024-07-16 1:04 ` Hao Ge
2024-07-16 10:20 ` Jarkko Sakkinen
2024-07-16 10:33 ` Jarkko Sakkinen
2024-07-16 10:35 ` Jarkko Sakkinen
2024-07-16 10:57 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc4323b7-c7f9-47c5-a7eb-4034d2e18bcf@web.de \
--to=markus.elfring@web.de \
--cc=gehao@kylinos.cn \
--cc=hao.ge@linux.dev \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®