From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E4ED24DD15 for ; Sat, 4 Apr 2026 16:29:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775320176; cv=none; b=li3SdboU3WKD+IDGYEbVSeB2PsSFO9s4i7ZYfhbaH6PEVAN0EwyEN2/B52v12CYOssoXkxNQiu0KVFMDdb2AzGB1H5yP/ONUKw2Q9M6beB4TNADOBxDRqQANBSklDmJ7ol5qOsYdYV7yHwABU1W5u6vnOkmw7/IH9S6cwl00c4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775320176; c=relaxed/simple; bh=J+mH3tlc4DzHrOdvjC92wgc8hfC/3o2s8GlMhvE+s00=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Fhnnd460K4CsGLSBfJUmPEUlDRTBTlfHw3oOYoSoVElBPCZgwx6avX3xHmUbYJC1anLmuzxACr3mIGyU/oOIYIrLOxcj98x1pZ2nzmV8KlrHuak8mFVrvDOwI8SvXUROlEIrO6jx5DSd4A9si8cFScRxTci2vEThaN24yjMeKIs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=FjqMWRoZ; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="FjqMWRoZ" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-46f0fa0e398so979224b6e.1 for ; Sat, 04 Apr 2026 09:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775320172; x=1775924972; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=++8C+TxvxhaCAqikK6VYVaMY+sXmVJh/F3nUP9aaBRo=; b=FjqMWRoZY8egRIS+pC8sqmz1d+eervbT0T9RaLaNDHx2V+K64WQKDoR0sqK2Z7qq/2 L1+04An51bA2B819ZzMZADFhlE6TCn5WTiYf7Y3QzFVjQpt3DKdqGlsz4LvM/wiGJlm2 QGu/L6nzolw5olKLwHmR7DJIcSGC5L7uLgU8j6yYV4Qx9ZtxIZpwSm68XV+m4f5XVMxs j8x4dk7jDrFxenISkI8CVGAJuj3FnwN3aRUPf6OBg2Ol2SS6XvW8/E0ZehnxBxn+8MbN 3aSdNSBVD58piT1McaeTYoJnOwBV3l7Fsi3dgqY9OmyCKvKBwGFHHizCYt2lDAncHACj yINA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775320172; x=1775924972; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=++8C+TxvxhaCAqikK6VYVaMY+sXmVJh/F3nUP9aaBRo=; b=RBSyDbA/O7KA8PQBtTGw6dnX4gqDs22CaxE9Okm4kaFqzgcrnsx7ECJvi5sG79JyZ2 xpXoVMI0iUEn+isJHVf/S55gNYkfQFkawt0XemA0aL/QjXuaDAabUzhpXRCRRuDmpaB/ xMarLTtdOuJ4chIbg0olNtW5azEKg85wMbT+EespT/5hY2hZkjLBE7yi+KSmzVhJjgwi n5sJ7qz9X90iTw79dmTyJYjHF3X8IbuszcCPeEmn+A+hJTVkE6iTSjccdwfDPEMBzL3I MnHsEa4ttJx4/CESOenvFhQOI+i0gqfZZRrfxtvcMcSH3YJ33M46a+s38KQxAA8s5Stj nFxg== X-Forwarded-Encrypted: i=1; AJvYcCXYF0qGOM4zWt1d9NPEb7j1ewsdAPYhqP/sgwgoSuNwv8qfne5ccNbTPGgvabFtpnKiEYGab2jC29WoZCI=@vger.kernel.org X-Gm-Message-State: AOJu0YzFIvNPoupOYCtFDtmkKOi9lK78qzonULOa56msFkdomCREz5AA JLOY8Nzgpx4XZvOCT8x8qrdRW8pYi2kanYi0aQi28XVwd8diAvyuXl+Gygn1f22wddM= X-Gm-Gg: AeBDiesQwdX9rxMxib27Hy9rvDjUhNoChvMeEWk6rFCqrBL8Q9gSZWwBi/YA52WoKwc ujR6H2QnawQwgahxfayt+bisRT6o7RgZ1QzKfwMmESw0w+yJj7yvJDXHD4APw9XMQiUzfFLUC3Z jotFloix+0kvCFmzrixA11mzjBpGbk6mUkHoJD3bnrb18qiQbjEK+Fdernnb+oDjc8yuNhTdZ1X S1b4d3vFdu4H+w2btjL9AqXVKcjsTbql3FwhWEZ8OBafHXjGLqpgb1WgnsqClJCQv1VS88B44FF qrPSEQo4B19sf+WgebwB46NCGW17hRSUioN5L/CU1qQFTGEKbjcn1kEH/HPmloznZp7jd8A1YQf jQXIB3tD8IjMyA7yl9Da3y2SfuxX8ot/Gl4A3mr62nXoRDA+fU/R5riNaXXE4M9bAr84AmgzxaA cBxRjr64EywyrfuKWF6IxbfKWrVG2CW0L/bygvwx2At22tWIuCpFF43zmmC2haSyAS3bWYdIzdb g== X-Received: by 2002:a05:6808:894c:b0:463:927c:1e3d with SMTP id 5614622812f47-46ef66f9cd7mr3956595b6e.23.1775320171996; Sat, 04 Apr 2026 09:29:31 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:e14e:bcc6:3f95:26eb? ([2600:8803:e7e4:500:e14e:bcc6:3f95:26eb]) by smtp.gmail.com with ESMTPSA id 5614622812f47-46d9387a763sm5220382b6e.18.2026.04.04.09.29.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Apr 2026 09:29:30 -0700 (PDT) Message-ID: Date: Sat, 4 Apr 2026 11:29:28 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Move adis16203 inclinometer driver out of staging To: Sheng Kun Chang , jic23@kernel.org Cc: lars@metafoo.de, Michael.Hennerich@analog.com, nuno.sa@analog.com, andy@kernel.org, gregkh@linuxfoundation.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260401162458.88110-1-nothingchang@mirrorstack.ai> Content-Language: en-US From: David Lechner In-Reply-To: <20260401162458.88110-1-nothingchang@mirrorstack.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/1/26 11:24 AM, Sheng Kun Chang wrote: > This series moves the ADIS16203 Programmable 360 Degrees Inclinometer > driver out of staging and into drivers/iio/accel/. > > The driver already uses standard IIO channel interfaces and devm > managed APIs. The only missing piece was devicetree binding > documentation, which is added in patch 1. > > Patch 1: Add devicetree binding documentation > Patch 2: Fix MODULE_LICENSE to match SPDX identifier > Patch 3: Move the driver from staging to drivers/iio/accel/ > > Sheng Kun Chang (3): > dt-bindings: iio: accel: add binding for adi,adis16203 > staging: iio: adis16203: align MODULE_LICENSE with SPDX identifier > iio: accel: move adis16203 out of staging > > .../bindings/iio/accel/adi,adis16203.yaml | 52 +++++++++++++++++++ > drivers/iio/accel/Kconfig | 12 +++++ > drivers/iio/accel/Makefile | 1 + > drivers/{staging => }/iio/accel/adis16203.c | 2 +- > drivers/staging/iio/Kconfig | 1 - > drivers/staging/iio/Makefile | 1 - > drivers/staging/iio/accel/Kconfig | 19 ------- > drivers/staging/iio/accel/Makefile | 6 --- > 8 files changed, 66 insertions(+), 28 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml > rename drivers/{staging => }/iio/accel/adis16203.c (99%) > delete mode 100644 drivers/staging/iio/accel/Kconfig > delete mode 100644 drivers/staging/iio/accel/Makefile > Quite a few people have attempted this already [1]. It is likely not as simple as renaming the file. Please review and give a summary of all of the previous attempts so that all of us reviewers don't have to go read all of those messages. [1]: https://lore.kernel.org/linux-iio/?q=adis16203 And when reading those messages, you should find that the rename patch needs to have the full diff (I think this is the --no-renames option to git format-patch). This way we can review the driver in it's current state one more time to make sure we didn't miss any cleanups that are needed first.