From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7687B1BC41 for ; Sun, 29 Jun 2025 15:55:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751212502; cv=none; b=X6c9iR9c9KBKlFTG/q2/kBuBP96UkNnxKn4fGJlhyN4XYiLOfaI80gSwTZKSazn3usyDDLxmZmZNTm9o1mw02c4VXIO4Sn44RvfF0sbyRe/X/f6UgWhql2Rog9FgUocsEDZeKqy7Axa92b7ExBj+flWPrnWMee7+43J/e8q83Ug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751212502; c=relaxed/simple; bh=7hqeM+s8qGiVK22Wqt9KuDJXdJ0loKcbmmyCBjn9RUk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sYMzEwFjD6UTnMxSIHPnSNzxpV6A/U5TraVo5D//QlULNFaDmMXwShIlGoGQzC7h5pkKZfw1DRKyzZ4AI5HFVsUA7lYfFzVe1MjA5hIpvKMB3ed9j6KO4Vdw25DPyB4OASrYQLFZonq58Ccc5f15CVZbmh3eg4jUoSOeKGyd3Ag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=GVTHQ6K6; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="GVTHQ6K6" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-747fba9f962so3435603b3a.0 for ; Sun, 29 Jun 2025 08:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1751212501; x=1751817301; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=yeqm6Oj1B3MxM+2GGrExdoU2J2pYPcyYcjdp7qgYkEY=; b=GVTHQ6K66Bf/krD1q+aPJTvXkrh5PrujoBwDLR9bX5hOI57/g3rPuWVo0NoRWPU56X uYl84rukuNXx/BIa2abJhN8YHN6WNOaU3F5u6WZozerZJySisocMXU5u/pLXGEdyOopw AWxET2+X83tdGLMPoDRYBZfQ38Q6pwF+0Bb4s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751212501; x=1751817301; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yeqm6Oj1B3MxM+2GGrExdoU2J2pYPcyYcjdp7qgYkEY=; b=kyDd8J3pJphoyKHjyQnCFHQfuDSsfoI3vBpdzvM8t9fB56ns8tB7svdhtplMOPPxVL phyBWx/SWeEYdQcOoyiRYNtxPQFAvMXVVniPgHYDXzbXy61eCBLbrgjJU/EQbPj7v2lN /2exwMVfXg6M3yLlQwjJQnhXhpfACGfTZMbNhP+euay64krJ4ufbw5xsxbi1Y+etnfHo DMF3B49nGXx7Z0NH4dB2ANwH+kN/P8QmIxCNLbVORbQBySCOyoa3I49DAKYvfU0qKuz/ ewGrutjJtQg3bBKjYSiCCjx82UfSC7NQ7pqQCbLINzp2F0lKcLzxkYEK8myercIdHqlN AiCw== X-Forwarded-Encrypted: i=1; AJvYcCVYWxUwcfe9TbzykRWHPanomxSzJV5Q3PwHsIRCGksRuuJYCbkL0EGBOjr3obVayX2LNJ79WQ0jmheuYuI=@vger.kernel.org X-Gm-Message-State: AOJu0YzwyY93UPTPjNt+N6gt75slxunvyUfrgBKQxAq0s8ozeEdpTVed UWjToKfEjEdBQEHLi5iRVTbm+S73C7BXTr4c0yMukLqyjn80iz1LKD+hj5KwZ/fI5A== X-Gm-Gg: ASbGncvE6FXidfR1NjlIcYZCXsD6N/xBsAOP7TvXFF48JPa1uBafUZoAj+bYY9ql8KG trgFDJk99QEXsK8rbzRisTQd7anWw89cuaNZVG/yWh83i0+G8ObagXuhhtGzH3+yNUiwFnjqjIy jQ+FMF7zaj5xQiBLAC5V7TUjTEPX8BfaepCibqW1HSiKhGxVODlBxBZc8uXAGcE2EgAY1ryCxon 3dlH5KGCscC3Fpo7ohmNxjygHkv7OOBhNkiV7O0Tp4ScELbtyiOwDC92z+TCpQMAyx7drEJmql4 JBkYfRc/oB8WF/z1LmLQjfouWP9TQP6OPpYdfBy3lyGYWkCr0S/6p27PsljgEnZ66Evpt9BDSZT 2KuN3Q/79HkLQxJ6rkA== X-Google-Smtp-Source: AGHT+IHvJHjgsPCwgL95BsSO9a9GmLWta/fUIYmxVFQv02LYZIB0gv8b1BqC2du/VWpmBrPa9QD0lg== X-Received: by 2002:a05:6a21:339b:b0:220:51ef:5d23 with SMTP id adf61e73a8af0-220a112e9bdmr17275999637.20.1751212500750; Sun, 29 Jun 2025 08:55:00 -0700 (PDT) Received: from [10.230.3.249] ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74af55c7e89sm7147150b3a.109.2025.06.29.08.54.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Jun 2025 08:54:59 -0700 (PDT) Message-ID: Date: Sun, 29 Jun 2025 08:54:49 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: bcmgenet: Initialize u64 stats seq counter To: Ryo Takakura , opendmb@gmail.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, zakkemble@gmail.com Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250629114109.214057-1-ryotkkr98@gmail.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20250629114109.214057-1-ryotkkr98@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/29/2025 4:41 AM, Ryo Takakura wrote: > Initialize u64 stats as it uses seq counter on 32bit machines > as suggested by lockdep below. > > [ 1.830953][ T1] INFO: trying to register non-static key. > [ 1.830993][ T1] The code is fine but needs lockdep annotation, or maybe > [ 1.831027][ T1] you didn't initialize this object before use? > [ 1.831057][ T1] turning off the locking correctness validator. > [ 1.831090][ T1] CPU: 1 UID: 0 PID: 1 Comm: swapper/0 Tainted: G W 6.16.0-rc2-v7l+ #1 PREEMPT > [ 1.831097][ T1] Tainted: [W]=WARN > [ 1.831099][ T1] Hardware name: BCM2711 > [ 1.831101][ T1] Call trace: > [ 1.831104][ T1] unwind_backtrace from show_stack+0x18/0x1c > [ 1.831120][ T1] show_stack from dump_stack_lvl+0x8c/0xcc > [ 1.831129][ T1] dump_stack_lvl from register_lock_class+0x9e8/0x9fc > [ 1.831141][ T1] register_lock_class from __lock_acquire+0x420/0x22c0 > [ 1.831154][ T1] __lock_acquire from lock_acquire+0x130/0x3f8 > [ 1.831166][ T1] lock_acquire from bcmgenet_get_stats64+0x4a4/0x4c8 > [ 1.831176][ T1] bcmgenet_get_stats64 from dev_get_stats+0x4c/0x408 > [ 1.831184][ T1] dev_get_stats from rtnl_fill_stats+0x38/0x120 > [ 1.831193][ T1] rtnl_fill_stats from rtnl_fill_ifinfo+0x7f8/0x1890 > [ 1.831203][ T1] rtnl_fill_ifinfo from rtmsg_ifinfo_build_skb+0xd0/0x138 > [ 1.831214][ T1] rtmsg_ifinfo_build_skb from rtmsg_ifinfo+0x48/0x8c > [ 1.831225][ T1] rtmsg_ifinfo from register_netdevice+0x8c0/0x95c > [ 1.831237][ T1] register_netdevice from register_netdev+0x28/0x40 > [ 1.831247][ T1] register_netdev from bcmgenet_probe+0x690/0x6bc > [ 1.831255][ T1] bcmgenet_probe from platform_probe+0x64/0xbc > [ 1.831263][ T1] platform_probe from really_probe+0xd0/0x2d4 > [ 1.831269][ T1] really_probe from __driver_probe_device+0x90/0x1a4 > [ 1.831273][ T1] __driver_probe_device from driver_probe_device+0x38/0x11c > [ 1.831278][ T1] driver_probe_device from __driver_attach+0x9c/0x18c > [ 1.831282][ T1] __driver_attach from bus_for_each_dev+0x84/0xd4 > [ 1.831291][ T1] bus_for_each_dev from bus_add_driver+0xd4/0x1f4 > [ 1.831303][ T1] bus_add_driver from driver_register+0x88/0x120 > [ 1.831312][ T1] driver_register from do_one_initcall+0x78/0x360 > [ 1.831320][ T1] do_one_initcall from kernel_init_freeable+0x2bc/0x314 > [ 1.831331][ T1] kernel_init_freeable from kernel_init+0x1c/0x144 > [ 1.831339][ T1] kernel_init from ret_from_fork+0x14/0x20 > [ 1.831344][ T1] Exception stack(0xf082dfb0 to 0xf082dff8) > [ 1.831349][ T1] dfa0: 00000000 00000000 00000000 00000000 > [ 1.831353][ T1] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > [ 1.831356][ T1] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000 > > Fixes: 59aa6e3072aa ("net: bcmgenet: switch to use 64bit statistics") > Signed-off-by: Ryo Takakura Good catch, thank you Ryo! Reviewed-by: Florian Fainelli -- Florian