From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A284BC4332F for ; Fri, 2 Dec 2022 10:33:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232671AbiLBKdu (ORCPT ); Fri, 2 Dec 2022 05:33:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233309AbiLBKdi (ORCPT ); Fri, 2 Dec 2022 05:33:38 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B829C4CF5 for ; Fri, 2 Dec 2022 02:33:36 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id s5so5854874edc.12 for ; Fri, 02 Dec 2022 02:33:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares.net; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/e58gZBtEpImuaapH5z3ZZXyBnJ+7CtdRYYz6q6IemE=; b=FBEXuKdH6DfRsx/hPmSsGMAoEqRA85szN/9ar3oRgmjZKJSW0qhSTMipDJfm2YOWoQ aWCWj3YaFHriFVFVuqIBHBXtPSRJz901i+Ix+WOHoKB1VeZHk0CAHkNfH9Smf9l9Rrvo IM7L/PfDnCGhkeVRsZpsK5387PYAMfyEO9yXca3u/33VOejA35Y3GUqR26S+Fq+2fXAs 7prhT/G8V2D2zcr13/2W37SvVVSd/K4e//HKKA00PKCpBfAe/bn3D9M/KjmGI+m+j4uk sMW66RUtnuKD1kEyUEwzuxEJ6wQ1LSgsuwNLLnkK8vqBclsIMWz3KBejJw9PelhZCz0P Oexw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/e58gZBtEpImuaapH5z3ZZXyBnJ+7CtdRYYz6q6IemE=; b=EYCyMCHDwgY8w2EV31apUb2XN8iLyqYOlrFBpwoMIV/8jAL/fodlZyWmWlEaLUbC68 t/qQF7qIC1/hSWVcUu/jn64J51hIE1YpFBuuxxVKAmUUglbe/0efLFtuLJJgChm9VMSJ dxXb/YqcrtBJ8rSLM5lNIy8eg/Er9OE2IYoOTknEcpRXwdvwc3Ge6EOCoZqvlx6uEFdC u3+3oGZQunqGE3BVsLXmMmXdY3Wyl+Uac7qcS9csOlSqpHXN67L0kBTu3U2ebkv6WgxV PqDJuJYZIrndfucME3VBGkNAGXurCM17P2BvWnzdybWfMIOSQdS9/jMk5ql6tTSbKGWI hK7g== X-Gm-Message-State: ANoB5pmav4FngCiqde1TliGR268VO3X5TJjCTjzlbbx2n+LoZO+XHHJR c4xFjCJ0KUsBc8YkGKYBnTTCMw== X-Google-Smtp-Source: AA0mqf62g7tL05/yrH9Nmc/hP4lJkxbx6iU2/cPHDSx5Oqj8j6hZK8YiIPj5dHAh++pcOEG7PBPo0w== X-Received: by 2002:a05:6402:528d:b0:468:dc9:ec08 with SMTP id en13-20020a056402528d00b004680dc9ec08mr49095306edb.17.1669977214833; Fri, 02 Dec 2022 02:33:34 -0800 (PST) Received: from [10.44.2.26] (84-199-106-91.ifiber.telenet-ops.be. [84.199.106.91]) by smtp.gmail.com with ESMTPSA id q18-20020a1709066b1200b007bf988ce9f7sm2876728ejr.38.2022.12.02.02.33.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 02:33:34 -0800 (PST) Message-ID: Date: Fri, 2 Dec 2022 11:33:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH net-next 00/11] mptcp: PM listener events + selftests cleanup Content-Language: en-GB To: Jakub Kicinski Cc: "David S. Miller" , Eric Dumazet , Mat Martineau , Paolo Abeni , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, mptcp@lists.linux.dev, netdev@vger.kernel.org References: <20221130140637.409926-1-matthieu.baerts@tessares.net> <20221201200953.2944415e@kernel.org> From: Matthieu Baerts In-Reply-To: <20221201200953.2944415e@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jakub, On 02/12/2022 05:09, Jakub Kicinski wrote: > On Wed, 30 Nov 2022 15:06:22 +0100 Matthieu Baerts wrote: >> Thanks to the patch 6/11, the MPTCP path manager now sends Netlink events when >> MPTCP listening sockets are created and closed. The reason why it is needed is >> explained in the linked ticket [1]: >> >> MPTCP for Linux, when not using the in-kernel PM, depends on the userspace PM >> to create extra listening sockets before announcing addresses and ports. Let's >> call these "PM listeners". >> >> With the existing MPTCP netlink events, a userspace PM can create PM listeners >> at startup time, or in response to an incoming connection. Creating sockets in >> response to connections is not optimal: ADD_ADDRs can't be sent until the >> sockets are created and listen()ed, and if all connections are closed then it >> may not be clear to the userspace PM daemon that PM listener sockets should be >> cleaned up. >> >> Hence this feature request: to add MPTCP netlink events for listening socket >> close & create, so PM listening sockets can be managed based on application >> activity. >> >> [1] https://github.com/multipath-tcp/mptcp_net-next/issues/313 >> >> Selftests for these new Netlink events have been added in patches 9,11/11. >> >> The remaining patches introduce different cleanups and small improvements in >> MPTCP selftests to ease the maintenance and the addition of new tests. > > Also could you warp you cover letters at 72 characters? > I need to reflow them before I can read them :( Oops, my bad, I'm sorry for that! Thank you for having reported the issue! I didn't notice I didn't set the limit to 72 chars for the "gitsendemail" file type like I did for "gitcommit" in my current vim config. Done now, next cover-letter should be properly formatted! :) Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net