mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@mandelbit.com>
To: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net 1/3] igb: fix RTNL assertion when resuming from runtime suspend
Date: Sun, 15 Nov 2026 20:37:43 +0100	[thread overview]
Message-ID: <fc4b8168-d8b9-426b-95c5-4a24e93f46b9@mandelbit.com> (raw)
In-Reply-To: <20261113105835.3821433-1-antonio@mandelbit.com>

On 13/11/2026 11:58, Antonio Quartulli wrote:
> Since commit ac8c58f5b535 ("igb: fix deadlock caused by taking RTNL in
> RPM resume path") __igb_resume() doesn't take RTNL for runtime resume,
> but __igb_open() still calls netif_set_real_num_{tx,rx}_queues(), which
> require it. An asynchronous runtime resume (e.g. after the link comes
> back) then triggers "RTNL: assertion failed".
> 
> The queue counts only change on paths that re-open the device under
> RTNL (ethtool -L, SR-IOV reconfiguration): set them in igb_open() only,
> as igc does since commit 6f31d6b643a3 ("igc: Refactor runtime power
> management flow").
> 
> Fixes: ac8c58f5b535 ("igb: fix deadlock caused by taking RTNL in RPM resume path")
> Cc: stable@vger.kernel.org
> Closes: https://bugzilla.ipfire.org/show_bug.cgi?id=13562
> Signed-off-by: Antonio Quartulli <antonio@mandelbit.com>
Sashiko reported an interesting finding that is worth fixing.
Will spin v2.

pw-bot: cr

-- 
Antonio Quartulli

CEO and Co-Founder
Mandelbit Srl
https://www.mandelbit.com


      parent reply	other threads:[~2026-11-15 19:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 10:58 Antonio Quartulli
2026-11-13 10:58 ` [PATCH net 2/3] igb: link queues to NAPIs under RTNL after runtime resume Antonio Quartulli
2026-11-13 10:58 ` [PATCH net 3/3] igb: only allow runtime PM if the device can wake up Antonio Quartulli
2026-11-13 11:03 ` [PATCH net 1/3] igb: fix RTNL assertion when resuming from runtime suspend netdev-bot+sinfo
2026-11-15 19:37 ` Antonio Quartulli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc4b8168-d8b9-426b-95c5-4a24e93f46b9@mandelbit.com \
    --to=antonio@mandelbit.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®