From: Sagi Grimberg <sagi@grimberg.me>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, Chaitanya Kulkarni <kch@nvidia.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Hannes Reinecke <hare@suse.de>, Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH blktests v2 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code
Date: Mon, 21 Aug 2023 10:43:14 +0300 [thread overview]
Message-ID: <fc4d55db-dbd3-d2e5-ab2a-3eed07b30676@grimberg.me> (raw)
In-Reply-To: <u2esnihohobu5jaxgz3xdfpjfvfrnmkklzajjrckdnr6g3i54b@qofopy4bhhlp>
>>> diff --git a/tests/nvme/003 b/tests/nvme/003
>>> index 71b82ce758a3..eed1f549866a 100755
>>> --- a/tests/nvme/003
>>> +++ b/tests/nvme/003
>>> @@ -22,15 +22,8 @@ test() {
>>> _setup_nvmet
>>> - local loop_dev
>>> - local port
>>> - port="$(_create_nvmet_port "${nvme_trtype}")"
>>> -
>>> - loop_dev="$(losetup -f)"
>>> -
>>> - _create_nvmet_subsystem "${def_subsysnqn}" "${loop_dev}"
>>> - _add_nvmet_subsys_to_port "${port}" "${def_subsysnqn}"
>>> + _nvmet_target_setup --blkdev=device
>>
>> --blkdev=device by default no?
>
> Yes. I thought it is better to be explicit in the tests. I don't mind
> dropping --blkdev=device if you think we should use the defaults.
Just wondering why it is different than all the rest of the defaults?
It probably can be omitted from the callers.
prev parent reply other threads:[~2023-08-21 7:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 14:15 [PATCH blktests v2 0/1] Introduce nvmet target setup/cleanup helpers Daniel Wagner
2023-08-18 14:15 ` [PATCH blktests v2 1/3] nvme/{033,034,035,036}: use default subsysnqn variable directly Daniel Wagner
2023-08-18 14:15 ` [PATCH blktests v2 2/3] nvme/{033,034,035,036,37}: drop port handle between passthru target setup and cleanup Daniel Wagner
2023-08-18 14:15 ` [PATCH blktests v2 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code Daniel Wagner
2023-08-20 14:58 ` Sagi Grimberg
2023-08-21 5:57 ` Daniel Wagner
2023-08-21 7:43 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc4d55db-dbd3-d2e5-ab2a-3eed07b30676@grimberg.me \
--to=sagi@grimberg.me \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=jgg@ziepe.ca \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®