mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: guillaume La Roque <glaroque@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: jbrunet@baylibre.com, Neil Armstrong <narmstrong@baylibre.com>,
	khilman@baylibre.com, linux-amlogic@lists.infradead.org,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: meson-g12a: Add Temperature Sensor clock
Date: Fri, 12 Apr 2019 10:25:56 +0200	[thread overview]
Message-ID: <fc4e0fbd-2643-2f37-9cdb-2ec162826e76@baylibre.com> (raw)
In-Reply-To: <CAFBinCBVmPa5hi83B1ZTe-guassHxKQFrN5QOyMJc9s95LJ1cg@mail.gmail.com>

hi martin,


On 4/11/19 11:38 PM, Martin Blumenstingl wrote:
> Hi Guillaume,
>
> On Thu, Apr 11, 2019 at 10:46 AM Guillaume La Roque
> <glaroque@baylibre.com> wrote:
>> Add TS clock used by two temperature sensor
> thank you for working on this!
>
>> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
>> ---
>>  drivers/clk/meson/g12a.c | 31 +++++++++++++++++++++++++++++++
>>  drivers/clk/meson/g12a.h |  3 ++-
>>  2 files changed, 33 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
>> index 3a3134976534..e6d2af6ee8ea 100644
>> --- a/drivers/clk/meson/g12a.c
>> +++ b/drivers/clk/meson/g12a.c
>> @@ -2335,6 +2335,33 @@ static struct clk_regmap g12a_mali = {
>>         },
>>  };
>>
>> +static struct clk_regmap g12a_ts_div = {
>> +       .data = &(struct clk_regmap_div_data){
>> +               .offset = HHI_TS_CLK_CNTL,
>> +               .shift = 0,
>> +               .width = 7,
> buildroot_openlinux_kernel_4.9_fbdev_20180706 uses ".width = 8".
> That matches with the public S922X datasheet from hardkernel which
> states that HHI_TS_CLK_CNTL[7:0] is "ts_clk clk_div"

sorry for this error i'll fix it

>
> Martin

Thanks

guillqume


      reply	other threads:[~2019-04-12  8:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11  8:45 [PATCH 0/2] Add support of Temperature sensor Clock for G12 SoC Guillaume La Roque
2019-04-11  8:45 ` [PATCH 1/2] dt-bindings: clk: g12a-clkc: add Temperature Sensor clock ID Guillaume La Roque
2019-04-11  8:45 ` [PATCH 2/2] clk: meson-g12a: Add Temperature Sensor clock Guillaume La Roque
2019-04-11 21:38   ` Martin Blumenstingl
2019-04-12  8:25     ` guillaume La Roque [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc4e0fbd-2643-2f37-9cdb-2ec162826e76@baylibre.com \
    --to=glaroque@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®