From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8844C4320A for ; Fri, 13 Aug 2021 07:27:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2C346103E for ; Fri, 13 Aug 2021 07:27:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239424AbhHMH2L (ORCPT ); Fri, 13 Aug 2021 03:28:11 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:8408 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239028AbhHMH2I (ORCPT ); Fri, 13 Aug 2021 03:28:08 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GmFR04XZBz8731; Fri, 13 Aug 2021 15:23:40 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 13 Aug 2021 15:27:33 +0800 Received: from [10.67.100.236] (10.67.100.236) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 13 Aug 2021 15:27:33 +0800 Subject: ping//Re: [PATCH -next 2/2] selftests: Fix fscanf warning To: , , , , , , , , , , , , , References: <20210709063741.355325-1-chenlifu@huawei.com> <20210709063741.355325-2-chenlifu@huawei.com> From: chenlifu Message-ID: Date: Fri, 13 Aug 2021 15:27:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210709063741.355325-2-chenlifu@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.100.236] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/7/9 14:37, Chen Lifu 写道: > Compile selftests occurs the following warnings: > make -C tools/testing/selftests > ... > > lib/test_util.c: In function ‘get_trans_hugepagesz’: > lib/test_util.c:138:2: warning: ignoring return value of ‘fscanf’, declared with attribute warn_unused_result [-Wunused-result] > 138 | fscanf(f, "%ld", &size); > | ^~~~~~~~~~~~~~~~~~~~~~~ > x86_64/mmio_warning_test.c: In function ‘get_warnings_count’: > x86_64/mmio_warning_test.c:85:2: warning: ignoring return value of ‘fscanf’, declared with attribute warn_unused_result [-Wunused-result] > 85 | fscanf(f, "%d", &warnings); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > x86_64/xen_shinfo_test.c: In function ‘get_run_delay’: > x86_64/xen_shinfo_test.c:109:9: warning: ignoring return value of ‘fscanf’, declared with attribute warn_unused_result [-Wunused-result] > 109 | fscanf(fp, "%ld %ld ", &val[0], &val[1]); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > steal_time.c: In function ‘get_run_delay’: > steal_time.c:228:2: warning: ignoring return value of ‘fscanf’, declared with attribute warn_unused_result [-Wunused-result] > 228 | fscanf(fp, "%ld %ld ", &val[0], &val[1]); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Check the return value of ‘fscanf’ to fix it. > > Signed-off-by: Chen Lifu > --- > tools/testing/selftests/kvm/lib/test_util.c | 3 ++- > tools/testing/selftests/kvm/steal_time.c | 3 ++- > tools/testing/selftests/kvm/x86_64/mmio_warning_test.c | 3 ++- > tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c | 3 ++- > 4 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/kvm/lib/test_util.c b/tools/testing/selftests/kvm/lib/test_util.c > index af1031fed97f..02ed0d5c3aa5 100644 > --- a/tools/testing/selftests/kvm/lib/test_util.c > +++ b/tools/testing/selftests/kvm/lib/test_util.c > @@ -135,7 +135,8 @@ size_t get_trans_hugepagesz(void) > f = fopen("/sys/kernel/mm/transparent_hugepage/hpage_pmd_size", "r"); > TEST_ASSERT(f != NULL, "Error in opening transparent_hugepage/hpage_pmd_size"); > > - fscanf(f, "%ld", &size); > + if (fscanf(f, "%ld", &size) != 1) > + size = 0; > fclose(f); > > return size; > diff --git a/tools/testing/selftests/kvm/steal_time.c b/tools/testing/selftests/kvm/steal_time.c > index b0031f2d38fd..18f231c45a12 100644 > --- a/tools/testing/selftests/kvm/steal_time.c > +++ b/tools/testing/selftests/kvm/steal_time.c > @@ -225,7 +225,8 @@ static long get_run_delay(void) > > sprintf(path, "/proc/%ld/schedstat", syscall(SYS_gettid)); > fp = fopen(path, "r"); > - fscanf(fp, "%ld %ld ", &val[0], &val[1]); > + if (fscanf(fp, "%ld %ld ", &val[0], &val[1]) != 2) > + val[1] = 0; > fclose(fp); > > return val[1]; > diff --git a/tools/testing/selftests/kvm/x86_64/mmio_warning_test.c b/tools/testing/selftests/kvm/x86_64/mmio_warning_test.c > index e6480fd5c4bd..e770037e5cc9 100644 > --- a/tools/testing/selftests/kvm/x86_64/mmio_warning_test.c > +++ b/tools/testing/selftests/kvm/x86_64/mmio_warning_test.c > @@ -82,7 +82,8 @@ int get_warnings_count(void) > FILE *f; > > f = popen("dmesg | grep \"WARNING:\" | wc -l", "r"); > - fscanf(f, "%d", &warnings); > + if (fscanf(f, "%d", &warnings) != 1) > + warnings = 0; > fclose(f); > > return warnings; > diff --git a/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c b/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c > index 117bf49a3d79..6efda86083f1 100644 > --- a/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c > +++ b/tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c > @@ -106,7 +106,8 @@ static long get_run_delay(void) > > sprintf(path, "/proc/%ld/schedstat", syscall(SYS_gettid)); > fp = fopen(path, "r"); > - fscanf(fp, "%ld %ld ", &val[0], &val[1]); > + if (fscanf(fp, "%ld %ld ", &val[0], &val[1]) != 2) > + val[1] = 0; > fclose(fp); > > return val[1]; >