From: Tinghan Shen <tinghan.shen@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Sudeep Holla <sudeep.holla@arm.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Borislav Petkov <bp@suse.de>, Michal Suchanek <msuchanek@suse.de>,
"Cristian Marussi" <cristian.marussi@arm.com>,
Etienne Carriere <etienne.carriere@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Simon Trimmer <simont@opensource.cirrus.com>,
"John Stultz" <john.stultz@linaro.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
YC Hung <yc.hung@mediatek.com>,
Tzung-Bi Shih <tzungbi@google.com>,
Curtis Malainey <cujomalainey@chromium.org>,
Mark Brown <broonie@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<alsa-devel@alsa-project.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [RESEND PATCH v7 1/1] firmware: mediatek: add adsp ipc protocol interface
Date: Fri, 6 May 2022 19:37:07 +0800 [thread overview]
Message-ID: <fc564f68194b5cc668bb9e7a88cc097d38c9b128.camel@mediatek.com> (raw)
In-Reply-To: <YnQ9UzeyMTkmyGgD@kroah.com>
Hi Greg,
Thanks for your review.
On Thu, 2022-05-05 at 23:10 +0200, Greg Kroah-Hartman wrote:
> On Thu, May 05, 2022 at 01:30:48PM +0800, Tinghan Shen wrote:
> > From: TingHan Shen <tinghan.shen@mediatek.com>
> >
> > Some of mediatek processors contain
> > the Tensilica HiFix DSP for audio processing.
> >
> > The communication between Host CPU and DSP firmware is
> > taking place using a shared memory area for message passing.
> >
> > ADSP IPC protocol offers (send/recv) interfaces using
> > mediatek-mailbox APIs.
> >
> > We use two mbox channels to implement a request-reply protocol.
> >
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > Signed-off-by: TingHan Shen <tinghan.shen@mediatek.com>
> > Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > Reviewed-by: Curtis Malainey <cujomalainey@chromium.org>
> > Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> > Reviewed-by: YC Hung <yc.hung@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> > drivers/firmware/Kconfig | 1 +
> > drivers/firmware/Makefile | 1 +
> > drivers/firmware/mediatek/Kconfig | 9 +
> > drivers/firmware/mediatek/Makefile | 2 +
> > drivers/firmware/mediatek/mtk-adsp-ipc.c | 161 ++++++++++++++++++
> > .../linux/firmware/mediatek/mtk-adsp-ipc.h | 65 +++++++
> > 6 files changed, 239 insertions(+)
> > create mode 100644 drivers/firmware/mediatek/Kconfig
> > create mode 100644 drivers/firmware/mediatek/Makefile
> > create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c
> > create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h
>
> Why do you have a .h file, and export symbols in your .c file, yet you
> have no user of these symbols or header file?
>
> Without a user, we can not take this, sorry.
MediaTek have adsp client drivers on 2 chips that use symbols from this module.
We were planned to upstream them after Linux community accept this module.
I will add those client drivers in next version.
>
> This should just be one single .c file.
>
> Also, why a whole subdirectory for just one .c file?
Ok, I'll move the souce out and remove this subdirectory in next version.
Thank you very much.
Best regards,
TingHan
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2022-05-06 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 5:30 [RESEND PATCH v7 0/1] firmware: mtk: add adsp ipc protocol for SOF Tinghan Shen
2022-05-05 5:30 ` [RESEND PATCH v7 1/1] firmware: mediatek: add adsp ipc protocol interface Tinghan Shen
2022-05-05 21:10 ` Greg Kroah-Hartman
2022-05-06 11:37 ` Tinghan Shen [this message]
2022-05-05 21:11 ` Greg Kroah-Hartman
2022-05-06 11:39 ` Tinghan Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc564f68194b5cc668bb9e7a88cc097d38c9b128.camel@mediatek.com \
--to=tinghan.shen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=bp@suse.de \
--cc=broonie@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=cujomalainey@chromium.org \
--cc=daniel.vetter@ffwll.ch \
--cc=etienne.carriere@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=msuchanek@suse.de \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=simont@opensource.cirrus.com \
--cc=sudeep.holla@arm.com \
--cc=tzimmermann@suse.de \
--cc=tzungbi@google.com \
--cc=yc.hung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®