From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934558AbdBWCVR (ORCPT ); Wed, 22 Feb 2017 21:21:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:58086 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933112AbdBWCVI (ORCPT ); Wed, 22 Feb 2017 21:21:08 -0500 Subject: Re: [GIT PULL] namespaces related fixes for v4.11-rc1 To: "Eric W. Biederman" References: <8760k29cku.fsf@xmission.com> <84361910-ba16-79ff-09cd-c76b3f66cc85@suse.de> <8737f54rue.fsf@xmission.com> Cc: Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, Linux Containers , linux-kernel@vger.kernel.org From: Aleksa Sarai Message-ID: Date: Thu, 23 Feb 2017 13:21:42 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <8737f54rue.fsf@xmission.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> The only known user of this prctl systemd >>> forks all children after the prctl. So no userspace regressions will >>> occur. >> >> Note that runC and containerd (and thus Docker) as well as cri-o use the prctl >> as well -- to be able to collect exit codes from a non-child process (namely to >> collect the exit code from PID 1 in the container). > > Are any of those affected by the change? I would not expect so. As it > would require having children or grand children whose exit codes you > don't want to collect. AFAICS they do appear to work (and runC definitely calls the prctl before it creates the container init process -- so it shouldn't break anything for runC). I was just pointing out that systemd isn't the only major userspace user of the prctl (for future reference). -- Aleksa Sarai Software Engineer (Containers) SUSE Linux GmbH https://www.cyphar.com/