From: Yu Kuai <yukuai1@huaweicloud.com>
To: kernel test robot <lkp@intel.com>,
Yu Kuai <yukuai1@huaweicloud.com>,
song@kernel.org, mariusz.tkaczyk@linux.intel.com, l@damenly.org,
xni@redhat.com
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, yi.zhang@huawei.com,
yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH md-6.12 05/41] md/md-bitmap: add 'sync_size' into struct md_bitmap_stats
Date: Mon, 26 Aug 2024 09:38:47 +0800 [thread overview]
Message-ID: <fc5f783f-2d2b-4066-2a46-c4ed761e661b@huaweicloud.com> (raw)
In-Reply-To: <202408230544.w18wb47U-lkp@intel.com>
Hi,
在 2024/08/23 6:07, kernel test robot 写道:
> Hi Yu,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on device-mapper-dm/for-next]
> [also build test WARNING on linus/master v6.11-rc4 next-20240822]
> [cannot apply to song-md/md-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/md-raid1-use-md_bitmap_wait_behind_writes-in-raid1_read_request/20240822-110233
> base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
> patch link: https://lore.kernel.org/r/20240822024718.2158259-6-yukuai1%40huaweicloud.com
> patch subject: [PATCH md-6.12 05/41] md/md-bitmap: add 'sync_size' into struct md_bitmap_stats
> config: x86_64-randconfig-121-20240822 (https://download.01.org/0day-ci/archive/20240823/202408230544.w18wb47U-lkp@intel.com/config)
> compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240823/202408230544.w18wb47U-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202408230544.w18wb47U-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
>>> drivers/md/md-bitmap.c:2106:26: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long sync_size @@ got restricted __le64 [usertype] sync_size @@
> drivers/md/md-bitmap.c:2106:26: sparse: expected unsigned long sync_size
> drivers/md/md-bitmap.c:2106:26: sparse: got restricted __le64 [usertype] sync_size
So this is actually the old code behavior. I'll fix this. :)
Thanks,
Kuai
> drivers/md/md-bitmap.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, ...):
> include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false
> include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false
>
> vim +2106 drivers/md/md-bitmap.c
>
> 2096
> 2097 int md_bitmap_get_stats(struct bitmap *bitmap, struct md_bitmap_stats *stats)
> 2098 {
> 2099 struct bitmap_counts *counts;
> 2100 bitmap_super_t *sb;
> 2101
> 2102 if (!bitmap)
> 2103 return -ENOENT;
> 2104
> 2105 sb = kmap_local_page(bitmap->storage.sb_page);
>> 2106 stats->sync_size = sb->sync_size;
> 2107 kunmap_local(sb);
> 2108
> 2109 counts = &bitmap->counts;
> 2110 stats->missing_pages = counts->missing_pages;
> 2111 stats->pages = counts->pages;
> 2112
> 2113 stats->events_cleared = bitmap->events_cleared;
> 2114 stats->file = bitmap->storage.file;
> 2115
> 2116 return 0;
> 2117 }
> 2118 EXPORT_SYMBOL_GPL(md_bitmap_get_stats);
> 2119
>
next prev parent reply other threads:[~2024-08-26 1:38 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 2:46 [PATCH md-6.12 00/41] md/md-bitmap: introduce bitmap_operations and make structure internel Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 01/41] md/raid1: use md_bitmap_wait_behind_writes() in raid1_read_request() Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 02/41] md/md-bitmap: replace md_bitmap_status() with a new helper md_bitmap_get_stats() Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 03/41] md: use new helper md_bitmap_get_stats() in update_array_info() Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 04/41] md/md-bitmap: add 'events_cleared' into struct md_bitmap_stats Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 05/41] md/md-bitmap: add 'sync_size' " Yu Kuai
2024-08-22 22:07 ` kernel test robot
2024-08-26 1:38 ` Yu Kuai [this message]
2024-08-22 2:46 ` [PATCH md-6.12 06/41] md/md-bitmap: add 'file_pages' " Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 07/41] md/md-bitmap: add 'behind_writes' and 'behind_wait' " Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 08/41] md/md-cluster: use helper md_bitmap_get_stats() to get pages in resize_bitmaps() Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 09/41] md/md-bitmap: add a new helper md_bitmap_set_pages() Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 10/41] md/md-bitmap: introduce struct bitmap_operations Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 11/41] md/md-bitmap: simplify md_bitmap_create() + md_bitmap_load() Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 12/41] md/md-bitmap: merge md_bitmap_create() into bitmap_operations Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 13/41] md/md-bitmap: merge md_bitmap_load() " Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 14/41] md/md-bitmap: merge md_bitmap_destroy() " Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 15/41] md/md-bitmap: merge md_bitmap_flush() " Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 16/41] md/md-bitmap: make md_bitmap_print_sb() internal Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 17/41] md/md-bitmap: merge md_bitmap_update_sb() into bitmap_operations Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 18/41] md/md-bitmap: merge md_bitmap_status() " Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 19/41] md/md-bitmap: remove md_bitmap_setallbits() Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 20/41] md/md-bitmap: merge bitmap_write_all() into bitmap_operations Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 21/41] md/md-bitmap: merge md_bitmap_dirty_bits() " Yu Kuai
2024-08-22 2:46 ` [PATCH md-6.12 22/41] md/md-bitmap: merge md_bitmap_startwrite() " Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 23/41] md/md-bitmap: merge md_bitmap_endwrite() " Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 24/41] md/md-bitmap: merge md_bitmap_start_sync() " Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 25/41] md/md-bitmap: remove the parameter 'aborted' for md_bitmap_end_sync() Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 26/41] md/md-bitmap: merge md_bitmap_end_sync() into bitmap_operations Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 27/41] md/md-bitmap: merge md_bitmap_close_sync() " Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 28/41] md/md-bitmap: mrege md_bitmap_cond_end_sync() " Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 29/41] md/md-bitmap: merge md_bitmap_sync_with_cluster() " Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 30/41] md/md-bitmap: merge md_bitmap_unplug_async() into md_bitmap_unplug() Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 31/41] md/md-bitmap: merge bitmap_unplug() into bitmap_operations Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 32/41] md/md-bitmap: merge md_bitmap_daemon_work() " Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 33/41] md/md-bitmap: pass in mddev directly for md_bitmap_resize() Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 34/41] md/md-bitmap: merge md_bitmap_resize() into bitmap_operations Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 35/41] md/md-bitmap: merge get_bitmap_from_slot() " Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 36/41] md/md-bitmap: merge md_bitmap_copy_from_slot() into struct bitmap_operation Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 37/41] md/md-bitmap: merge md_bitmap_set_pages() into struct bitmap_operations Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 38/41] md/md-bitmap: merge md_bitmap_free() into bitmap_operations Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 39/41] md/md-bitmap: merge md_bitmap_wait_behind_writes() " Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 40/41] md/md-bitmap: merge md_bitmap_enabled() " Yu Kuai
2024-08-22 2:47 ` [PATCH md-6.12 41/41] md/md-bitmap: make in memory structure internal Yu Kuai
2024-08-22 6:50 ` [PATCH md-6.12 00/41] md/md-bitmap: introduce bitmap_operations and make structure internel Paul Menzel
2024-08-26 1:40 ` Yu Kuai
2024-08-22 8:38 ` Xiao Ni
2024-08-26 1:43 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc5f783f-2d2b-4066-2a46-c4ed761e661b@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=l@damenly.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mariusz.tkaczyk@linux.intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®