From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B395C07E95 for ; Tue, 20 Jul 2021 17:41:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A07961004 for ; Tue, 20 Jul 2021 17:41:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229699AbhGTRBD (ORCPT ); Tue, 20 Jul 2021 13:01:03 -0400 Received: from mga07.intel.com ([134.134.136.100]:10332 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbhGTRAq (ORCPT ); Tue, 20 Jul 2021 13:00:46 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10051"; a="275118706" X-IronPort-AV: E=Sophos;i="5.84,255,1620716400"; d="scan'208";a="275118706" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2021 10:37:03 -0700 X-IronPort-AV: E=Sophos;i="5.84,255,1620716400"; d="scan'208";a="657624266" Received: from devenlop-mobl.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.209.156.160]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2021 10:37:02 -0700 Subject: Re: [PATCH v2 4/4] x86/tdx: Add tdg_debug_enabled() interface To: Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Andy Lutomirski Cc: Peter H Anvin , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , x86@kernel.org, linux-kernel@vger.kernel.org References: <20210720043338.2123695-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210720043338.2123695-5-sathyanarayanan.kuppuswamy@linux.intel.com> <32da2d11-6270-1484-6f28-4e50e58c568a@intel.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: Date: Tue, 20 Jul 2021 10:37:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <32da2d11-6270-1484-6f28-4e50e58c568a@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/20/21 9:34 AM, Dave Hansen wrote: > This patch must be dropped from this series. There is no user for this > code. Please introduce these in the series where they are used. > > We don't know whether this is a good implementation or not without > seeing the users. For instance, should this be an X86_FEATURE? Ok. I will move it to the patchset which really use it. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer