From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751435AbeBWKBE (ORCPT ); Fri, 23 Feb 2018 05:01:04 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:53207 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbeBWKBD (ORCPT ); Fri, 23 Feb 2018 05:01:03 -0500 Subject: Re: [PATCH 3/3] ARM: davinci: mark spi_board_info arrays as const To: Arnd Bergmann , arm-soc , Kevin Hilman CC: Neil Armstrong , Linux ARM , Linux Kernel Mailing List References: <20180220162519.1498223-1-arnd@arndb.de> <20180220162519.1498223-3-arnd@arndb.de> From: Sekhar Nori Message-ID: Date: Fri, 23 Feb 2018 15:30:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 22 February 2018 10:13 PM, Arnd Bergmann wrote: > On Tue, Feb 20, 2018 at 5:24 PM, Arnd Bergmann wrote: >> Building with LTO revealed that three spi_board_info arrays are marked >> __initconst, but not const: >> >> arch/arm/mach-davinci/board-dm365-evm.c: In function 'dm365_evm_init': >> arch/arm/mach-davinci/board-dm365-evm.c:729:30: error: 'dm365_evm_spi_info' causes a section type conflict with 'dm646x_edma_device' >> static struct spi_board_info dm365_evm_spi_info[] __initconst = { >> ^ >> arch/arm/mach-davinci/dm646x.c:603:42: note: 'dm646x_edma_device' was declared here >> static const struct platform_device_info dm646x_edma_device __initconst = { >> >> This marks them const as well, as was originally intended. >> >> Signed-off-by: Arnd Bergmann > > I applied this to the fixes branch now. Thanks Arnd. FWIW now: Acked-by: Sekhar Nori Regards, Sekhar