From: Naina Mehta <quic_nainmeht@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <andersson@kernel.org>,
<mathieu.poirier@linaro.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<manivannan.sadhasivam@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss
Date: Mon, 1 Jul 2024 14:10:20 +0530 [thread overview]
Message-ID: <fc7e3c93-1a79-6911-04c2-19ddc7e298cb@quicinc.com> (raw)
In-Reply-To: <45c95955-51a7-489f-993e-252e8bd63dbd@linaro.org>
On 6/26/2024 9:12 PM, Konrad Dybcio wrote:
> On 24.06.2024 1:21 PM, Naina Mehta wrote:
>>
>>
>> On 6/18/2024 7:08 PM, Konrad Dybcio wrote:
>>>
>>>
>>> On 6/18/24 15:13, Naina Mehta wrote:
>>>> Rename qdss@88800000 memory region as qlink_logging memory region
>>>> and add qdss_mem memory region at address of 0x88500000.
>>>> Split mpss_dsmharq_mem region into 2 separate regions and
>>>> reduce the size of mpssadsp_mem region.
>>>>
>>>> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
>>>> ---
>>>
>>> Alright, we're getting somewhere. The commit message should however motivate
>>> why such changes are necessary. For all we know, the splitting in two is
>>> currently done for no reason, as qdss_mem and qlink_logging_mem are contiguous
>>> - does the firmware have some expectations about them being separate?
>>>
>>
>> Since different DSM region size is required for different modem firmware, mpss_dsmharq_mem region being split into 2 separate regions.
>> This would provide the flexibility to remove the region which is
>> not required for a particular platform.
>> qlink_logging is being added at the memory region at the address of
>> 0x88800000 as the region is being used by modem firmware.
>
> Ok, now put that in the commit message :)
>
> And I suppose:
>
> "This would provide the flexibility to remove the region which is not
> required for a particular platform." - but you still pass both to the
> remoteproc in patch 4. Are these regions mutually exclusive?
>
Yes, for IDP platform, we are using both the DSM regions.
Based on the modem firmware either both the regions have to be used or
only mpss_dsm_mem has to be used.
Regards,
Naina
> Konrad
>
next prev parent reply other threads:[~2024-07-01 8:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 13:13 [PATCH v3 0/5] Add MPSS remoteproc support for SDX75 Naina Mehta
2024-06-18 13:13 ` [PATCH v3 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS Naina Mehta
2024-06-18 13:13 ` [PATCH v3 2/5] remoteproc: qcom: pas: Add SDX75 remoteproc support Naina Mehta
2024-06-18 13:13 ` [PATCH v3 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss Naina Mehta
2024-06-18 13:38 ` Konrad Dybcio
2024-06-24 11:21 ` Naina Mehta
2024-06-26 15:42 ` Konrad Dybcio
2024-07-01 8:40 ` Naina Mehta [this message]
2024-06-18 13:13 ` [PATCH v3 4/5] arm64: dts: qcom: sdx75: Add remoteproc node Naina Mehta
2024-06-18 13:13 ` [PATCH v3 5/5] arm64: dts: qcom: sdx75-idp: enable MPSS " Naina Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc7e3c93-1a79-6911-04c2-19ddc7e298cb@quicinc.com \
--to=quic_nainmeht@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®