From: Bart Van Assche <bvanassche@acm.org>
To: "yukuai (C)" <yukuai3@huawei.com>,
axboe@kernel.dk, andriy.shevchenko@linux.intel.com,
john.garry@huawei.com, ming.lei@redhat.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH -next RFC v2 8/8] sbitmap: wake up the number of threads based on required tags
Date: Fri, 8 Apr 2022 21:16:34 -0700 [thread overview]
Message-ID: <fc82d24f-51d8-5f8c-1a44-6c95da722f54@acm.org> (raw)
In-Reply-To: <4c322eee-3ad9-812f-a341-aa5e91573912@huawei.com>
On 4/8/22 19:17, yukuai (C) wrote:
> I think the reason to wake up 'wake_batch' waiters is to make sure
> wakers will use up 'wake_batch' tags that is just freed, because each
> wakers should aquire at least one tag. Thus I think if we can make sure
> wakers will use up 'wake_batch' tags, it's ok to wake up less waiters.
Hmm ... I think it's up to you to (a) explain this behavior change in
detail in the commit message and (b) to prove that this behavior change
won't cause trouble (I guess this change will cause trouble).
Thanks,
Bart.
next prev parent reply other threads:[~2022-04-09 4:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 7:39 [PATCH -next RFC v2 0/8] improve tag allocation under heavy load Yu Kuai
2022-04-08 7:39 ` [PATCH -next RFC v2 1/8] sbitmap: record the number of waiters for each waitqueue Yu Kuai
2022-04-08 7:39 ` [PATCH -next RFC v2 2/8] blk-mq: call 'bt_wait_ptr()' later in blk_mq_get_tag() Yu Kuai
2022-04-08 14:20 ` Bart Van Assche
2022-04-09 2:09 ` yukuai (C)
2022-04-08 7:39 ` [PATCH -next RFC v2 3/8] sbitmap: make sure waitqueues are balanced Yu Kuai
2022-04-15 6:31 ` Li, Ming
2022-04-15 7:07 ` yukuai (C)
2022-04-08 7:39 ` [PATCH -next RFC v2 4/8] blk-mq: don't preempt tag under heavy load Yu Kuai
2022-04-08 14:24 ` Bart Van Assche
2022-04-09 2:38 ` yukuai (C)
2022-04-08 7:39 ` [PATCH -next RFC v2 5/8] sbitmap: force tag preemption if free tags are sufficient Yu Kuai
2022-04-08 7:39 ` [PATCH -next RFC v2 6/8] blk-mq: force tag preemption for split bios Yu Kuai
2022-04-08 7:39 ` [PATCH -next RFC v2 7/8] blk-mq: record how many tags are needed for splited bio Yu Kuai
2022-04-08 7:39 ` [PATCH -next RFC v2 8/8] sbitmap: wake up the number of threads based on required tags Yu Kuai
2022-04-08 14:31 ` Bart Van Assche
2022-04-09 2:19 ` yukuai (C)
2022-04-08 21:13 ` Bart Van Assche
2022-04-09 2:17 ` yukuai (C)
2022-04-09 4:16 ` Bart Van Assche [this message]
2022-04-09 7:01 ` yukuai (C)
2022-04-12 3:20 ` Bart Van Assche
2022-04-08 19:10 ` [PATCH -next RFC v2 0/8] improve tag allocation under heavy load Jens Axboe
2022-04-09 2:26 ` yukuai (C)
2022-04-09 2:28 ` Jens Axboe
2022-04-09 2:34 ` yukuai (C)
2022-04-09 7:14 ` yukuai (C)
2022-04-09 21:31 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc82d24f-51d8-5f8c-1a44-6c95da722f54@acm.org \
--to=bvanassche@acm.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®