From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37168C63777 for ; Mon, 30 Nov 2020 20:51:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8F512067C for ; Mon, 30 Nov 2020 20:51:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730098AbgK3UvD (ORCPT ); Mon, 30 Nov 2020 15:51:03 -0500 Received: from mga11.intel.com ([192.55.52.93]:60991 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728337AbgK3UvC (ORCPT ); Mon, 30 Nov 2020 15:51:02 -0500 IronPort-SDR: yvFIJimU7A/Scfus2zvlQyQy4ZJ+Bez2gYnBxBN1LYRwIr7hK1UFX24Zcp1CCySvCOoJrAZpVa KSfOF2q8MfPg== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="169210056" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="169210056" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 12:49:21 -0800 IronPort-SDR: l56Kv88FxBl/g7uL0cUWjbZXa/xxgbrCaAcsyNjw772ia5128r3FdUn8oR744As54N2C3ch1GM 22LAH4UIVNVw== X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="480800565" Received: from whsiao-mobl.amr.corp.intel.com (HELO [10.209.17.17]) ([10.209.17.17]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 12:49:21 -0800 Subject: Re: [PATCH] soundwire: Fix error return code in sdw_compute_port_params To: Qinglang Miao , Vinod Koul , Bard Liao , Sanyog Kale Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20201125065035.154262-1-miaoqinglang@huawei.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 30 Nov 2020 11:35:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201125065035.154262-1-miaoqinglang@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/20 12:50 AM, Qinglang Miao wrote: > Fix to return the error code -EINVAL in sdw_compute_port_params > instead of 0. > > Fixes: 9026118f20e2 ("soundwire: Add generic bandwidth allocation algorithm") > Reported-by: Hulk Robot > Signed-off-by: Qinglang Miao Thanks for the patch. The test covers a very unlikely error scenario but nevertheless not a zero probability so the suggested fix makes sense to me. Reviewed-by: Pierre-Louis Bossart > --- > drivers/soundwire/generic_bandwidth_allocation.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/soundwire/generic_bandwidth_allocation.c b/drivers/soundwire/generic_bandwidth_allocation.c > index 0bdef38c9..ad857ac62 100644 > --- a/drivers/soundwire/generic_bandwidth_allocation.c > +++ b/drivers/soundwire/generic_bandwidth_allocation.c > @@ -283,8 +283,10 @@ static int sdw_compute_port_params(struct sdw_bus *bus) > if (ret < 0) > return ret; > > - if (group.count == 0) > + if (group.count == 0) { > + ret = -EINVAL; > goto out; > + } > > params = kcalloc(group.count, sizeof(*params), GFP_KERNEL); > if (!params) { >