From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793690335; b=APeysfkOg0ncrL/xZ9XkxBTuDSnbPNlTh0MPUOcdAl466phK/NgzX/oh5RSPHCOA4H5T cIGdS+qcEJqV3ItsSffVEoesPm9tb8R4IVqCJE4GsKJZtrm6kZVXAmpuW0ozufDKcMS7w qW7skcdT9yhssZgq2/Ab12cC2lji2mx93cbnQPtNeMDCJYmnzLEmNZoXBryNdDFq9ADHx mHUwRkOJE4hTBeZirNiGJsmxGo7xZbnGGaV1gmKukqz/9AcwHfkqb4/pjYVXbfYmoiMF+ BKS/Db6gCTlXHE4NNugIQY3KVeZDDvPJRZoXff6uHRth+8I4FUi9no/GIl0l5RBL6/A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793690335; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Info: X-Proofpoint-ORIG-GUID:X-Authority-Analysis:X-Proofpoint-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=v8pOdlYxikwaLjp8OZvxPrNbyKTUCQqg7s1stn4Ba5s=; b=LgoGH6I8mmarXRUhY+d8CNB/0QaC8D5z9QpM1tcGcSKtt4Qs1GVsurCpqJw9T49NEchK V5AJMoCbwNwk1/5VX5AtDX1SAoa/7wBQ6ZYzUWRg9dfmhtws0Dx7tMOEu6O5l9ekxNf0d rObbvqCnJ+wL5TRwxdqgMfRS4AAHsArBzC8C+hMcVnS2P8W4tUR4ul9tCr1meFhYB+xpA 8hJrmUuMTxJd8Fe2/yTXhD9vaEUAG5yEOfqNHKG22qpkwdLJ6BVgXd69YpNZ3IK1W/ZFK Og97/oO8fxGELvTm/MCxWpeyL+43tO/+i8BYIpVGKnbnsYmSpL1Ik1r2dUkaVCm792g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=dqcF08tC; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=hVAO5Isf; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9737A606A32E for ; Tue, 3 Nov 2026 07:18:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9737A606A32E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=dqcF08tC; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=hVAO5Isf Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A31eL1p471215 for ; Tue, 3 Nov 2026 07:18:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= v8pOdlYxikwaLjp8OZvxPrNbyKTUCQqg7s1stn4Ba5s=; b=dqcF08tCDFFe0kRN F3GsfZg4gjR1L2YUmj2gFaT8A63zPszurxFT8DOQi/rFb/5MYTochGkjFyynBrnp 2RV8I2QSVGJxKLr6XxG0e1MdBrwkkoKnoDSBm6YUv6jIdhQyU+MYidhsYqo9PwWE ET7KTfPFhzWu9oC/14wa2P5dza9Av3E8iJ7CzqbCPIwyMsMD35YWj65VomHbF79d 0+cDEz8AYMfbWmLigiSjLARaI30Hj+Yw2esO8gxrm9e0DujEhKMvUD/khNI29Ccy zLQDfwVok0RCHDtrBiTWyc2r3nfKJsuLijcXSZo2BkpncG/3qR1XcGj2gq9XU1TA Q2Mywg== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hq081tfsr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Nov 2026 07:18:53 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cc7e92f36f9so2862788a12.3 for ; Mon, 02 Nov 2026 23:18:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793690333; x=1794295133; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=v8pOdlYxikwaLjp8OZvxPrNbyKTUCQqg7s1stn4Ba5s=; b=hVAO5IsfdE/rzMifewHHAZbrqY55JGNRRe1yxZmh1Dm2jkAY8hvK4RHG9FveTcSKgN /9YBfCrv0olr9VqPnSq2O04LMBiUXasgP2tPl3fuCt5V5kWdN8M/7HeR5iJDPfLlBqTR pr06WL4ebIZYl5BTMENLuxfebQX0LwAaA48G7uWuJ9FSLWzSMYaHjal6Ihrdw3XuLb7O yjflHRBtyPESc7iRc5DssZANqW/teG7ecP5S9vK6OIGfEx/2CaCbet5+n5aC507/B+Ec iQs/eiOaLEBsTjGMXIZW4yupqQavxxdBWCrfrU/oKZn3KGoqszF69cOO5XnjxPWylHRf igvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793690333; x=1794295133; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=v8pOdlYxikwaLjp8OZvxPrNbyKTUCQqg7s1stn4Ba5s=; b=CZzxfbKKHW3ue8lY3ypWn6cUAieUFhqwOpuk9zgQjR/KC4Dn4NFpmKvrbvNrpHb7BU ypp0e8xElNWGUrep8yEeLg9asGYWuVN6SPF9MteZGaazPvg5tDT1Vja3QlktGuyzbe6H D7a4QvZdPvT434QEGCd5jszn8sbLVwHU+VhSnKP9CF3UUQhUiSN1ndB9THCAB98X7W5W no61D8fbplhz0xXmPdil51d9lsALB1W4xK2TlHfMAjCr+7HzKOMENdMUgS7sG15h4bAh R4a9TnlE7o6peskWVdZgw+OsnNOVJZJRktO9IPAkZdJm9l373dT/nOBA9SlY3r10UZA1 6gWA== X-Forwarded-Encrypted: i=1; AKwUvBwPLL1fs/xaD5bJbMiA8/Y7XlT9G4rnb9Utl5ub/qED7kfavNW/wpooFiuJGtbPnOy2euJfbHRPp7VGklw=@vger.kernel.org X-Gm-Message-State: APuU4Z+XMCNjcnVk96gNbpSs5/8ENL8eYDI6YQmWOz8qnmiPIXKVlPXh MpqocLWgk68LB+R59jQTxtWZO2nkWN0coA15EhbTN/2uEdv6fonjcbFAR99WuCq9l6fC2kjNYdf mKmgwdOa0++8lvURWHPNCrmkzgJ9kwdrSe84TacP8Uc8DbTtAHGX7JvjHX3SHxhGz5kbrcSc88i Q= X-Gm-Gg: AYBFou0BqiecwA4cZwTxsm9WByEdh8rMxhpxc12xNfkf1pKWlZVUkqggvRzcPf7VcT3 /fV4MqPvO9ot5U2EdG2nWfn9R98DZ3yddx4pOCkuoPDiLG8u/L6W9b5sN3LWvuWrgpHkgoyLnO+ 0YPbVuaY851exBNoKOxxVNBR9cgcw14bmNujqCEzWuAOAfBcXKnJOkPlTSOnDhL3Tj5w8TmkoMX yjiH70X2Hj2kOfVveK7hn0iDxaHuyNeeHBU4D+dTlh4JTaQ7CvZMg6aRtIO9YSsU1S4jgvIn+z+ vhSiwKcOksyxmeFnzUKl9ZUB5sN9Hyh71Lmc2527Fm2kNu/bvjXOhG/H/lLkkak9a62cG2fAa9W 821dDrezBD1k7oBoHFJWno9RLu8i5abZCs5ydX0ROlpNIuXVKok9p+Pyj7tBUNTKGarimnn3Txj xou/E= X-Received: by 2002:a17:903:37c7:b0:2e8:b5b2:a9f9 with SMTP id d9443c01a7336-2eb364e9f75mr109570995ad.37.1793690333080; Mon, 02 Nov 2026 23:18:53 -0800 (PST) X-Received: by 2002:a17:903:37c7:b0:2e8:b5b2:a9f9 with SMTP id d9443c01a7336-2eb364e9f75mr109570835ad.37.1793690332620; Mon, 02 Nov 2026 23:18:52 -0800 (PST) Received: from [10.217.218.73] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2eb39298329sm35935305ad.61.2026.11.02.23.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Nov 2026 23:18:52 -0800 (PST) Message-ID: Date: Tue, 3 Nov 2026 12:48:46 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] i2c: qcom-geni: Add bus recovery support for GPI DMA mode To: Mukesh Savaliya , Vinod Koul , Frank Li , Viken Dadhaniya , Andi Shyti Cc: naresh.maramaina@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org References: <20261027-20260826_aniket_randive_oss_qualcomm_com-v3-0-7f2a6e572de9@oss.qualcomm.com> <20261027-20260826_aniket_randive_oss_qualcomm_com-v3-3-7f2a6e572de9@oss.qualcomm.com> Content-Language: en-US From: Aniket RANDIVE In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMTAzMDAyOCBTYWx0ZWRfX1hUngj+5eKra Rmjfkn++9HTQuCj46RLsNVwNiuXLFmqqLiys+3kVXpb7MIv0IIpG9dGqWUapcExBUeiPSh0vUOw GGUQfPhM/OT9NZToC8di+YmSpOufD7k= X-Proofpoint-ORIG-GUID: J6JAFk8_AxXQaxvX-uHMP4UoYW2eSeFY X-Authority-Analysis: v=2.4 cv=F73C5ahN c=1 sm=1 tr=0 ts=6ae98add cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=SV6vjZuu5MrVPe49oagA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: J6JAFk8_AxXQaxvX-uHMP4UoYW2eSeFY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTAzMDAyOCBTYWx0ZWRfX4ss/kjIv9Qc8 80w7/GyuD0RK+4g2mRFRFy9EpLkAfZpWXP+Z3MBIhyWEX2iQiDrH83RnkWpCsg35UiUdjsx+Ykp n8AVyqYxqNaTDjwhgTrjeiTUSB6FaFttGUzflGs2mMPWDFtoTOJS23u1zMGNSA7TQzGKrNkUmro 8Cekh2D9p7gLK0oenFRuYgGs+4GSXzdsrGewmYFZozMd0zrXb0XjmQqMIQ5y8gdE6rgJhb0nms/ D9/J765hMNeJ4HXsc4XuD3E/DuA4j1NOQoli7UYuGqeG2+VAFNXw/Zp20jK/ZwxqgFdIsBDKACn tqEqWbGM2NXeTeqQuWJxbERzdvmrOVmJSfux1YSyg0y9yYYDVlH8S3vEY2RS0MTU4i2g9V9YP2v ltWFL7qVzzYLev3KvciWLq4HAPrtUbcJ9kxbvGk06mE5Hc6tdpaC9lSdUTM5kdIrFKY+JMIGztu pfard3YomxaTBxgRPtg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-03_01,2026-11-02_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 clxscore=1015 impostorscore=0 adultscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610300000 definitions=main-2611030028 On 10/27/2026 8:01 PM, Mukesh Savaliya wrote: > > > On 10/27/2026 10:43 AM, Aniket Randive wrote: > [...] > >> +static int geni_i2c_gpi_bus_cmd(struct geni_i2c_dev *gi2c, enum >> i2c_op cmd) >> +{ >> +    const struct geni_i2c_clk_fld *itr = gi2c->clk_fld; >> +    struct dma_async_tx_descriptor *desc; >> +    struct gpi_i2c_config peripheral = {}; >> +    struct dma_slave_config config = {}; >> +    unsigned long time_left; >> +    unsigned long flags; >> +    dma_cookie_t cookie; >> +    int ret; >> + >> +    config.peripheral_config = &peripheral; >> +    config.peripheral_size = sizeof(peripheral); >> + >> +    peripheral.set_config  = 1; >> +    peripheral.pack_enable = I2C_PACK_TX | I2C_PACK_RX; >> +    peripheral.cycle_count = itr->t_cycle_cnt; >> +    peripheral.high_count  = itr->t_high_cnt; >> +    peripheral.low_count   = itr->t_low_cnt; >> +    peripheral.clk_div     = itr->clk_div; >> +    peripheral.op          = cmd; >> + >> +    ret = dmaengine_slave_config(gi2c->tx_c, &config); >> +    if (ret) { >> +        dev_err(gi2c->se.dev, "dma config error %d for bus cmd %u\n", >> ret, cmd); >> +        return ret; >> +    } >> + >> +    desc = dmaengine_prep_slave_single(gi2c->tx_c, 0, 0, DMA_MEM_TO_DEV, >> +                       DMA_PREP_INTERRUPT | DMA_CTRL_ACK); >> +    if (!desc) >> +        return -EIO; >> + >> +    desc->callback_result = i2c_gpi_cb_result; >> +    desc->callback_param = gi2c; >> + >> +    cookie = dmaengine_submit(desc); >> +    if (dma_submit_error(cookie)) >> +        return -EIO; > > Rather capture ret and return it if it's an error ? sure. I will make the change in next patch. > >> + >> +    /* >> +     * cur and err are shared with geni_i2c_irq() and the GPI callback >> +     * i2c_gpi_cb_result(); both write err (the IRQ handler under >> +     * gi2c->lock). Reset them under the lock before issuing the >> transfer. >> +     */ >> +    spin_lock_irqsave(&gi2c->lock, flags); >> +    gi2c->cur = NULL; >> +    gi2c->err = 0; >> +    spin_unlock_irqrestore(&gi2c->lock, flags); >> +    reinit_completion(&gi2c->done); > Safe to init before dmaengine_submit().> + dma_async_issue_pending(gi2c- > >tx_c); Agree. I will make the change in next patch. >> + >> +    time_left = wait_for_completion_timeout(&gi2c->done, gi2c- >> >adap.timeout); >> +    if (!time_left) { >> +        dev_err(gi2c->se.dev, "timeout waiting for GPI bus cmd %u\n", >> cmd); >> +        ret = dmaengine_terminate_sync(gi2c->tx_c); >> +        if (ret) >> +            dev_err(gi2c->se.dev, "DMA termination failed for bus cmd >> %u: %d\n", >> +                cmd, ret); >> +        return -ETIMEDOUT; >> +    } >> + >> +    return gi2c->err; >> +} >> +[...]