mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Leo Yan <niayan01@foss.arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Besar Wicaksono <bwicaksono@nvidia.com>,
	Will Deacon <will@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
	Kan Liang <kan.liang@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org,
	James Clark <james.clark@arm.com>
Subject: Re: [RFC/PATCH 1/1] tools headers arm64: Sync arm64's cputype.h with the kernel sources
Date: Tue, 4 Jun 2024 21:01:41 +0100	[thread overview]
Message-ID: <fc940d6d-7ac3-4f69-8ace-459955f72281@foss.arm.com> (raw)
In-Reply-To: <Zl9jLtiFagBcH7oH@J2N7QTR9R3>

On 6/4/24 19:55, Mark Rutland wrote:

[...]

>> Now more and more Arm CPUs support the data source in SPE and share the same
>> data source format. It's not scalable for us to adding every CPU variant
>> into the file util/arm-spe.c.
>>
>> I would like to expose the PMSIDR_EL1.LDS bit (Data source indicator for
>> sampled load instructions) via the 'cap' folder, and then we can save this
>> info into the perf meta data during record phase.
> 
> I'd be happy to expose fields from PMSIDR_EL1.
> 
>> In the perf report, we can parse the meta data and if the
>> PMSIDR_EL1.LDS bit is set, the tool will parse the data source packet
>> based on the common format.
> 
> I don't believe that's right.
> 
> PMSIDR_EL1.LDS indicates that the loaded data source field is
> implemented, but even when it is implemented, the format is
> IMPLEMENTATION DEFINED.

Thanks for correction. PMSIDR_EL1.LDS bit is necessary but not 
sufficient for using the common data source format.

> Today, Arm Ltd implementations happen to share a format, but that isn't
> implied by PMSIDR_EL1.LDS, and there's no guarantee that future CPUs
> will all use the same format.
> 
> For the moment we'll have to keep adding to this list.

I would like to use an opposite way - we can only maintain CPU variants 
with special data source format, otherwise, all other CPUs use the 
common format.

Thanks,
Leo

  reply	other threads:[~2024-06-04 20:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-03 18:33 Arnaldo Carvalho de Melo
2024-06-04  9:11 ` Mark Rutland
2024-06-04 13:53   ` Arnaldo Carvalho de Melo
2024-06-04 14:34     ` Mark Rutland
2024-06-04 18:55       ` Arnaldo Carvalho de Melo
2024-06-04 17:14   ` Leo Yan
2024-06-04 18:55     ` Mark Rutland
2024-06-04 20:01       ` Leo Yan [this message]
2024-06-05  9:32         ` Mark Rutland
2024-08-08  4:37           ` Besar Wicaksono
2024-08-08  8:35             ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc940d6d-7ac3-4f69-8ace-459955f72281@foss.arm.com \
    --to=niayan01@foss.arm.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=bwicaksono@nvidia.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=namhyung@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®