From: Charan Teja Kalla <quic_charante@quicinc.com>
To: David Hildenbrand <david@redhat.com>, <akpm@linux-foundation.org>,
<mhocko@suse.com>, <vbabka@suse.cz>, <pasha.tatashin@soleen.com>,
<shakeelb@google.com>, <sieberf@amazon.com>, <sjpark@amazon.de>,
<william.kucharski@oracle.com>, <willy@infradead.org>,
<quic_pkondeti@quicinc.com>, <minchan@google.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH V4] mm: fix use-after free of page_ext after race with memory-offline
Date: Fri, 26 Aug 2022 13:22:29 +0530 [thread overview]
Message-ID: <fc952f08-f987-9e06-b52d-4a23d66f9d5d@quicinc.com> (raw)
In-Reply-To: <113fd59f-e4c0-4ee1-4196-6c926677947c@quicinc.com>
Hi David,
On 8/23/2022 10:35 PM, Charan Teja Kalla wrote:
>> I kind-of dislike the "loop" labels. Can we come up with a more
>> expressive name?
>>
>> "put_continue"
>>
>> or something?
>>
>>
>> One alternative would be to add to the beginning of the loop, and after
>> the loop sth like
>>
>> if (page_ext) {
>> page_ext_put(page_ext);
>> page_ext = NULL;
>> }
> I think, moving this to beginning of the loop looks cleaner than the
> goto statement. Will spin V5.
>
I have realized that goto looks simpler and cleaner... Raised V5 @
https://lore.kernel.org/all/1661496993-11473-1-git-send-email-quic_charante@quicinc.com/
>
prev parent reply other threads:[~2022-08-26 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 13:50 Charan Teja Kalla
2022-08-18 15:25 ` Michal Hocko
2022-08-23 13:09 ` David Hildenbrand
2022-08-23 17:05 ` Charan Teja Kalla
2022-08-26 7:52 ` Charan Teja Kalla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc952f08-f987-9e06-b52d-4a23d66f9d5d@quicinc.com \
--to=quic_charante@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@google.com \
--cc=pasha.tatashin@soleen.com \
--cc=quic_pkondeti@quicinc.com \
--cc=shakeelb@google.com \
--cc=sieberf@amazon.com \
--cc=sjpark@amazon.de \
--cc=vbabka@suse.cz \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®