From: Mark Brown <broonie@kernel.org>
To: Yang Ruibin <11162571@vivo.com>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v1] drivers:spi:Insert the missing pci_dev_put()before return
Date: Wed, 28 Aug 2024 21:54:31 +0100 [thread overview]
Message-ID: <fc9d3f45-818e-4466-be73-e4fac3cfacd5@sirena.org.uk> (raw)
In-Reply-To: <20240820111236.550379-1-11162571@vivo.com>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On Tue, Aug 20, 2024 at 07:12:35AM -0400, Yang Ruibin wrote:
> Increase the reference count by calling pci_get_slot(), and remember to
> decrement the reference count by calling pci_dev_put().
I haven't seen exactly how but your patch is corrupted and can't be
applied:
Applying: spi: Insert the missing pci_dev_put() before return
error: corrupt patch at line 18
error: could not build fake ancestor
Patch failed at 0001 spi: Insert the missing pci_dev_put() before return
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-08-28 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 11:12 Yang Ruibin
2024-08-28 20:54 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc9d3f45-818e-4466-be73-e4fac3cfacd5@sirena.org.uk \
--to=broonie@kernel.org \
--cc=11162571@vivo.com \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®