From: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com>,
Jens Wiklander <jenswi@kernel.org>,
Sumit Garg <sumit.garg@kernel.org>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org
Subject: Re: [PATCH v3 2/3] tpm: Introduce Qualcomm TPM driver
Date: Mon, 19 Oct 2026 11:47:50 +0530 [thread overview]
Message-ID: <fca1f5e8-2b11-4912-98b0-42ea2e9a3d1b@oss.qualcomm.com> (raw)
In-Reply-To: <atKpjLYdUuugwAUQ@kernel.org>
>> + err = tpm_chip_register(pvt_data->chip);
>> + if (err) {
>> + dev_err(dev, "tpm_chip_register failed with rc=%d\n", err);
>> + goto out_svc_obj;
>> + }
>> +
>> + return 0;
>> +
>> +out_svc_obj:
>> + tpm_qcom_release_object(pvt_data->ctx, tpm_svc_obj);
>
> This is very cleanly laid out driver. This goes perhaps unhealthy
> levels of nitpicking but we usually tend to have newline before
> the next label.
No worries!!
I'll add new line before out_ctx and post next version.
Let me check any other goto usage and update that one too.
--
Regards
Kuldeep
next prev parent reply other threads:[~2026-10-19 6:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 6:37 [PATCH v3 0/3] Add TPM support via Qualcomm TEE TPM TA Kuldeep Singh
2026-10-15 6:37 ` [PATCH v3 1/3] tee: qcomtee: Register qcom.tz.tpm service for discovery Kuldeep Singh
2026-10-15 6:37 ` [PATCH v3 2/3] tpm: Introduce Qualcomm TPM driver Kuldeep Singh
2026-10-16 22:47 ` Jarkko Sakkinen
2026-10-19 6:17 ` Kuldeep Singh [this message]
2026-10-15 6:37 ` [PATCH v3 3/3] MAINTAINERS: Add Qualcomm TPM driver entry Kuldeep Singh
2026-10-16 21:05 ` [PATCH v3 0/3] Add TPM support via Qualcomm TEE TPM TA Jarkko Sakkinen
2026-10-19 6:15 ` Kuldeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fca1f5e8-2b11-4912-98b0-42ea2e9a3d1b@oss.qualcomm.com \
--to=kuldeep.singh@oss.qualcomm.com \
--cc=amirreza.zarrabi@oss.qualcomm.com \
--cc=jarkko@kernel.org \
--cc=jenswi@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=peterhuewe@gmx.de \
--cc=sumit.garg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®